)]}'
{"nova/conf/scheduler.py":[{"author":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"change_message_id":"285de17f7e3caf69f12a8784be5ad6ddbd18342c","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"This value controls how often (in seconds) to run periodic tasks in the"},{"line_number":75,"context_line":"scheduler. The specific tasks that are run for each period are determined by"},{"line_number":76,"context_line":"the particular scheduler being used. Currently the only in-tree scheduler"},{"line_number":77,"context_line":"driver that uses this option is the ``caching_scheduler``."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"If this is larger than the nova-service \u0027service_down_time\u0027 setting, the"},{"line_number":80,"context_line":"ComputeFilter (if enabled) may think the compute service is down. As each"},{"line_number":81,"context_line":"scheduler can work a little differently than the others, be sure to test this"},{"line_number":82,"context_line":"with your selected scheduler."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_696247b0","line":80,"range":{"start_line":76,"start_character":36,"end_line":80,"end_character":73},"updated":"2018-02-14 08:24:10.000000000","message":"you\u0027ve made it clear which scheduler service is going to be down as the periodic task interval is bigger than the service_down_time but how about the computerFilter","commit_id":"4746a0d63862a4bb06a04636e6c0e4be9b38e82e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a5337e1805d2988205c94ef7b72656483067c048","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"This value controls how often (in seconds) to run periodic tasks in the"},{"line_number":75,"context_line":"scheduler. The specific tasks that are run for each period are determined by"},{"line_number":76,"context_line":"the particular scheduler being used. Currently the only in-tree scheduler"},{"line_number":77,"context_line":"driver that uses this option is the ``caching_scheduler``."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"If this is larger than the nova-service \u0027service_down_time\u0027 setting, the"},{"line_number":80,"context_line":"ComputeFilter (if enabled) may think the compute service is down. As each"},{"line_number":81,"context_line":"scheduler can work a little differently than the others, be sure to test this"},{"line_number":82,"context_line":"with your selected scheduler."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_300a571f","line":80,"range":{"start_line":76,"start_character":36,"end_line":80,"end_character":73},"in_reply_to":"3fa0c359_2f267f69","updated":"2018-02-14 14:05:09.000000000","message":"I can\u0027t say I understand the comment. There is no specific option for the ComputeFilter. There is the enabled_filters option, are you suggesting that I mention this as a related option to that one if the ComputeFilter is enabled?","commit_id":"4746a0d63862a4bb06a04636e6c0e4be9b38e82e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"de55f859be42436ef53011864c8ee7bb9805080d","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"This value controls how often (in seconds) to run periodic tasks in the"},{"line_number":75,"context_line":"scheduler. The specific tasks that are run for each period are determined by"},{"line_number":76,"context_line":"the particular scheduler being used. Currently the only in-tree scheduler"},{"line_number":77,"context_line":"driver that uses this option is the ``caching_scheduler``."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"If this is larger than the nova-service \u0027service_down_time\u0027 setting, the"},{"line_number":80,"context_line":"ComputeFilter (if enabled) may think the compute service is down. As each"},{"line_number":81,"context_line":"scheduler can work a little differently than the others, be sure to test this"},{"line_number":82,"context_line":"with your selected scheduler."},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_2f267f69","line":80,"range":{"start_line":76,"start_character":36,"end_line":80,"end_character":73},"in_reply_to":"3fa0c359_696247b0","updated":"2018-02-14 10:12:39.000000000","message":"You\u0027re suggesting we do the inverse of this and note the relationship to the \u0027periodic_task_interval\u0027 option in the \u0027service_down_time\u0027 description? I guess that makes sense","commit_id":"4746a0d63862a4bb06a04636e6c0e4be9b38e82e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"de55f859be42436ef53011864c8ee7bb9805080d","unresolved":false,"context_lines":[{"line_number":76,"context_line":"the particular scheduler being used. Currently the only in-tree scheduler"},{"line_number":77,"context_line":"driver that uses this option is the ``caching_scheduler``."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"If this is larger than the nova-service \u0027service_down_time\u0027 setting, the"},{"line_number":80,"context_line":"ComputeFilter (if enabled) may think the compute service is down. As each"},{"line_number":81,"context_line":"scheduler can work a little differently than the others, be sure to test this"},{"line_number":82,"context_line":"with your selected scheduler."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_4fde6b3e","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":29},"updated":"2018-02-14 10:12:39.000000000","message":"As an unrelated aside, should we codify this to prevent people shooting themselves in the foot?","commit_id":"4746a0d63862a4bb06a04636e6c0e4be9b38e82e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a5337e1805d2988205c94ef7b72656483067c048","unresolved":false,"context_lines":[{"line_number":76,"context_line":"the particular scheduler being used. Currently the only in-tree scheduler"},{"line_number":77,"context_line":"driver that uses this option is the ``caching_scheduler``."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"If this is larger than the nova-service \u0027service_down_time\u0027 setting, the"},{"line_number":80,"context_line":"ComputeFilter (if enabled) may think the compute service is down. As each"},{"line_number":81,"context_line":"scheduler can work a little differently than the others, be sure to test this"},{"line_number":82,"context_line":"with your selected scheduler."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_d03d33c4","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":29},"in_reply_to":"3fa0c359_4fde6b3e","updated":"2018-02-14 14:05:09.000000000","message":"Meh, the CachingScheduler is deprecated so I\u0027m not terribly interested in making it smoother to use.","commit_id":"4746a0d63862a4bb06a04636e6c0e4be9b38e82e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c62ed70adb50d45526e68abe79c7076c039027df","unresolved":false,"context_lines":[{"line_number":76,"context_line":"the particular scheduler being used. Currently the only in-tree scheduler"},{"line_number":77,"context_line":"driver that uses this option is the ``caching_scheduler``."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"If this is larger than the nova-service \u0027service_down_time\u0027 setting, the"},{"line_number":80,"context_line":"ComputeFilter (if enabled) may think the compute service is down. As each"},{"line_number":81,"context_line":"scheduler can work a little differently than the others, be sure to test this"},{"line_number":82,"context_line":"with your selected scheduler."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Possible values:"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_9bafac93","line":82,"range":{"start_line":79,"start_character":0,"end_line":82,"end_character":29},"in_reply_to":"3fa0c359_d03d33c4","updated":"2018-02-28 19:03:38.000000000","message":"+1","commit_id":"4746a0d63862a4bb06a04636e6c0e4be9b38e82e"}],"nova/conf/service.py":[{"author":{"_account_id":27336,"name":"XiaojueGuan","email":"xiaojueguan@gmail.com","username":"XiaojueGuan"},"change_message_id":"285de17f7e3caf69f12a8784be5ad6ddbd18342c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Related Options:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* report_interval (service_down_time should not be less than report_interval)"},{"line_number":52,"context_line":"* scheduler.periodic_task_interval"},{"line_number":53,"context_line":"\"\"\"),"},{"line_number":54,"context_line":"    cfg.BoolOpt(\u0027periodic_enable\u0027,"},{"line_number":55,"context_line":"               default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_49298b34","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":34},"updated":"2018-02-14 08:24:10.000000000","message":"what\u0027s the purpose for adding this annotation along","commit_id":"4746a0d63862a4bb06a04636e6c0e4be9b38e82e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a5337e1805d2988205c94ef7b72656483067c048","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Related Options:"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"* report_interval (service_down_time should not be less than report_interval)"},{"line_number":52,"context_line":"* scheduler.periodic_task_interval"},{"line_number":53,"context_line":"\"\"\"),"},{"line_number":54,"context_line":"    cfg.BoolOpt(\u0027periodic_enable\u0027,"},{"line_number":55,"context_line":"               default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_504fe369","line":52,"range":{"start_line":52,"start_character":12,"end_line":52,"end_character":34},"in_reply_to":"3fa0c359_49298b34","updated":"2018-02-14 14:05:09.000000000","message":"It\u0027s in the \"Related Options\" for the service_down_time option, meaning it\u0027s like a cross-reference, \"if you are reading about this option, make sure you read about that other option that could be affected by changing this one.\" Something like that.","commit_id":"4746a0d63862a4bb06a04636e6c0e4be9b38e82e"}]}