)]}'
{"nova/tests/fixtures.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d242383def7a2805ed764245cd19a664671b4b1","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"            lambda *args, **kwargs: mock.MagicMock()))"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":""},{"line_number":1300,"context_line":"class CinderFixture(fixtures.Fixture):"},{"line_number":1301,"context_line":"    \"\"\"A fixture to volume operations\"\"\""},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":"    # the default project_id in OSAPIFixtures"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_28d8a07d","line":1300,"range":{"start_line":1300,"start_character":6,"end_line":1300,"end_character":19},"updated":"2018-02-15 00:32:24.000000000","message":"Just a note to myself and other reviewers, it\u0027s OK to be doing the reserve/unreserve stub stuff in this fixture and not the NewStyle one below because for new style attach we don\u0027t call reserve/unreserve, we do everything via the volume attachments API (create/update/delete attachment).","commit_id":"12b7d0b561074a65c3143dbc07e2cef4c1079798"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d242383def7a2805ed764245cd19a664671b4b1","unresolved":false,"context_lines":[{"line_number":1380,"context_line":"            else:"},{"line_number":1381,"context_line":"                # This is a test that does not care about the actual details."},{"line_number":1382,"context_line":"                volume \u003d {"},{"line_number":1383,"context_line":"                    \u0027status\u0027: \u0027available\u0027,"},{"line_number":1384,"context_line":"                    \u0027display_name\u0027: \u0027TEST2\u0027,"},{"line_number":1385,"context_line":"                    \u0027attach_status\u0027: \u0027detached\u0027,"},{"line_number":1386,"context_line":"                    \u0027id\u0027: volume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_08db647d","line":1383,"updated":"2018-02-15 00:32:24.000000000","message":"That check below could just live here.","commit_id":"12b7d0b561074a65c3143dbc07e2cef4c1079798"}],"nova/tests/functional/regressions/test_bug_1404867.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d242383def7a2805ed764245cd19a664671b4b1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        server \u003d self.api.post_server({"},{"line_number":47,"context_line":"            \u0027server\u0027: {"},{"line_number":48,"context_line":"                \u0027flavorRef\u0027: \u00271\u0027,"},{"line_number":49,"context_line":"                \u0027name\u0027: \u0027test_volume_backed_rebuild_same_image\u0027,"},{"line_number":50,"context_line":"                \u0027networks\u0027: \u0027none\u0027,"},{"line_number":51,"context_line":"                \u0027block_device_mapping_v2\u0027: ["},{"line_number":52,"context_line":"                    {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_e8bab808","line":49,"range":{"start_line":49,"start_character":25,"end_line":49,"end_character":62},"updated":"2018-02-15 00:32:24.000000000","message":"nit: could rename this to be whatever the test is, or just call it something like \"bfv-%s\" % volume_id?","commit_id":"12b7d0b561074a65c3143dbc07e2cef4c1079798"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d242383def7a2805ed764245cd19a664671b4b1","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # reservation on the instances."},{"line_number":79,"context_line":"        self.api.delete_server(server[\u0027id\u0027])"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        # The volume should no longer be reserved as the deletion of the"},{"line_number":82,"context_line":"        # server should have released all the resources."},{"line_number":83,"context_line":"        self.assertNotIn(volume_id, self.cinder.reserved_volumes)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    @mock.patch(\u0027nova.objects.service.get_minimum_version_all_cells\u0027,"},{"line_number":86,"context_line":"                return_value\u003dcompute_api.CINDER_V3_ATTACH_MIN_COMPUTE_VERSION)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_c8525cdf","line":83,"range":{"start_line":81,"start_character":8,"end_line":83,"end_character":65},"updated":"2018-02-15 00:32:24.000000000","message":"This is where you need to leave a FIXME about the bug, and assert the failure (which will be cleaned up in a later patch).","commit_id":"12b7d0b561074a65c3143dbc07e2cef4c1079798"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5d242383def7a2805ed764245cd19a664671b4b1","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # The volume should no longer have any attachments as instance delete"},{"line_number":106,"context_line":"        # should have removed them."},{"line_number":107,"context_line":"        self.assertNotIn(volume_id, self.cinder.attachments[server_id])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_286f4093","line":107,"updated":"2018-02-15 00:32:24.000000000","message":"same as above","commit_id":"12b7d0b561074a65c3143dbc07e2cef4c1079798"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0515b3050a3f4e11606c92f4fcb99f6d800f92d6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        server \u003d self.api.post_server({"},{"line_number":47,"context_line":"            \u0027server\u0027: {"},{"line_number":48,"context_line":"                \u0027flavorRef\u0027: \u00271\u0027,"},{"line_number":49,"context_line":"                \u0027name\u0027: \u0027test_volume_backed_rebuild_same_image\u0027,"},{"line_number":50,"context_line":"                \u0027networks\u0027: \u0027none\u0027,"},{"line_number":51,"context_line":"                \u0027block_device_mapping_v2\u0027: ["},{"line_number":52,"context_line":"                    {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_480dece6","line":49,"range":{"start_line":49,"start_character":25,"end_line":49,"end_character":62},"updated":"2018-02-15 00:33:19.000000000","message":"nit: rename this something else so it\u0027s test specific? or make the name more generic - we\u0027re not doing a rebuild here.","commit_id":"307623a5ff4fd7bae0e28a03e11233f20fa2c3cd"}]}