)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"824febe95a083ec0f3f5ffcb0ec866fe32d03a01","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If an instance fails to get scheduled, it gets buried in cell0 but"},{"line_number":10,"context_line":"none of it\u0027s block device mappings are stored.  At the API layer,"},{"line_number":11,"context_line":"Nova reserves and creates attachments for new instances when"},{"line_number":12,"context_line":"it gets a create request so these attachments are lost if the"},{"line_number":13,"context_line":"block device mappings are not registered in the database somewhere."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch makes sure that if an instance is being buried in cell0,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa0c359_c8001caf","line":12,"range":{"start_line":12,"start_character":50,"end_line":12,"end_character":54},"updated":"2018-02-15 00:38:00.000000000","message":"\"orphaned\" is likely a more appropriate term.","commit_id":"de0915c6cd7c0b54d553ca4de9b062684c509a60"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"f73a71261dcbab675ea290d5f93c5774c284c62e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"be later removed when the instance is deleted."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I64074923fb741fbf5459f66b8ab1a23c16f3303f"},{"line_number":20,"context_line":"Related-Bug: #1404867"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa0c359_e35f2870","line":20,"updated":"2018-02-15 15:10:47.000000000","message":"I think this should have bug 1713641 as well.","commit_id":"ad9e2a568fcef4f69b185952352db9f651c37ad4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"02fb2366df55e2b80627942c89bc9c4cfda6c101","unresolved":false,"context_lines":[{"line_number":17,"context_line":"be later removed when the instance is deleted."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I64074923fb741fbf5459f66b8ab1a23c16f3303f"},{"line_number":20,"context_line":"Related-Bug: #1404867"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa0c359_a75a8580","line":20,"in_reply_to":"3fa0c359_e35f2870","updated":"2018-02-15 19:15:42.000000000","message":"bug 1713641 is a duplicate so we can just duplicate it","commit_id":"ad9e2a568fcef4f69b185952352db9f651c37ad4"}],"nova/conductor/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"824febe95a083ec0f3f5ffcb0ec866fe32d03a01","unresolved":false,"context_lines":[{"line_number":1072,"context_line":"                # NOTE(mnaser): In order to properly clean-up volumes after"},{"line_number":1073,"context_line":"                #               being buried in cell0, we need to store BDMs."},{"line_number":1074,"context_line":"                if block_device_mapping:"},{"line_number":1075,"context_line":"                    self._create_block_device_mapping("},{"line_number":1076,"context_line":"                       cell0, instance.flavor, instance.uuid,"},{"line_number":1077,"context_line":"                       block_device_mapping)"},{"line_number":1078,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_e8eb98d9","line":1075,"updated":"2018-02-15 00:38:00.000000000","message":"Could we add a simple little unit test that calls _bury_in_cell0 directly with a block_device_mapping, mock out _create_block_device_mapping and assert that we pass in the passed in block_device_mapping list?\n\nI know the functional test eventually asserts this, but a small mock\u0027ed unit test would be nice.","commit_id":"de0915c6cd7c0b54d553ca4de9b062684c509a60"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"824febe95a083ec0f3f5ffcb0ec866fe32d03a01","unresolved":false,"context_lines":[{"line_number":1141,"context_line":"                    self._bury_in_cell0(context, request_spec, exc,"},{"line_number":1142,"context_line":"                                        build_requests\u003d[build_request],"},{"line_number":1143,"context_line":"                                        instances\u003d[instance],"},{"line_number":1144,"context_line":"                                     block_device_mapping\u003dblock_device_mapping)"},{"line_number":1145,"context_line":"                    # This is a placeholder in case the quota recheck fails."},{"line_number":1146,"context_line":"                    instances.append(None)"},{"line_number":1147,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa0c359_08204449","line":1144,"updated":"2018-02-15 00:38:00.000000000","message":"nit: alignment here is weird - could just drop all the args so they are aligned like:\n\nself._bury_in_cell0(\n    context, request_spec, exc,\n    build_requests\u003d[build_request],\n    ...","commit_id":"de0915c6cd7c0b54d553ca4de9b062684c509a60"}]}