)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1fe569bacd2fbee63824f1a8ef5b79c91917a79b","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"                #                provisioning, instance information should be"},{"line_number":1218,"context_line":"                #                removed from ironic node."},{"line_number":1219,"context_line":"                self._remove_instance_info_from_node(node, instance)"},{"line_number":1220,"context_line":"        except Exception:"},{"line_number":1221,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1222,"context_line":"                self._cleanup_deploy(node, instance, network_info)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        self._cleanup_deploy(node, instance, network_info)"},{"line_number":1225,"context_line":"        LOG.info(\u0027Successfully unprovisioned Ironic node %s\u0027,"},{"line_number":1226,"context_line":"                 node.uuid, instance\u003dinstance)"},{"line_number":1227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_70d0c8ca","line":1224,"range":{"start_line":1220,"start_character":8,"end_line":1224,"end_character":58},"updated":"2018-03-07 15:50:55.000000000","message":"Why not make this a finally block?\n\n    try:\n        if node.provision_state in _UNPROVISION_STATES:\n            self._unprovision(instance, node)\n        else:\n            # NOTE(hshiina): if spawn() fails before ironic stars\n            #                provisioning, instance information should be\n            #                removed from ironic node.\n            self._remove_instance_info_from_node(node, instance)\n    finally:\n       self._cleanup_deploy(node, instance, network_info)","commit_id":"1d81a1bf78e78c0f8c6657daac2037c884e084d1"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"894566ac70b2917e28ff815c9ae264aa4b04fee9","unresolved":false,"context_lines":[{"line_number":1217,"context_line":"                #                provisioning, instance information should be"},{"line_number":1218,"context_line":"                #                removed from ironic node."},{"line_number":1219,"context_line":"                self._remove_instance_info_from_node(node, instance)"},{"line_number":1220,"context_line":"        except Exception:"},{"line_number":1221,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1222,"context_line":"                self._cleanup_deploy(node, instance, network_info)"},{"line_number":1223,"context_line":""},{"line_number":1224,"context_line":"        self._cleanup_deploy(node, instance, network_info)"},{"line_number":1225,"context_line":"        LOG.info(\u0027Successfully unprovisioned Ironic node %s\u0027,"},{"line_number":1226,"context_line":"                 node.uuid, instance\u003dinstance)"},{"line_number":1227,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_f5611c3b","line":1224,"range":{"start_line":1220,"start_character":8,"end_line":1224,"end_character":58},"in_reply_to":"df7087c5_70d0c8ca","updated":"2018-03-08 02:38:18.000000000","message":"Thank you for the suggestion.","commit_id":"1d81a1bf78e78c0f8c6657daac2037c884e084d1"}]}