)]}'
{"nova/tests/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c40199376cb9bf864699f767338faa081b2d3809","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                   host_username\u003d\u0027test_username\u0027,"},{"line_number":244,"context_line":"                   host_password\u003d\u0027test_pass\u0027,"},{"line_number":245,"context_line":"                   cluster_name\u003d\u0027test_cluster\u0027,"},{"line_number":246,"context_line":"                   datastore_regex\u003d\u0027.*\u0027,"},{"line_number":247,"context_line":"                   use_linked_clone\u003dFalse, group\u003d\u0027vmware\u0027)"},{"line_number":248,"context_line":"        self.flags(vnc_enabled\u003dFalse,"},{"line_number":249,"context_line":"                   image_cache_subdirectory_name\u003d\u0027vmware_base\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2B970%3D","line":246,"updated":"2014-02-17 22:47:29.000000000","message":"Is this necessary since you made the ESX driver ignore it (AFAICT)?","commit_id":"c27d2dcfa9ee1c91176bb98b0be5765948266e68"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"16cb5c395c828ab83f04c4acaa6cc79f894b095b","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                   host_username\u003d\u0027test_username\u0027,"},{"line_number":244,"context_line":"                   host_password\u003d\u0027test_pass\u0027,"},{"line_number":245,"context_line":"                   cluster_name\u003d\u0027test_cluster\u0027,"},{"line_number":246,"context_line":"                   datastore_regex\u003d\u0027.*\u0027,"},{"line_number":247,"context_line":"                   use_linked_clone\u003dFalse, group\u003d\u0027vmware\u0027)"},{"line_number":248,"context_line":"        self.flags(vnc_enabled\u003dFalse,"},{"line_number":249,"context_line":"                   image_cache_subdirectory_name\u003d\u0027vmware_base\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2B3W4%3D","line":246,"in_reply_to":"AAAAUX%2F%2B4kQ%3D","updated":"2014-02-18 14:43:44.000000000","message":"I see, you moved the datastore code *into* ESX.. I guess I had it backwards.","commit_id":"c27d2dcfa9ee1c91176bb98b0be5765948266e68"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f60c78dec59fc1cf6868a9a009c6c04a03167250","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                   host_username\u003d\u0027test_username\u0027,"},{"line_number":244,"context_line":"                   host_password\u003d\u0027test_pass\u0027,"},{"line_number":245,"context_line":"                   cluster_name\u003d\u0027test_cluster\u0027,"},{"line_number":246,"context_line":"                   datastore_regex\u003d\u0027.*\u0027,"},{"line_number":247,"context_line":"                   use_linked_clone\u003dFalse, group\u003d\u0027vmware\u0027)"},{"line_number":248,"context_line":"        self.flags(vnc_enabled\u003dFalse,"},{"line_number":249,"context_line":"                   image_cache_subdirectory_name\u003d\u0027vmware_base\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUX%2F%2B4kQ%3D","line":246,"in_reply_to":"AAAAUX%2F%2B970%3D","updated":"2014-02-18 12:40:21.000000000","message":"Not sure that I understand your comment here. The problem being addressed is that the ESX driver did not honor what was configured by the datastore_regex. This is what the patch set does. This line is just making sure that the ESX driver is running with a configured datastore regex.","commit_id":"c27d2dcfa9ee1c91176bb98b0be5765948266e68"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"2bb185b4922299e011d0e4194f6d1c3eb89e77fe","unresolved":false,"context_lines":[{"line_number":71,"context_line":"               help\u003d\u0027Name of a VMware Cluster ComputeResource. Used only if \u0027"},{"line_number":72,"context_line":"                    \u0027compute_driver is vmwareapi.VMwareVCDriver.\u0027),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027datastore_regex\u0027,"},{"line_number":74,"context_line":"               help\u003d\u0027Regex to match the name of a datastore.\u0027),"},{"line_number":75,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":76,"context_line":"                 default\u003d5.0,"},{"line_number":77,"context_line":"                 deprecated_name\u003d\u0027vmwareapi_task_poll_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FGgw%3D","line":74,"updated":"2013-11-14 11:59:02.000000000","message":"Help message is not  consistent like others, which point out \n\n        Used only if compute_driver is \u0027\u0027vmwareapi.VMwareESXDriver or \u0027\n         vmwareapi.VMwareVCDriver.\u0027","commit_id":"ace06521954655f62ec51e3687ff4fc0c597d959"},{"author":{"_account_id":6722,"name":"ChangBo Guo(gcb)","email":"guochbo@cn.ibm.com","username":"guochbo"},"change_message_id":"7373fdc6dfd96cc9056587d4f9193980b375544d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"               help\u003d\u0027Name of a VMware Cluster ComputeResource. Used only if \u0027"},{"line_number":72,"context_line":"                    \u0027compute_driver is vmwareapi.VMwareVCDriver.\u0027),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027datastore_regex\u0027,"},{"line_number":74,"context_line":"               help\u003d\u0027Regex to match the name of a datastore.\u0027),"},{"line_number":75,"context_line":"    cfg.FloatOpt(\u0027task_poll_interval\u0027,"},{"line_number":76,"context_line":"                 default\u003d5.0,"},{"line_number":77,"context_line":"                 deprecated_name\u003d\u0027vmwareapi_task_poll_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FGMo%3D","line":74,"in_reply_to":"AAAATn%2F%2FGgw%3D","updated":"2013-11-14 13:05:20.000000000","message":"ignore this,  we need a patch to clean up others :)","commit_id":"ace06521954655f62ec51e3687ff4fc0c597d959"}]}