)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8bdddc7f59dd5b2eedfa082e1abef9a34d524eee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Roman Bogorodskiy \u003crbogorodskiy@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-30 07:29:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Nit: make test_evacuate from compute API DRYer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"test_evacute creates a context in almost every test"},{"line_number":10,"context_line":"and sets its properties. Move that to a method to avoid extra"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2Fs0s%3D","line":7,"updated":"2013-10-30 08:58:33.000000000","message":"I think that you can drop the \"Nit:\"","commit_id":"97d9656bffca1d4b997b02d3c869773df652b0e8"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"3f80858280e44390e52381f4603d544e9084cc1d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Roman Bogorodskiy \u003crbogorodskiy@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-19 04:26:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Nit: make test_evacuate from compute API DRYer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"test_evacute creates a context in almost every test"},{"line_number":10,"context_line":"and sets its properties. Move that to a method to avoid extra"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2BSP8%3D","line":7,"updated":"2013-11-27 21:11:29.000000000","message":"IMHO we use the nit tag in a review to say if you are respinning this can you fix it, but not worth a respin on its own.  With that in mind. If this is a nit then I don\u0027t think its worth a patch on its own.\n\nI think you can just drop the \u0027nit\u0027 tag","commit_id":"7c32e858f45debbf75941f1cac39133da130e11c"},{"author":{"_account_id":6509,"name":"Roman Bogorodskiy","email":"rbogorodskiy@mirantis.com","username":"novel"},"change_message_id":"175520eecf34290625ebe469d54d29dd0d8346b0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Roman Bogorodskiy \u003crbogorodskiy@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-19 04:26:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Nit: make test_evacuate from compute API DRYer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"test_evacute creates a context in almost every test"},{"line_number":10,"context_line":"and sets its properties. Move that to a method to avoid extra"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2BKgQ%3D","line":7,"in_reply_to":"AAAATn%2F%2BSP8%3D","updated":"2013-11-30 07:02:07.000000000","message":"Done","commit_id":"7c32e858f45debbf75941f1cac39133da130e11c"}],"nova/tests/api/openstack/compute/contrib/test_evacuate.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"332a97d0e6a07e01a23d0dd280f59a7c6fd1b052","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":94,"context_line":"        ctxt.user_id \u003d \u0027fake\u0027"},{"line_number":95,"context_line":"        ctxt.project_id \u003d \u0027fake\u0027"},{"line_number":96,"context_line":"        ctxt.is_admin \u003d True"},{"line_number":97,"context_line":"        app \u003d fakes.wsgi_app(fake_auth_context\u003dctxt)"},{"line_number":98,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/servers/%s/action\u0027 % \u0027BAD_UUID\u0027)"},{"line_number":99,"context_line":"        req.method \u003d \u0027POST\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B6yg%3D","side":"PARENT","line":96,"updated":"2013-11-18 15:42:50.000000000","message":"Actually, the last 3 lines all seem unnecessary.  I would just only use context.get_admin_context() and not add the helper","commit_id":"864681ee2703bd278d8856e616000d6f3d8361d1"},{"author":{"_account_id":6509,"name":"Roman Bogorodskiy","email":"rbogorodskiy@mirantis.com","username":"novel"},"change_message_id":"07a3786aed9ad23898faf4138c6873bc32608a9b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":94,"context_line":"        ctxt.user_id \u003d \u0027fake\u0027"},{"line_number":95,"context_line":"        ctxt.project_id \u003d \u0027fake\u0027"},{"line_number":96,"context_line":"        ctxt.is_admin \u003d True"},{"line_number":97,"context_line":"        app \u003d fakes.wsgi_app(fake_auth_context\u003dctxt)"},{"line_number":98,"context_line":"        req \u003d webob.Request.blank(\u0027/v2/fake/servers/%s/action\u0027 % \u0027BAD_UUID\u0027)"},{"line_number":99,"context_line":"        req.method \u003d \u0027POST\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B354%3D","side":"PARENT","line":96,"in_reply_to":"AAAATn%2F%2B6yg%3D","updated":"2013-11-19 05:16:41.000000000","message":"While \u0027is_admin\u0027 is really unnecessary here, user_id and project_id are still required, because \u0027fake\u0027 user_id/project_id are used inside nova.tests.api.openstack.fakes. And yes, context.get_admin_context doesn\u0027t set user_id and project_id.","commit_id":"864681ee2703bd278d8856e616000d6f3d8361d1"}]}
