)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8769cc579957249dad8af0506cd95e4bc9e6fd8","unresolved":false,"context_lines":[{"line_number":4279,"context_line":"            # instance as an optimisation"},{"line_number":4280,"context_line":"            return GuestNumaConfig(allowed_cpus, None, None, None)"},{"line_number":4281,"context_line":""},{"line_number":4282,"context_line":"        if not topology:"},{"line_number":4283,"context_line":"            return GuestNumaConfig(allowed_cpus, None,"},{"line_number":4284,"context_line":"                                   guest_cpu_numa_config, None)"},{"line_number":4285,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_86c8a074","line":4282,"range":{"start_line":4282,"start_character":0,"end_line":4282,"end_character":24},"updated":"2018-02-16 10:08:40.000000000","message":"Could you put a docstring in here indicating the condition that this covers? Namely, the host has no NUMA topology. This will only happen with some libvirt versions and certain platforms.","commit_id":"59db0b1e95ccde715b566db5b22f1146f19e2fea"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"dc43ee0f3c9a330195d8be4dc131125d86b73562","unresolved":false,"context_lines":[{"line_number":4279,"context_line":"            # instance as an optimisation"},{"line_number":4280,"context_line":"            return GuestNumaConfig(allowed_cpus, None, None, None)"},{"line_number":4281,"context_line":""},{"line_number":4282,"context_line":"        if not topology:"},{"line_number":4283,"context_line":"            return GuestNumaConfig(allowed_cpus, None,"},{"line_number":4284,"context_line":"                                   guest_cpu_numa_config, None)"},{"line_number":4285,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_9ece92b2","line":4282,"range":{"start_line":4282,"start_character":0,"end_line":4282,"end_character":24},"in_reply_to":"3fa0c359_86c8a074","updated":"2018-02-17 05:03:32.000000000","message":"Sure.","commit_id":"59db0b1e95ccde715b566db5b22f1146f19e2fea"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8769cc579957249dad8af0506cd95e4bc9e6fd8","unresolved":false,"context_lines":[{"line_number":4310,"context_line":"            guest_cpu_tune.vcpusched.append(vcpusched)"},{"line_number":4311,"context_line":""},{"line_number":4312,"context_line":"        cell_pairs \u003d self._get_cell_pairs(guest_cpu_numa_config, topology)"},{"line_number":4313,"context_line":"        for guest_node_id, (guest_config_cell,"},{"line_number":4314,"context_line":"                            host_cell) in enumerate(cell_pairs):"},{"line_number":4315,"context_line":"            # set NUMATune for the cell"},{"line_number":4316,"context_line":"            guest_numa_tune.memnodes.append("},{"line_number":4317,"context_line":"                self._get_numa_memnode(guest_node_id, host_cell.id))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_c6ca284e","line":4314,"range":{"start_line":4313,"start_character":0,"end_line":4314,"end_character":64},"updated":"2018-02-16 10:08:40.000000000","message":"nit: I personally preferred the previous wrapping :)","commit_id":"59db0b1e95ccde715b566db5b22f1146f19e2fea"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"dc43ee0f3c9a330195d8be4dc131125d86b73562","unresolved":false,"context_lines":[{"line_number":4310,"context_line":"            guest_cpu_tune.vcpusched.append(vcpusched)"},{"line_number":4311,"context_line":""},{"line_number":4312,"context_line":"        cell_pairs \u003d self._get_cell_pairs(guest_cpu_numa_config, topology)"},{"line_number":4313,"context_line":"        for guest_node_id, (guest_config_cell,"},{"line_number":4314,"context_line":"                            host_cell) in enumerate(cell_pairs):"},{"line_number":4315,"context_line":"            # set NUMATune for the cell"},{"line_number":4316,"context_line":"            guest_numa_tune.memnodes.append("},{"line_number":4317,"context_line":"                self._get_numa_memnode(guest_node_id, host_cell.id))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_5ec00a7d","line":4314,"range":{"start_line":4313,"start_character":0,"end_line":4314,"end_character":64},"in_reply_to":"3fa0c359_c6ca284e","updated":"2018-02-17 05:03:32.000000000","message":"Afterthoughts, me too.","commit_id":"59db0b1e95ccde715b566db5b22f1146f19e2fea"}]}