)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f7e2ecf301aa635300252efcf9522257ca99625a","unresolved":false,"context_lines":[{"line_number":1998,"context_line":"            msg \u003d \u0027Instance disappeared during build.\u0027"},{"line_number":1999,"context_line":"            LOG.debug(msg, instance\u003dinstance)"},{"line_number":2000,"context_line":"            self._cleanup_allocated_networks(context, instance,"},{"line_number":2001,"context_line":"                    requested_networks)"},{"line_number":2002,"context_line":"            return build_results.FAILED"},{"line_number":2003,"context_line":"        except Exception as e:"},{"line_number":2004,"context_line":"            if isinstance(e, exception.BuildAbortException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_dfcf50b1","line":2001,"updated":"2018-08-29 22:01:22.000000000","message":"Note to self: I\u0027ve wondered it before and I wonder it again, shouldn\u0027t we call _cleanup_volumes here too?","commit_id":"2a12e62360b02d21d979ae1a4fa68053aa6c7b4c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"156d406e5c3654cbcf3ad7f859821dfe8400d84a","unresolved":false,"context_lines":[{"line_number":1998,"context_line":"            msg \u003d \u0027Instance disappeared during build.\u0027"},{"line_number":1999,"context_line":"            LOG.debug(msg, instance\u003dinstance)"},{"line_number":2000,"context_line":"            self._cleanup_allocated_networks(context, instance,"},{"line_number":2001,"context_line":"                    requested_networks)"},{"line_number":2002,"context_line":"            return build_results.FAILED"},{"line_number":2003,"context_line":"        except Exception as e:"},{"line_number":2004,"context_line":"            if isinstance(e, exception.BuildAbortException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_dbce6e2c","line":2001,"in_reply_to":"3f79a3b5_dfcf50b1","updated":"2018-08-30 16:04:41.000000000","message":"Maybe, note we don\u0027t do it above either if we reschedule, and conductor doesn\u0027t cleanup volumes, which is related to:\n\nhttps://review.openstack.org/#/q/topic:bug/1784353+(status:open+OR+status:merged)\n\nBut this is part of the reason why I wanted to try and consolidate some of this garbage error handling b/c it\u0027s so copy/paste and hard to follow which cleanups are appropriate where.","commit_id":"2a12e62360b02d21d979ae1a4fa68053aa6c7b4c"}]}