)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8afd5a0f1efd9de6659af80239c29a70aa9014fc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add functional test for deleting BFV server with old attach flow"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When creating a new instance and deleting it before it gets scheduled"},{"line_number":10,"context_line":"with the old attachment flow (reserve_volume), the block device mappings"},{"line_number":11,"context_line":"are not persisted to database which means that the clean up fails"},{"line_number":12,"context_line":"because it tries to lookup attachment_id which cannot be lazy loaded."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch adds a (failing) functional test to check for this issue"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa0c359_e8a0ee92","line":11,"range":{"start_line":10,"start_character":47,"end_line":11,"end_character":29},"updated":"2018-02-21 14:26:09.000000000","message":"Well, they are, but not in the block_device_mappings table, they are serialized and stored with the build_requests entry in the API DB.","commit_id":"3120627d9802ceda46c2db387fec8fbc80700338"}],"nova/tests/functional/wsgi/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8afd5a0f1efd9de6659af80239c29a70aa9014fc","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    @mock.patch(\u0027nova.objects.service.get_minimum_version_all_cells\u0027,"},{"line_number":247,"context_line":"                return_value\u003dcompute_api.BFV_RESERVE_MIN_COMPUTE_VERSION)"},{"line_number":248,"context_line":"    def test_bfv_delete_build_request_pre_scheduling_ocata(self, mock_get):"},{"line_number":249,"context_line":"        cinder \u003d self.useFixture(nova_fixtures.CinderFixture(self))"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        volume_id \u003d nova_fixtures.CinderFixture.IMAGE_BACKED_VOL"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa0c359_e8ceae58","line":248,"range":{"start_line":248,"start_character":53,"end_line":248,"end_character":58},"updated":"2018-02-21 14:26:09.000000000","message":"Could be Pike too, really the attachment creation in the API is based on the CINDER_V3_ATTACH_MIN_COMPUTE_VERSION variable, which is the minimum service version for nova-compute, and in the case of that check, it\u0027s queens or newer. So when doing boot from volume with an existing volume, all computes have to be \u003e\u003d CINDER_V3_ATTACH_MIN_COMPUTE_VERSION (Queens) to create the attachment in the API. When attaching a volume to an existing instance, the compute that instance is running on must be Queens or newer.\n\nThe BFV_RESERVE_MIN_COMPUTE_VERSION and CINDER_V3_ATTACH_MIN_COMPUTE_VERSION flags are for different things (BFV_RESERVE_MIN_COMPUTE_VERSION is for a pre-pike compute check).","commit_id":"3120627d9802ceda46c2db387fec8fbc80700338"}]}