)]}'
{"nova/compute/api.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"1c358873d0c55813e18fdaafc86fd51f3cdfcf2c","unresolved":false,"context_lines":[{"line_number":1930,"context_line":"        properties.update(extra_properties or {})"},{"line_number":1931,"context_line":""},{"line_number":1932,"context_line":"        # TODO(xqueralt): Use new style BDM in volume snapshots"},{"line_number":1933,"context_line":"        bdms \u003d self.get_instance_bdms(context, instance)"},{"line_number":1934,"context_line":""},{"line_number":1935,"context_line":"        mapping \u003d []"},{"line_number":1936,"context_line":"        for bdm in bdms:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fnoo%3D","line":1933,"updated":"2013-10-31 11:25:03.000000000","message":"If we are to use new-style BDMs, we should be passing legacy\u003dFalse here, no?","commit_id":"72847ecb2af98971db41bc5333cda599682871fa"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"725489ccd19c80421256e8ac67934b828adcacde","unresolved":false,"context_lines":[{"line_number":1930,"context_line":"        properties.update(extra_properties or {})"},{"line_number":1931,"context_line":""},{"line_number":1932,"context_line":"        # TODO(xqueralt): Use new style BDM in volume snapshots"},{"line_number":1933,"context_line":"        bdms \u003d self.get_instance_bdms(context, instance)"},{"line_number":1934,"context_line":""},{"line_number":1935,"context_line":"        mapping \u003d []"},{"line_number":1936,"context_line":"        for bdm in bdms:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FnDM%3D","line":1933,"in_reply_to":"AAAATn%2F%2Fnoo%3D","updated":"2013-10-31 13:36:51.000000000","message":"Ah - it\u0027s a TODO... meh - remove it if you ask me - we have a BP open for this - it\u0027ll get done soon.","commit_id":"72847ecb2af98971db41bc5333cda599682871fa"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"1c358873d0c55813e18fdaafc86fd51f3cdfcf2c","unresolved":false,"context_lines":[{"line_number":1943,"context_line":"                bdm.pop(field, None)"},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"            volume_id \u003d bdm.get(\u0027volume_id\u0027)"},{"line_number":1946,"context_line":"            if volume_id:"},{"line_number":1947,"context_line":"                # create snapshot based on volume_id"},{"line_number":1948,"context_line":"                volume \u003d self.volume_api.get(context, volume_id)"},{"line_number":1949,"context_line":"                # NOTE(yamahata): Should we wait for snapshot creation?"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fnnk%3D","line":1946,"updated":"2013-10-31 11:25:03.000000000","message":"If we are using the new style BDM - we should be doing it all the way so rather than this why not use if bdm.get(\u0027destination_type\u0027) \u003d\u003d \u0027volume\u0027 instead... This goes for the rest of this method actually.","commit_id":"72847ecb2af98971db41bc5333cda599682871fa"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"725489ccd19c80421256e8ac67934b828adcacde","unresolved":false,"context_lines":[{"line_number":1943,"context_line":"                bdm.pop(field, None)"},{"line_number":1944,"context_line":""},{"line_number":1945,"context_line":"            volume_id \u003d bdm.get(\u0027volume_id\u0027)"},{"line_number":1946,"context_line":"            if volume_id:"},{"line_number":1947,"context_line":"                # create snapshot based on volume_id"},{"line_number":1948,"context_line":"                volume \u003d self.volume_api.get(context, volume_id)"},{"line_number":1949,"context_line":"                # NOTE(yamahata): Should we wait for snapshot creation?"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FnC4%3D","line":1946,"in_reply_to":"AAAATn%2F%2Fnnk%3D","updated":"2013-10-31 13:36:51.000000000","message":"Forget this one too - we are not using new style.","commit_id":"72847ecb2af98971db41bc5333cda599682871fa"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"1c358873d0c55813e18fdaafc86fd51f3cdfcf2c","unresolved":false,"context_lines":[{"line_number":1959,"context_line":"                bdm.pop(\u0027volume_id\u0027)"},{"line_number":1960,"context_line":"                bdm.pop(\u0027connection_info\u0027)"},{"line_number":1961,"context_line":""},{"line_number":1962,"context_line":"            mapping.append(bdm)"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"        for m in block_device.mappings_prepend_dev(properties.get(\u0027mappings\u0027,"},{"line_number":1965,"context_line":"                                                                  [])):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fnf4%3D","line":1962,"updated":"2013-10-31 11:25:03.000000000","message":"We are - for the sake of simplicity for now - keeping all the data in the old format when snapshotting - this is not ideal tho - we should be able to detect which format was used. Maybe not the job for this patch - just saying.\n\nBut if we stick with this for now - we need to make sure that we save only the old style stuff.","commit_id":"72847ecb2af98971db41bc5333cda599682871fa"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"725489ccd19c80421256e8ac67934b828adcacde","unresolved":false,"context_lines":[{"line_number":1959,"context_line":"                bdm.pop(\u0027volume_id\u0027)"},{"line_number":1960,"context_line":"                bdm.pop(\u0027connection_info\u0027)"},{"line_number":1961,"context_line":""},{"line_number":1962,"context_line":"            mapping.append(bdm)"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"        for m in block_device.mappings_prepend_dev(properties.get(\u0027mappings\u0027,"},{"line_number":1965,"context_line":"                                                                  [])):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FnCs%3D","line":1962,"in_reply_to":"AAAATn%2F%2Fnf4%3D","updated":"2013-10-31 13:36:51.000000000","message":"This one too - my bad.","commit_id":"72847ecb2af98971db41bc5333cda599682871fa"}],"nova/tests/compute/test_compute_api.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6a71b022762e288956c9e5d6a8bcfdf13b91060b","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"        self._test_snapshot_and_backup(is_snapshot\u003dFalse,"},{"line_number":1378,"context_line":"                                       with_base_ref\u003dTrue)"},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"    def test_snapshot_volume_backed(self):"},{"line_number":1381,"context_line":"        instance \u003d self._create_instance_obj()"},{"line_number":1382,"context_line":"        instance[\u0027root_device_name\u0027] \u003d \u0027vda\u0027"},{"line_number":1383,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Fl98%3D","line":1380,"updated":"2013-10-31 18:07:08.000000000","message":"I am either crazy, or you are not actually confirming the results anywhere in this test... I hope I am crazy!","commit_id":"5ef212dca0806bef53711fb8219ae1696cf8ff03"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"d52dad3219dbf39cdb036f0f201dd6bc344282c8","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"        self._test_snapshot_and_backup(is_snapshot\u003dFalse,"},{"line_number":1378,"context_line":"                                       with_base_ref\u003dTrue)"},{"line_number":1379,"context_line":""},{"line_number":1380,"context_line":"    def test_snapshot_volume_backed(self):"},{"line_number":1381,"context_line":"        instance \u003d self._create_instance_obj()"},{"line_number":1382,"context_line":"        instance[\u0027root_device_name\u0027] \u003d \u0027vda\u0027"},{"line_number":1383,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FjqA%3D","line":1380,"updated":"2013-11-01 11:48:25.000000000","message":"It\u0027d be nice if this test was split up, but I\u0027m not going to block the patch on this.","commit_id":"eddd8a14cd2393ce7bdb0ec1c7366177371192b2"}]}