)]}'
{"nova/compute/api.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e35c6ca1e33790b815e857ce919748b3204c01d7","unresolved":false,"context_lines":[{"line_number":591,"context_line":"                    raise exception.InstanceTypeDiskTooSmall()"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    def _check_and_transform_bdm(self, base_options, min_count, max_count,"},{"line_number":594,"context_line":"                                 block_device_mapping, image_bdm, legacy_bdm):"},{"line_number":595,"context_line":"        # NOTE (ndipanov): Assume root dev name is \u0027vda\u0027 if not supplied."},{"line_number":596,"context_line":"        #                  It\u0027s needed for legacy conversion to work."},{"line_number":597,"context_line":"        root_device_name \u003d (base_options.get(\u0027root_device_name\u0027) or \u0027vda\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FnHc%3D","line":594,"updated":"2013-10-31 13:42:02.000000000","message":"Another name for the argument here would be awesome too - image_bdm made sense (kind of :) ) inside the _populate_instance_for_bdm method but here it\u0027s just confusing.\n\nCome to think of it - it may be better pass the boot_meta to this method and do all the merging of block_device_mapping + block_device_mapping from image here.","commit_id":"d9cc062ce81720c953cd87f5d3d720519a21664a"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e35c6ca1e33790b815e857ce919748b3204c01d7","unresolved":false,"context_lines":[{"line_number":863,"context_line":"                access_ip_v6, requested_networks, config_drive,"},{"line_number":864,"context_line":"                block_device_mapping, auto_disk_config, reservation_id)"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        image_bdm \u003d \\"},{"line_number":867,"context_line":"                boot_meta.get(\u0027properties\u0027, {}).get(\u0027block_device_mapping\u0027, [])"},{"line_number":868,"context_line":"        block_device_mapping \u003d self._check_and_transform_bdm("},{"line_number":869,"context_line":"            base_options, min_count, max_count,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FnIM%3D","line":866,"updated":"2013-10-31 13:42:02.000000000","message":"Please use a different name like bdms_from_image - something that is not as overloaded and as confusing as this :) Or better yet - keep this local to the _check_and_transform_bdm?","commit_id":"d9cc062ce81720c953cd87f5d3d720519a21664a"}]}