)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e63e1e71ecc807361fda3b756e44c5b1951b1cd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the instance is rebuilt with a different image in the same"},{"line_number":10,"context_line":"host, we don\u0027t need to call placement because there is no change"},{"line_number":11,"context_line":"on resource consuption."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie252271ecfd38a0a1c61c26e323cc03869889f0a"},{"line_number":14,"context_line":"Closes-Bug: #1750623"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf659307_aa125461","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":22},"updated":"2018-04-06 12:49:09.000000000","message":"consumption","commit_id":"83915318f25b1e304432dcddb1807a519185de28"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4e63e1e71ecc807361fda3b756e44c5b1951b1cd","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the instance is rebuilt with a different image in the same"},{"line_number":10,"context_line":"host, we don\u0027t need to call placement because there is no change"},{"line_number":11,"context_line":"on resource consuption."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie252271ecfd38a0a1c61c26e323cc03869889f0a"},{"line_number":14,"context_line":"Closes-Bug: #1750623"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf659307_6a0c3c42","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":2},"updated":"2018-04-06 12:49:09.000000000","message":"in","commit_id":"83915318f25b1e304432dcddb1807a519185de28"}],"nova/scheduler/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"198b988523be1fad393058e58a552f9fc1d1b26d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                                                           request_spec,"},{"line_number":117,"context_line":"                                                           filter_properties)"},{"line_number":118,"context_line":"        resources \u003d utils.resources_from_request_spec(spec_obj)"},{"line_number":119,"context_line":"        is_rebuild \u003d utils.request_is_rebuild(spec_obj)"},{"line_number":120,"context_line":"        alloc_reqs_by_rp_uuid, provider_summaries, allocation_request_version \\"},{"line_number":121,"context_line":"            \u003d None, None, None"},{"line_number":122,"context_line":"        if self.driver.USES_ALLOCATION_CANDIDATES and not is_rebuild:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_458da979","line":119,"updated":"2018-04-06 12:55:51.000000000","message":"Note to self: this might need to change for:\n\nhttps://specs.openstack.org/openstack/nova-specs/specs/rocky/approved/glance-image-traits.html","commit_id":"83915318f25b1e304432dcddb1807a519185de28"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"bd71e526b16b7037d903f499c39acea73b435973","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        return_alternates \u003d return_alternates and return_objects"},{"line_number":166,"context_line":"        selections \u003d self.driver.select_destinations(ctxt, spec_obj,"},{"line_number":167,"context_line":"                instance_uuids, alloc_reqs_by_rp_uuid, provider_summaries,"},{"line_number":168,"context_line":"                allocation_request_version, return_alternates)"},{"line_number":169,"context_line":"        # If `return_objects` is False, we need to convert the selections to"},{"line_number":170,"context_line":"        # the older format, which is a list of host state dicts."},{"line_number":171,"context_line":"        if not return_objects:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_84fe1536","line":168,"updated":"2018-04-10 20:24:12.000000000","message":"Note to self: select_destinations will consider host states for all compute nodes if no provider_summaries are specified, so this will have the intended effect of running the scheduler filters across all compute hosts to make sure the image checks out during a rebuild.","commit_id":"2c6422c0962111e6f08a58031d17e6921ff781ef"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2c4affea9e50dd665655221568f96a068788a08f","unresolved":false,"context_lines":[{"line_number":1254,"context_line":"            return self.placement_api.get("},{"line_number":1255,"context_line":"                \u0027/allocations/%s\u0027 % server_uuid).body[\u0027allocations\u0027]"},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"        def _set_provider_inventories(rp_uuid, inventories):"},{"line_number":1258,"context_line":"            put_inventories_req \u003d self.placement_api.get("},{"line_number":1259,"context_line":"                \u0027/resource_providers/%s/inventories\u0027 % rp_uuid).body"},{"line_number":1260,"context_line":"            for key, value in inventories.items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_2562f5d9","line":1257,"updated":"2018-04-06 12:52:49.000000000","message":"It would be cleaner usage to just use this:\n\nhttps://developer.openstack.org/api-ref/placement/#update-resource-provider-inventory\n\nSince all you\u0027re doing is updating a specific resource class. So this method could become:\n\ndef _set_provider_inventories(rp_uuid, resource_class, inventory):","commit_id":"83915318f25b1e304432dcddb1807a519185de28"}]}