)]}'
{"id":"openstack%2Fnova~54768","triplet_id":"openstack%2Fnova~stable%2Fgrizzly~Idc35fce580be4f74e23883d1b4bea6475c3f6e30","project":"openstack/nova","branch":"stable/grizzly","topic":"bug/1177830","hashtags":[],"change_id":"Idc35fce580be4f74e23883d1b4bea6475c3f6e30","subject":"ensure we don\u0027t boot oversized images","status":"MERGED","created":"2013-10-31 16:06:38.000000000","updated":"2013-10-31 18:07:59.000000000","submitted":"2013-10-31 18:07:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b48bae9eb766f590602969286553b715a8af854e","_number":54768,"virtual_id_number":54768,"owner":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},{"value":0,"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},{"value":2,"date":"2013-10-31 18:07:56.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"all":[{"value":0,"date":"2013-10-31 16:34:21.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":2,"date":"2013-10-31 16:48:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"date":"2013-10-31 16:25:18.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},{"value":0,"date":"2013-10-31 16:19:26.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"all":[{"value":0,"date":"2013-10-31 16:06:38.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":1,"date":"2013-10-31 16:48:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},{"value":0,"date":"2013-10-31 16:19:26.000000000","_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},{"value":0,"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-31 16:06:38.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2013-10-31 16:19:26.000000000","updated_by":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"reviewer":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"state":"REVIEWER"},{"updated":"2013-10-31 16:25:18.000000000","updated_by":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"reviewer":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"state":"REVIEWER"},{"updated":"2013-10-31 18:07:56.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"75176c0d5f47325429934ab8b47821e901ce9739","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-10-31 16:12:06.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1a8db9d4a7674642ecb833ccbcb8e9b867b6e53d","author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"date":"2013-10-31 16:19:26.000000000","message":"Patch Set 1:\n\nI must be missing something, but isn\u0027t bug 1177830 - fixed with https://review.openstack.org/#/c/28901/ ?","accounts_in_message":[],"_revision_number":1},{"id":"43536d3f7b00253daadaa1125325cc1c37b4da5a","author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"date":"2013-10-31 16:25:18.000000000","message":"Patch Set 1:\n\nJust wondering to know why there isn\u0027t a cherry pick id exist?","accounts_in_message":[],"_revision_number":1},{"id":"ea2a2c98de58d10b0dab11947c14bb331125e6c8","author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"date":"2013-10-31 16:34:21.000000000","message":"Patch Set 1:\n\nChange I833467284126557eb598b8350a84e10c06292fa9 only partially fixed bug 1177830 as discussed at:\nhttps://bugs.launchpad.net/nova/+bug/1206081/comments/33\n\nFair point re the cherry-pick ID.\nI also notice that the change Ids are no longer the same on each branch which makes it awkward to track through gerrit","accounts_in_message":[],"_revision_number":1},{"id":"6362ceed0c54ff764adb81a2c27ca30930c6985f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 16:46:35.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/68/54768/1/check/gate-nova-pep8/9146e53 : SUCCESS in 4m 19s\n- gate-nova-docs http://docs-draft.openstack.org/68/54768/1/check/gate-nova-docs/8c78b27/doc/build/html/ : SUCCESS in 10m 09s\n- gate-nova-python26 http://logs.openstack.org/68/54768/1/check/gate-nova-python26/67d7300 : SUCCESS in 11m 43s\n- gate-nova-python27 http://logs.openstack.org/68/54768/1/check/gate-nova-python27/cc08d48 : SUCCESS in 9m 21s\n- check-tempest-devstack-vm-full http://logs.openstack.org/68/54768/1/check/check-tempest-devstack-vm-full/e5b3d18 : SUCCESS in 33m 26s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/68/54768/1/check/check-tempest-devstack-vm-postgres-full/7b7e9ae : SUCCESS in 39m 36s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/68/54768/1/check/check-tempest-devstack-vm-neutron/358ea7d : SUCCESS in 16m 48s\n- gate-devstack-vm-cells http://logs.openstack.org/68/54768/1/check/gate-devstack-vm-cells/8b75128 : SUCCESS in 12m 37s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/68/54768/1/check/gate-nova-pylint/f3c8365 : SUCCESS in 8m 22s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"54e0b4091d59566df58d93ed69a06108575ad637","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2013-10-31 16:48:32.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nsecurity fix","accounts_in_message":[],"_revision_number":1},{"id":"c5a42944327a821eaba847cb7fe0dbfe685b12bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 16:48:42.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"23cf3104cac1c1d354784f86beb4d76540083056","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 18:07:56.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-nova-docs http://docs-draft.openstack.org/68/54768/1/gate/gate-nova-docs/3dfcefe/doc/build/html/ : SUCCESS in 20m 32s\n- gate-nova-pep8 http://logs.openstack.org/68/54768/1/gate/gate-nova-pep8/2c60d39 : SUCCESS in 4m 27s\n- gate-nova-python26 http://logs.openstack.org/68/54768/1/gate/gate-nova-python26/67de38a : SUCCESS in 11m 56s\n- gate-nova-python27 http://logs.openstack.org/68/54768/1/gate/gate-nova-python27/f24c276 : SUCCESS in 7m 44s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/68/54768/1/gate/gate-tempest-devstack-vm-full/2b6a31f : SUCCESS in 32m 50s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/68/54768/1/gate/gate-tempest-devstack-vm-postgres-full/678f38d : SUCCESS in 37m 26s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/68/54768/1/gate/gate-tempest-devstack-vm-neutron/64d590c : SUCCESS in 16m 48s\n","accounts_in_message":[],"_revision_number":1},{"id":"a610c0149347963c987773b34cf146d769bbaed7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-31 18:07:59.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"135faa7b5d9855312bedc19e5e1ecebae34d3d18","revisions":{"135faa7b5d9855312bedc19e5e1ecebae34d3d18":{"kind":"REWORK","_number":1,"created":"2013-10-31 16:06:38.000000000","uploader":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"ref":"refs/changes/68/54768/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/68/54768/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/54768/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/54768/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/68/54768/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/68/54768/1"}}},"commit":{"parents":[{"commit":"0e5d353410c80798ff4b88a97db742ff0863fd2f","subject":"Merge \"xenapi: apply firewall rules in finish_migrate\" into stable/grizzly","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0e5d353410c80798ff4b88a97db742ff0863fd2f"}]}],"author":{"name":"Pádraig Brady","email":"pbrady@redhat.com","date":"2013-09-27 03:07:14.000000000","tz":60},"committer":{"name":"Thierry Carrez","email":"thierry@openstack.org","date":"2013-10-31 16:05:59.000000000","tz":60},"subject":"ensure we don\u0027t boot oversized images","message":"ensure we don\u0027t boot oversized images\n\nSince we can\u0027t generally shrink incoming images, add extra checks\nto ensure oversized images are not allowed through.\nAll cases when populating the libvirt image cache are now handled,\nincluding the initial download from glance, where we avoid\nconverting to raw, as that could generate non sparse images\nmuch larger than the downloaded image.\n\n* nova/virt/libvirt/utils.py (fetch_image): Allow passing through\nof the max_size parameter.\n* nova/virt/images.py (fetch_to_raw): Accept the max_size parameter,\nand use it to discard images with larger (virtual) sizes.\n* nova/virt/libvirt/imagebackend.py (verify_base_size): A new\nrefactored function to identify and raise exception to oversized images.\n(Raw.create_image): Pass the max_size to the fetch function.\nAlso enforce virtual image size checking for already fetched images,\nas this class (despite the name) can be handling qcow files.\n(Qcow2.create_image): Pass the max_size to the fetch function,\nor verify the virtual size for the instance as done previously.\n(Lvm.create_image): Pass the max_size to the fetch function.\nAlso check the size before transferring to the volume to improve\nefficiency by not even attempting the transfer of oversized images.\n(Rbd.create_image): Likewise.\n* nova/tests/fake_libvirt_utils.py: Support max_size arg.\n* nova/tests/test_libvirt.py (test_fetch_raw_image):\nAdd a case to check oversized images are discarded.\n* nova/tests/test_imagebackend.py (test_create_image_too_small):\nAdjust to avoid the fetch size check.\n\nFixes bug: 1177830\nFixes bug: 1206081\n\nConflicts:\n\n\tnova/tests/test_imagebackend.py\n\tnova/virt/libvirt/imagebackend.py\n\nChange-Id: Idc35fce580be4f74e23883d1b4bea6475c3f6e30\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/135faa7b5d9855312bedc19e5e1ecebae34d3d18"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/135faa7b5d9855312bedc19e5e1ecebae34d3d18"}]},"parents_data":[{"branch_name":"refs/heads/stable/grizzly","commit_id":"0e5d353410c80798ff4b88a97db742ff0863fd2f","is_merged_in_target_branch":false}],"branch":"refs/heads/stable/grizzly"}},"requirements":[],"submit_records":[],"submit_requirements":[]}