)]}'
{"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"b95f492e6b3f28e33d0447043339a2cc4f730f82","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.stubs.Set(self.conn, \"_poll_task\","},{"line_number":172,"context_line":"                       fake_poll_task)"},{"line_number":173,"context_line":"        self.assertRaises(exception.NovaException,"},{"line_number":174,"context_line":"                          self.conn._wait_for_task, \u0027fake-id\u0027, \u0027fake-ref\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _create_instance_in_the_db(self, node\u003dNone, set_image_ref\u003dTrue,"},{"line_number":177,"context_line":"                                   uuid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9tiI%3D","line":174,"updated":"2013-12-06 20:50:01.000000000","message":"It appears that this does test that an exception is raised, but it does ont test that loop.stop() gets called.  That was the key to this bug fix, right?","commit_id":"51526eb0ca356caf887b5d302117c719f8789cfd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13f0b006b2b3f60157f18810c94d298369928d30","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.stubs.Set(self.conn, \"_poll_task\","},{"line_number":172,"context_line":"                       fake_poll_task)"},{"line_number":173,"context_line":"        self.assertRaises(exception.NovaException,"},{"line_number":174,"context_line":"                          self.conn._wait_for_task, \u0027fake-id\u0027, \u0027fake-ref\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def _create_instance_in_the_db(self, node\u003dNone, set_image_ref\u003dTrue,"},{"line_number":177,"context_line":"                                   uuid\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9rRI%3D","line":174,"in_reply_to":"AAAATn%2F9tiI%3D","updated":"2013-12-08 14:13:51.000000000","message":"Done","commit_id":"51526eb0ca356caf887b5d302117c719f8789cfd"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"55b9ead84393179a46b6545970caffb7fe23d360","unresolved":false,"context_lines":[{"line_number":901,"context_line":"        try:"},{"line_number":902,"context_line":"            ret_val \u003d done.wait()"},{"line_number":903,"context_line":"        except Exception:"},{"line_number":904,"context_line":"            loop.stop()"},{"line_number":905,"context_line":"            raise"},{"line_number":906,"context_line":"        loop.stop()"},{"line_number":907,"context_line":"        return ret_val"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FkpA%3D","line":904,"updated":"2013-11-01 04:35:08.000000000","message":"nit: could use finally: loop.stop() since that needs to be executed in both cases.","commit_id":"e93ed2ab6ad4aa5cf714ab084ae0e9aa41d33921"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c2683ecb7ba0f685c4ef59f4d9c2d723b4a08c3","unresolved":false,"context_lines":[{"line_number":901,"context_line":"        try:"},{"line_number":902,"context_line":"            ret_val \u003d done.wait()"},{"line_number":903,"context_line":"        except Exception:"},{"line_number":904,"context_line":"            loop.stop()"},{"line_number":905,"context_line":"            raise"},{"line_number":906,"context_line":"        loop.stop()"},{"line_number":907,"context_line":"        return ret_val"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FhVE%3D","line":904,"in_reply_to":"AAAATn%2F%2FkpA%3D","updated":"2013-11-02 17:54:44.000000000","message":"Done","commit_id":"e93ed2ab6ad4aa5cf714ab084ae0e9aa41d33921"},{"author":{"_account_id":8334,"name":"Noorul Islam K M","email":"noorul@noorul.com","username":"noorul"},"change_message_id":"571a6ab0615114debf755d1dc06d0e8c724e9e3b","unresolved":false,"context_lines":[{"line_number":904,"context_line":"            raise"},{"line_number":905,"context_line":"        finally:"},{"line_number":906,"context_line":"            loop.stop()"},{"line_number":907,"context_line":"        loop.stop()"},{"line_number":908,"context_line":"        return ret_val"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"    def _poll_task(self, instance_uuid, task_ref, done):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FFHE%3D","line":907,"updated":"2013-11-14 17:13:28.000000000","message":"Is this required as this is already mentioned in finally?","commit_id":"4943e71da770f6f11d19732093a6cc6c42827c1e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b9f3199941d7930595a1b18d08a972859ca14066","unresolved":false,"context_lines":[{"line_number":904,"context_line":"            raise"},{"line_number":905,"context_line":"        finally:"},{"line_number":906,"context_line":"            loop.stop()"},{"line_number":907,"context_line":"        loop.stop()"},{"line_number":908,"context_line":"        return ret_val"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"    def _poll_task(self, instance_uuid, task_ref, done):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FE9c%3D","line":907,"in_reply_to":"AAAATn%2F%2FFHE%3D","updated":"2013-11-14 18:02:26.000000000","message":"Thanks!","commit_id":"4943e71da770f6f11d19732093a6cc6c42827c1e"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"980f7a3d46ba784cd8f743d4d38244ed99148c22","unresolved":false,"context_lines":[{"line_number":889,"context_line":"            self._create_session()"},{"line_number":890,"context_line":"        return self.vim"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    def _stop_loop(self, loop):"},{"line_number":893,"context_line":"        loop.stop()"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    def _wait_for_task(self, instance_uuid, task_ref):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9VUY%3D","line":892,"updated":"2013-12-12 15:17:28.000000000","message":"This method doesn\u0027t make a lot of sense, I guess there is no way to unit test without it?","commit_id":"5d1d0210d0908d08f154a7b249efa71a7715d63a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fa59674a63a006508368b74df56ffe4c00d0bd77","unresolved":false,"context_lines":[{"line_number":889,"context_line":"            self._create_session()"},{"line_number":890,"context_line":"        return self.vim"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"    def _stop_loop(self, loop):"},{"line_number":893,"context_line":"        loop.stop()"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    def _wait_for_task(self, instance_uuid, task_ref):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9KHg%3D","line":892,"in_reply_to":"AAAATn%2F9VUY%3D","updated":"2013-12-16 07:19:22.000000000","message":"yes, this was just added for the unit tests.","commit_id":"5d1d0210d0908d08f154a7b249efa71a7715d63a"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"c1fb017fe7631aef6ffa3feda1716904ac43f31f","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        return self.vim"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"    def _stop_loop(self, loop):"},{"line_number":882,"context_line":"        loop.stop()"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def _wait_for_task(self, instance_uuid, task_ref):"},{"line_number":885,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2F6oE%3D","line":882,"updated":"2014-02-09 23:12:28.000000000","message":"I think I would have just called loop.stop() directly instead of adding this method, and just stubbed differently in the tests, but I\u0027m not bothered enough to -1, I guess","commit_id":"1c1570ff7ac8470d7dba28c893300835b22e0966"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"406a7e36ce7b1344dfb0343eaaef486be93f0b52","unresolved":false,"context_lines":[{"line_number":879,"context_line":"        return self.vim"},{"line_number":880,"context_line":""},{"line_number":881,"context_line":"    def _stop_loop(self, loop):"},{"line_number":882,"context_line":"        loop.stop()"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def _wait_for_task(self, instance_uuid, task_ref):"},{"line_number":885,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2F30Q%3D","line":882,"in_reply_to":"AAAAUX%2F%2F6oE%3D","updated":"2014-02-10 09:00:33.000000000","message":"The method was added so that we can provide a unit test. In your previous comment you stated that a unit test was missing. Hence the addition","commit_id":"1c1570ff7ac8470d7dba28c893300835b22e0966"}]}