)]}'
{"nova/scheduler/client/report.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"04a722d0553f67a3bf8f3540a340bc3e98b29c63","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        # NOTE(efried): To resolve bug #1746075, use the latest microversion."},{"line_number":565,"context_line":"        # If it\u0027s late enough to return the new provider\u0027s payload, return that"},{"line_number":566,"context_line":"        # payload.  Otherwise, retrieve the newly-created provider via GET."},{"line_number":567,"context_line":"        resp \u003d self.post(url, payload, version\u003d\u0027latest\u0027,"},{"line_number":568,"context_line":"                         global_request_id\u003dcontext.global_id)"},{"line_number":569,"context_line":"        placement_req_id \u003d get_placement_request_id(resp)"},{"line_number":570,"context_line":"        if resp:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_5106d688","line":567,"updated":"2018-03-01 15:59:01.000000000","message":"\u0027latest\u0027 should never be used in \"real\" code (because it could mean anything). Instead use the microversion at which the desired feature is available.","commit_id":"b15c143acb236fbb7ea25b72478cc239596a75f6"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"04a722d0553f67a3bf8f3540a340bc3e98b29c63","unresolved":false,"context_lines":[{"line_number":577,"context_line":"                \u0027placement_req_id\u0027: placement_req_id,"},{"line_number":578,"context_line":"            }"},{"line_number":579,"context_line":"            LOG.info(msg, args)"},{"line_number":580,"context_line":"            if resp.status_code \u003d\u003d 200:"},{"line_number":581,"context_line":"                return resp.json()"},{"line_number":582,"context_line":"            else:"},{"line_number":583,"context_line":"                # TODO(efried): Remove this branch when minimum placement"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_91769e06","line":580,"updated":"2018-03-01 15:59:01.000000000","message":"This is clever, but I think the risks presented by not knowing what \u0027latest\u0027 means don\u0027t warrant it. Ask for 1.20 (or whatever) and check for the 406. If you get the 406, retry the POST at the older version and do the GET.\n\nI know you\u0027ll hate that because of the imposed multiple requests, but in nearly all situations you won\u0027t get the 406 because the usual instructions are: placement should be upgraded before nova.\n\nIf you do have to do the 406 failure, take some small comfort in the fact that the 406 will be generated pretty early in placement\u0027s response stack.","commit_id":"b15c143acb236fbb7ea25b72478cc239596a75f6"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"b58bd8643930d26c6e971d88ab27ce9b8f4b0536","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        if resp.status_code \u003d\u003d 406:"},{"line_number":590,"context_line":"            # Bug #1746075 cont\u0027d: Otherwise, use the \"silent\" version and"},{"line_number":591,"context_line":"            # retrieve the newly-created provider via GET."},{"line_number":592,"context_line":"            resp \u003d self.post(url, payload, global_request_id\u003dcontext.global_id)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        placement_req_id \u003d get_placement_request_id(resp)"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_8bc33957","line":592,"updated":"2018-03-15 02:50:58.000000000","message":"We should fallback to this version POST_RPS_RETURNS_PAYLOAD_API_VERSION?","commit_id":"a91141a3653ab47d63640e39e448843f487f879a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"357fb696cbaad73f9c74f2b784d846587784ec93","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        if resp.status_code \u003d\u003d 406:"},{"line_number":590,"context_line":"            # Bug #1746075 cont\u0027d: Otherwise, use the \"silent\" version and"},{"line_number":591,"context_line":"            # retrieve the newly-created provider via GET."},{"line_number":592,"context_line":"            resp \u003d self.post(url, payload, global_request_id\u003dcontext.global_id)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        placement_req_id \u003d get_placement_request_id(resp)"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_94b02cdf","line":592,"in_reply_to":"df7087c5_4b90c14a","updated":"2018-03-15 13:51:04.000000000","message":"We actually don\u0027t need to - the only thing that gives us is the ability to set the parent provider, which we don\u0027t need here since we\u0027re creating a root - but for consistency with the original, it\u0027s probably a good idea.","commit_id":"a91141a3653ab47d63640e39e448843f487f879a"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"020c3150e70a2665a3749e7a626e5a5de4e7f860","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        if resp.status_code \u003d\u003d 406:"},{"line_number":590,"context_line":"            # Bug #1746075 cont\u0027d: Otherwise, use the \"silent\" version and"},{"line_number":591,"context_line":"            # retrieve the newly-created provider via GET."},{"line_number":592,"context_line":"            resp \u003d self.post(url, payload, global_request_id\u003dcontext.global_id)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        placement_req_id \u003d get_placement_request_id(resp)"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_4b90c14a","line":592,"in_reply_to":"df7087c5_8bc33957","updated":"2018-03-15 02:51:25.000000000","message":"sorry, I mean this version NESTED_PROVIDER_API_VERSION","commit_id":"a91141a3653ab47d63640e39e448843f487f879a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"173065f9cb21611d2cfe3f842f1e70fde7ad081b","unresolved":false,"context_lines":[{"line_number":589,"context_line":"        if resp.status_code \u003d\u003d 406:"},{"line_number":590,"context_line":"            # Bug #1746075 cont\u0027d: Otherwise, use the \"silent\" version and"},{"line_number":591,"context_line":"            # retrieve the newly-created provider via GET."},{"line_number":592,"context_line":"            resp \u003d self.post(url, payload, global_request_id\u003dcontext.global_id)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        placement_req_id \u003d get_placement_request_id(resp)"},{"line_number":595,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_88156c42","line":592,"in_reply_to":"df7087c5_94b02cdf","updated":"2018-03-15 13:58:39.000000000","message":"I\u0027m wrong - we *can* be assigning a parent here - so this needs to be fixed.  Thanks Alex.","commit_id":"a91141a3653ab47d63640e39e448843f487f879a"}],"nova/tests/unit/scheduler/client/test_report.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"04a722d0553f67a3bf8f3540a340bc3e98b29c63","unresolved":false,"context_lines":[{"line_number":1819,"context_line":"        expected_url \u003d \u0027/resource_providers\u0027"},{"line_number":1820,"context_line":"        self.ks_adap_mock.post.assert_called_once_with("},{"line_number":1821,"context_line":"            expected_url, json\u003dexpected_payload, raise_exc\u003dFalse,"},{"line_number":1822,"context_line":"            microversion\u003d\u0027latest\u0027,"},{"line_number":1823,"context_line":"            headers\u003d{\u0027X-Openstack-Request-Id\u0027: self.context.global_id})"},{"line_number":1824,"context_line":"        mock_get.assert_called_once_with(self.context, uuid)"},{"line_number":1825,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f9dbf25_f1528267","line":1822,"updated":"2018-03-01 15:59:01.000000000","message":"same warnings about lack of explicitness here","commit_id":"b15c143acb236fbb7ea25b72478cc239596a75f6"}]}