)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e7a5df0f80d64014a59f6ac67dc74b54f236875f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix indentation in doc/source/cli/*"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current indentation was wrongly interpreted as quotes."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I731d8833e69e6bed12f5637d6bb3248b890c18ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f9dbf25_0dbb3d0e","line":9,"updated":"2018-03-02 18:01:01.000000000","message":"Can you write the reason or reference to explain why the original was wrong in this commit message ?\nAccording to https://docs.openstack.org/nova/latest/cli/nova-api.html the original Synopsis doesn\u0027t seem very wrong for me.","commit_id":"09faad1ea0da2a0c7f23238c4a4aa7a4599ad970"},{"author":{"_account_id":23913,"name":"David Rabel","email":"rabel@b1-systems.de","username":"rabel"},"change_message_id":"9e2da70c2af7da281c96604e7feeac5d9c603ca7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix indentation in doc/source/cli/*"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current indentation was wrongly interpreted as quotes."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I731d8833e69e6bed12f5637d6bb3248b890c18ab"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f9dbf25_e8027fb4","line":9,"in_reply_to":"1f9dbf25_0dbb3d0e","updated":"2018-03-02 19:53:06.000000000","message":"The current indentation is a quotation, which is wrong formatted. I\u0027m not sure how to explain it further.\n\nWhen you open the web page you linked, you see that the font of the synopsis is very big and there is a gray bar at the left.","commit_id":"09faad1ea0da2a0c7f23238c4a4aa7a4599ad970"}],"doc/source/cli/nova-api-metadata.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8b0e2bc724df2f583412052fed02660c9bd429c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Synopsis"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"nova-api-metadata  [options]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_2d5080d4","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":28},"updated":"2018-03-09 14:49:54.000000000","message":"Perhaps we should use \u0027code-block\u0027 here? It is supposed to be formatted as literal, I would imagine.","commit_id":"4347513468eae8f7120e83a50625eeb3448891e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7973dc15494f41070c9f54862c198732ee8101b3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Synopsis"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"nova-api-metadata  [options]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_8d998c6f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":28},"in_reply_to":"df7087c5_2d5080d4","updated":"2018-03-09 15:00:49.000000000","message":"How about that OCD itch gets scratched in a follow up change.","commit_id":"4347513468eae8f7120e83a50625eeb3448891e0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b60a8cf136800f300d0ad37d5c7e955616fa1c1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Synopsis"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"nova-api-metadata  [options]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_ad5fb070","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":28},"in_reply_to":"df7087c5_8d998c6f","updated":"2018-03-09 15:06:16.000000000","message":"Or we fix it here, while we\u0027re making the change? :) This is going to go from some form of call out (an indented block) to just normal text. That seems wrong to me. I\u0027d rather keep it as-is if that\u0027s the case","commit_id":"4347513468eae8f7120e83a50625eeb3448891e0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e3b5458281de0a3cb03f7e68179a2d6923b986fb","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Synopsis"},{"line_number":17,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"nova-api-metadata  [options]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_4d0e143c","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":28},"in_reply_to":"df7087c5_ad5fb070","updated":"2018-03-09 15:16:11.000000000","message":"And normal text isn\u0027t the end of the world. Again, if you want to cleanup after this, that\u0027s fine, but let\u0027s not conflate the purpose of this patch (fixing indents) with reformatting everything.","commit_id":"4347513468eae8f7120e83a50625eeb3448891e0"}],"doc/source/cli/nova-status.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8b0e2bc724df2f583412052fed02660c9bd429c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"~~~~~~~"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"``nova-status upgrade check``"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Performs a release-specific readiness check before restarting services with"},{"line_number":58,"context_line":"  new code. This command expects to have complete configuration and access"},{"line_number":59,"context_line":"  to databases and services within a cell. For example, this check may query"},{"line_number":60,"context_line":"  the Nova API database and one or more cell databases. It may also make"},{"line_number":61,"context_line":"  requests to other services such as the Placement REST API via the Keystone"},{"line_number":62,"context_line":"  service catalog."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  **Return Codes**"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_8d418c0e","side":"PARENT","line":62,"range":{"start_line":56,"start_character":0,"end_line":62,"end_character":18},"updated":"2018-03-09 14:49:54.000000000","message":"If I were to guess, I think what\u0027s intended here is a definition list. Definition lists shouldn\u0027t have a newline between the term and definition, so all you need to do is delete line 56 and this should render correctly","commit_id":"b1173396edc1f364ae00d774a0dbb25de12408c8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e3b5458281de0a3cb03f7e68179a2d6923b986fb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"~~~~~~~"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"``nova-status upgrade check``"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Performs a release-specific readiness check before restarting services with"},{"line_number":58,"context_line":"  new code. This command expects to have complete configuration and access"},{"line_number":59,"context_line":"  to databases and services within a cell. For example, this check may query"},{"line_number":60,"context_line":"  the Nova API database and one or more cell databases. It may also make"},{"line_number":61,"context_line":"  requests to other services such as the Placement REST API via the Keystone"},{"line_number":62,"context_line":"  service catalog."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  **Return Codes**"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_e0028f09","side":"PARENT","line":62,"range":{"start_line":56,"start_character":0,"end_line":62,"end_character":18},"in_reply_to":"df7087c5_0d501c5d","updated":"2018-03-09 15:16:11.000000000","message":"We don\u0027t *have* to have headers for the commands. We can, and that\u0027s also fine, if you want to propose it in a follow up, but again, let\u0027s not conflate all of that with what he\u0027s changing in this patch (indents).","commit_id":"b1173396edc1f364ae00d774a0dbb25de12408c8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7973dc15494f41070c9f54862c198732ee8101b3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"~~~~~~~"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"``nova-status upgrade check``"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Performs a release-specific readiness check before restarting services with"},{"line_number":58,"context_line":"  new code. This command expects to have complete configuration and access"},{"line_number":59,"context_line":"  to databases and services within a cell. For example, this check may query"},{"line_number":60,"context_line":"  the Nova API database and one or more cell databases. It may also make"},{"line_number":61,"context_line":"  requests to other services such as the Placement REST API via the Keystone"},{"line_number":62,"context_line":"  service catalog."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  **Return Codes**"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_ed092895","side":"PARENT","line":62,"range":{"start_line":56,"start_character":0,"end_line":62,"end_character":18},"in_reply_to":"df7087c5_8d418c0e","updated":"2018-03-09 15:00:49.000000000","message":"I wrote this, I think what David has done is fine. The intent was that we have an \u0027upgrade\u0027 category or nova-status commands, and this part is describing the \u0027check\u0027 subcommand in that category. If we ended up having more subcommands in the upgrade category, then we\u0027ll have to likely create sub-headings in the doc per each command, but for now I think this is fine.","commit_id":"b1173396edc1f364ae00d774a0dbb25de12408c8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8b60a8cf136800f300d0ad37d5c7e955616fa1c1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"~~~~~~~"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"``nova-status upgrade check``"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Performs a release-specific readiness check before restarting services with"},{"line_number":58,"context_line":"  new code. This command expects to have complete configuration and access"},{"line_number":59,"context_line":"  to databases and services within a cell. For example, this check may query"},{"line_number":60,"context_line":"  the Nova API database and one or more cell databases. It may also make"},{"line_number":61,"context_line":"  requests to other services such as the Placement REST API via the Keystone"},{"line_number":62,"context_line":"  service catalog."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  **Return Codes**"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"df7087c5_0d501c5d","side":"PARENT","line":62,"range":{"start_line":56,"start_character":0,"end_line":62,"end_character":18},"in_reply_to":"df7087c5_ed092895","updated":"2018-03-09 15:06:16.000000000","message":"Per IRC:\n\n\u003cfinucannot\u003e mriedem: This doesn\u0027t make sense though. You need some form of hierarchy to illustrate these are different sections https://review.openstack.org/#/c/549166/2/doc/source/cli/nova-status.rst\n\u003cfinucannot\u003e At the very leas, the command names should be made into headers\n\u003cfinucannot\u003e *least\n\u003cfinucannot\u003e ditto for here https://review.openstack.org/#/c/549166/2/doc/source/cli/nova-manage.rst","commit_id":"b1173396edc1f364ae00d774a0dbb25de12408c8"}]}