)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"26a5ee89bddeb355babab82cb14a59fc76ade98e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"changed since. Upgrades are only supported for version N to N+1. The bug"},{"line_number":11,"context_line":"has become more apparent with the removal of compute RPC 4.x"},{"line_number":12,"context_line":"compatibility (a761e57368280b6d3e931831ecd393fd5787b3ef) and can be seen"},{"line_number":13,"context_line":"when upgrade_levels/compute\u003dauto is set on a new deployment."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change updates the default to queens to prevent the use of RPC 4.x"},{"line_number":16,"context_line":"in requests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff6b8bd7_d4d65b50","line":13,"updated":"2018-03-06 15:09:01.000000000","message":"This isn\u0027t really the proper justification.\n\nSince we\u0027re well past the introduction of service version, zero no longer means what it used to mean.\n\nWhat this should say is:\n\n When a zero service version is returned, it means that we have no\n services running for the requested binary. In that case, we should\n assume the latest version available until told otherwise. This usually\n happens in first-start cases, where everything is likely to be up to\n date anyway.","commit_id":"46718e70704ca97aed8c79055cf1615b7d78ff25"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"dac67c9b108cf57908da9ea27a1e9d8fbe4e494c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"changed since. Upgrades are only supported for version N to N+1. The bug"},{"line_number":11,"context_line":"has become more apparent with the removal of compute RPC 4.x"},{"line_number":12,"context_line":"compatibility (a761e57368280b6d3e931831ecd393fd5787b3ef) and can be seen"},{"line_number":13,"context_line":"when upgrade_levels/compute\u003dauto is set on a new deployment."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This change updates the default to queens to prevent the use of RPC 4.x"},{"line_number":16,"context_line":"in requests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff6b8bd7_1fcceb33","line":13,"in_reply_to":"ff6b8bd7_d4d65b50","updated":"2018-03-06 17:37:58.000000000","message":"Done","commit_id":"46718e70704ca97aed8c79055cf1615b7d78ff25"}],"nova/compute/rpcapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"26a5ee89bddeb355babab82cb14a59fc76ade98e","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        # NOTE(johngarbutt) when there are no nova-compute services running we"},{"line_number":385,"context_line":"        # get service_version \u003d\u003d 0. In that case we do not want to cache"},{"line_number":386,"context_line":"        # this result, because we will get a better answer next time."},{"line_number":387,"context_line":"        # As a sane default, return the version from the last release."},{"line_number":388,"context_line":"        if service_version \u003d\u003d 0:"},{"line_number":389,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":390,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_14bcd303","line":387,"updated":"2018-03-06 15:09:01.000000000","message":"I think it\u0027s probably time to change this to say \"return the current version\".","commit_id":"46718e70704ca97aed8c79055cf1615b7d78ff25"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"dac67c9b108cf57908da9ea27a1e9d8fbe4e494c","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        # NOTE(johngarbutt) when there are no nova-compute services running we"},{"line_number":385,"context_line":"        # get service_version \u003d\u003d 0. In that case we do not want to cache"},{"line_number":386,"context_line":"        # this result, because we will get a better answer next time."},{"line_number":387,"context_line":"        # As a sane default, return the version from the last release."},{"line_number":388,"context_line":"        if service_version \u003d\u003d 0:"},{"line_number":389,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":390,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_bfd05fcb","line":387,"in_reply_to":"ff6b8bd7_14bcd303","updated":"2018-03-06 17:37:58.000000000","message":"Done","commit_id":"46718e70704ca97aed8c79055cf1615b7d78ff25"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"26a5ee89bddeb355babab82cb14a59fc76ade98e","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":390,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":391,"context_line":"                      \"service has been started. Defaulting to Queens RPC.\")"},{"line_number":392,"context_line":"            return self.VERSION_ALIASES[\"queens\"]"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":395,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_d43bbb99","line":392,"updated":"2018-03-06 15:09:01.000000000","message":"This will be wrong and never changed until we do the next major bump, so just return the current version here and change the log message accordingly.","commit_id":"46718e70704ca97aed8c79055cf1615b7d78ff25"},{"author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"change_message_id":"dac67c9b108cf57908da9ea27a1e9d8fbe4e494c","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":390,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":391,"context_line":"                      \"service has been started. Defaulting to Queens RPC.\")"},{"line_number":392,"context_line":"            return self.VERSION_ALIASES[\"queens\"]"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":395,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_3fabef1d","line":392,"in_reply_to":"ff6b8bd7_944a237e","updated":"2018-03-06 17:37:58.000000000","message":"In patchset 2 I continue to return here instead of updating service_version so the caching doesn\u0027t happen.","commit_id":"46718e70704ca97aed8c79055cf1615b7d78ff25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c361f79d26a5300c10f3fec672dc5164bb9175ea","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":390,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":391,"context_line":"                      \"service has been started. Defaulting to Queens RPC.\")"},{"line_number":392,"context_line":"            return self.VERSION_ALIASES[\"queens\"]"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":395,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_944a237e","line":392,"in_reply_to":"ff6b8bd7_94ba23dc","updated":"2018-03-06 15:25:51.000000000","message":"\u003e Yeah, or set service_version to service.SERVICE_VERSION and let it\n \u003e continue down below.\n\nThat would be easier, good point.","commit_id":"46718e70704ca97aed8c79055cf1615b7d78ff25"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"83b9b08d1c2aaf5bb33c5bdce56bde00b14aa457","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":390,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":391,"context_line":"                      \"service has been started. Defaulting to Queens RPC.\")"},{"line_number":392,"context_line":"            return self.VERSION_ALIASES[\"queens\"]"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":395,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_f41a7f15","line":392,"in_reply_to":"ff6b8bd7_d43bbb99","updated":"2018-03-06 15:12:59.000000000","message":"\u003e so just return the current version here and change the log message accordingly.\n\nSo do you mean pull the latest entry of the tuple in service_obj.SERVICE_VERSION_HISTORY?","commit_id":"46718e70704ca97aed8c79055cf1615b7d78ff25"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6601ef24c0a9791dc6d0af7f8df7c2ddcf68d9a0","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            LOG.debug(\"Not caching compute RPC version_cap, because min \""},{"line_number":390,"context_line":"                      \"service_version is 0. Please ensure a nova-compute \""},{"line_number":391,"context_line":"                      \"service has been started. Defaulting to Queens RPC.\")"},{"line_number":392,"context_line":"            return self.VERSION_ALIASES[\"queens\"]"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        history \u003d service_obj.SERVICE_VERSION_HISTORY"},{"line_number":395,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_94ba23dc","line":392,"in_reply_to":"ff6b8bd7_f41a7f15","updated":"2018-03-06 15:15:01.000000000","message":"Yeah, or set service_version to service.SERVICE_VERSION and let it continue down below.","commit_id":"46718e70704ca97aed8c79055cf1615b7d78ff25"}],"nova/tests/unit/compute/test_rpcapi.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8ae2326183782f4e4987794136e6db37a9eb7cf2","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.flags(compute\u003d\u0027auto\u0027, group\u003d\u0027upgrade_levels\u0027)"},{"line_number":92,"context_line":"        compute_rpcapi.LAST_VERSION \u003d None"},{"line_number":93,"context_line":"        rpcapi \u003d compute_rpcapi.ComputeAPI()"},{"line_number":94,"context_line":"        self.assertEqual(\u00275.0\u0027, rpcapi.router.version_cap)"},{"line_number":95,"context_line":"        mock_get_min.assert_called_once_with(mock.ANY, \u0027nova-compute\u0027)"},{"line_number":96,"context_line":"        self.assertIsNone(compute_rpcapi.LAST_VERSION)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6b8bd7_8b73d980","line":94,"updated":"2018-03-06 19:44:47.000000000","message":"This is going to break every time we bump the version. Can you just do the math here as well to make sure we\u0027re picking the right thing?","commit_id":"c8c49d6baa2b63ac87586410f21d05c21828e57a"}]}