)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33747943ac22a488732c8d3615e8ffbd8bef845d","unresolved":false,"context_lines":[{"line_number":668,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":669,"context_line":"                deprecated_since\u003d\u002718.0.0\u0027,"},{"line_number":670,"context_line":"                deprecated_reason\u003d\"\"\""},{"line_number":671,"context_line":"Sparse LVs is a feature that is not tested, not supported, and we already"},{"line_number":672,"context_line":"preallocate volumes by default."},{"line_number":673,"context_line":"\"\"\","},{"line_number":674,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_01d029f7","line":671,"range":{"start_line":671,"start_character":7,"end_line":671,"end_character":10},"updated":"2018-03-05 14:19:41.000000000","message":"logical volumes (write it out for clarity).","commit_id":"9feb7ff187588a0da31ce449585c0724510761a6"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"64b6eb0ed5c33f81c37594adc8fb5efeb5897d31","unresolved":false,"context_lines":[{"line_number":668,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":669,"context_line":"                deprecated_since\u003d\u002718.0.0\u0027,"},{"line_number":670,"context_line":"                deprecated_reason\u003d\"\"\""},{"line_number":671,"context_line":"Sparsing logical volumes is a feature that is not tested, not supported, and"},{"line_number":672,"context_line":"we already preallocate volumes by default."},{"line_number":673,"context_line":"\"\"\","},{"line_number":674,"context_line":"                help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff6b8bd7_c41b1f71","line":671,"range":{"start_line":671,"start_character":0,"end_line":671,"end_character":8},"updated":"2018-03-05 14:45:52.000000000","message":"Sparse?","commit_id":"4c720360b866e22a0c0990b8b3bb066341460e72"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"64b6eb0ed5c33f81c37594adc8fb5efeb5897d31","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                deprecated_since\u003d\u002718.0.0\u0027,"},{"line_number":670,"context_line":"                deprecated_reason\u003d\"\"\""},{"line_number":671,"context_line":"Sparsing logical volumes is a feature that is not tested, not supported, and"},{"line_number":672,"context_line":"we already preallocate volumes by default."},{"line_number":673,"context_line":"\"\"\","},{"line_number":674,"context_line":"                help\u003d\"\"\""},{"line_number":675,"context_line":"Create sparse logical volumes (with virtualsize) if this flag is set to True."}],"source_content_type":"text/x-python","patch_set":3,"id":"ff6b8bd7_04403735","line":672,"range":{"start_line":672,"start_character":11,"end_line":672,"end_character":41},"updated":"2018-03-05 14:45:52.000000000","message":"This is based on the \"preallocate_images\" option, right? Can we put that into a \"Related options:\" section in the help text then? It wasn\u0027t clear to me that these were linked w/o looking at the code.\n\nAlso, preallocate_images defaults to \u0027none\u0027 so I\u0027m not sure about the wording here that we already preallocate volumes by default - is that LVM-specific or something? I guess it is given this logic:\n\n  self.preallocate \u003d not self.sparse\n\nHowever, we only preallocate if we can run the \u0027fallocate\u0027 command, but I don\u0027t see a rootwrap compute filter entry for that - do we know it works? I wonder if we should mention that you need to have fallocate installed on compute nodes for that to work (likely better to point that out in the help text for the preallocate_images config option).","commit_id":"4c720360b866e22a0c0990b8b3bb066341460e72"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bd11e0f72b854b19330a4d0a70691a46f0175031","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                deprecated_since\u003d\u002718.0.0\u0027,"},{"line_number":670,"context_line":"                deprecated_reason\u003d\"\"\""},{"line_number":671,"context_line":"Sparsing logical volumes is a feature that is not tested, not supported, and"},{"line_number":672,"context_line":"we already preallocate volumes by default."},{"line_number":673,"context_line":"\"\"\","},{"line_number":674,"context_line":"                help\u003d\"\"\""},{"line_number":675,"context_line":"Create sparse logical volumes (with virtualsize) if this flag is set to True."}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_c930060b","line":672,"range":{"start_line":672,"start_character":11,"end_line":672,"end_character":41},"in_reply_to":"ff6b8bd7_04403735","updated":"2018-03-07 21:26:17.000000000","message":"The LVM backend is specific AFAICS. It already creates the space in advance (here, the LV) hence why it\u0027s said \"preallocated\".\n\nSpecifically see the comment from mdbooth here https://github.com/openstack/nova/blob/c1eb6f0/nova/virt/libvirt/imagebackend.py#L231-L233","commit_id":"4c720360b866e22a0c0990b8b3bb066341460e72"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"33747943ac22a488732c8d3615e8ffbd8bef845d","unresolved":false,"context_lines":[{"line_number":685,"context_line":""},{"line_number":686,"context_line":"        super(Lvm, self).__init__(path, \"block\", \"raw\", is_block_dev\u003dTrue)"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"        # TODO(sbauza): Remove that and default to preallocate once we"},{"line_number":689,"context_line":"        # remove the option which is deprecated now."},{"line_number":690,"context_line":"        self.sparse \u003d CONF.libvirt.sparse_logical_volumes"},{"line_number":691,"context_line":"        self.preallocate \u003d not self.sparse"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff6b8bd7_21f68d91","line":688,"range":{"start_line":688,"start_character":31,"end_line":688,"end_character":35},"updated":"2018-03-05 14:19:41.000000000","message":"What is \"that\"? If you mean the sparse variable, then say that explicitly.","commit_id":"9feb7ff187588a0da31ce449585c0724510761a6"}],"releasenotes/notes/deprecate_sparse_lvs-99f30d70a68a028d.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f083eaef1646af12fa937c3ae8fecce1d772ef8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[libvirt]/sparse_logical_volumes`` configuration option is now"},{"line_number":5,"context_line":"    deprecated. Sparse LVs were never verificated by tests in Nova and some"},{"line_number":6,"context_line":"    bugs were found without having fixes so we prefer to deprecate that feature"},{"line_number":7,"context_line":"    ."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff6b8bd7_013ee928","line":5,"range":{"start_line":5,"start_character":23,"end_line":5,"end_character":26},"updated":"2018-03-05 14:20:51.000000000","message":"just say \"logical volumes\"","commit_id":"072fc170cb3f4728aa2c31901e971fb2f5deb780"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f083eaef1646af12fa937c3ae8fecce1d772ef8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[libvirt]/sparse_logical_volumes`` configuration option is now"},{"line_number":5,"context_line":"    deprecated. Sparse LVs were never verificated by tests in Nova and some"},{"line_number":6,"context_line":"    bugs were found without having fixes so we prefer to deprecate that feature"},{"line_number":7,"context_line":"    ."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff6b8bd7_c14791bc","line":5,"range":{"start_line":5,"start_character":38,"end_line":5,"end_character":49},"updated":"2018-03-05 14:20:51.000000000","message":"not a word - use \u0027verified\u0027","commit_id":"072fc170cb3f4728aa2c31901e971fb2f5deb780"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3f083eaef1646af12fa937c3ae8fecce1d772ef8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The ``[libvirt]/sparse_logical_volumes`` configuration option is now"},{"line_number":5,"context_line":"    deprecated. Sparse LVs were never verificated by tests in Nova and some"},{"line_number":6,"context_line":"    bugs were found without having fixes so we prefer to deprecate that feature"},{"line_number":7,"context_line":"    ."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff6b8bd7_e14415ba","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":5},"updated":"2018-03-05 14:20:51.000000000","message":"feature. (same line)","commit_id":"072fc170cb3f4728aa2c31901e971fb2f5deb780"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"64b6eb0ed5c33f81c37594adc8fb5efeb5897d31","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    The ``[libvirt]/sparse_logical_volumes`` configuration option is now"},{"line_number":5,"context_line":"    deprecated. Sparse logical volumes were never verified by tests in Nova"},{"line_number":6,"context_line":"    and some bugs were found without having fixes so we prefer to deprecate"},{"line_number":7,"context_line":"    that feature."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff6b8bd7_24945b8b","line":7,"updated":"2018-03-05 14:45:52.000000000","message":"Would you like to mention that by default we attempt to preallocate space for ephemeral LVM-backed disk space?","commit_id":"4c720360b866e22a0c0990b8b3bb066341460e72"}]}