)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"cd4a8a13e688bba4ad24c1ef21cb06eeba928c9d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The addition of the config drive feature broke the VM rescue. The"},{"line_number":10,"context_line":"cause of the problem was setting the instance UUID to the name of"},{"line_number":11,"context_line":"the rescue instance. This must be a UUID! The solution"},{"line_number":12,"context_line":"is to pass the instance name to the spawn method instead of writing"},{"line_number":13,"context_line":"this on the instance UUID."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FK%2Fs%3D","line":11,"updated":"2013-11-13 11:51:27.000000000","message":"\"must be\" or \"must NOT be\"?","commit_id":"47316ba6473691607437da18f03520cad83bc671"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"faf8167ef91cafdc66fa76b4c15b1075a1946cef","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The addition of the config drive feature broke the VM rescue. The"},{"line_number":10,"context_line":"cause of the problem was setting the instance UUID to the name of"},{"line_number":11,"context_line":"the rescue instance. This must be a UUID! The solution"},{"line_number":12,"context_line":"is to pass the instance name to the spawn method instead of writing"},{"line_number":13,"context_line":"this on the instance UUID."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2FHcE%3D","line":11,"in_reply_to":"AAAATn%2F%2FK%2Fs%3D","updated":"2013-11-14 08:41:58.000000000","message":"This is correct. This must be a UUID.","commit_id":"47316ba6473691607437da18f03520cad83bc671"}],"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"cd4a8a13e688bba4ad24c1ef21cb06eeba928c9d","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                                         data_store_name, folder, cookies):"},{"line_number":629,"context_line":"                self.assertTrue(uuidutils.is_uuid_like(instance[\u0027uuid\u0027]))"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"            self.stubs.Set(self.conn._vmops, \u0027_create_config_drive\u0027,"},{"line_number":632,"context_line":"                           fake_create_config_drive)"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        self._create_vm()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FK%2F8%3D","line":631,"updated":"2013-11-13 11:51:27.000000000","message":"I noticed that there is a blueprint is trying to move all test cases use mock but not stub, so can we use mock here?  ;-)","commit_id":"47316ba6473691607437da18f03520cad83bc671"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"faf8167ef91cafdc66fa76b4c15b1075a1946cef","unresolved":false,"context_lines":[{"line_number":628,"context_line":"                                         data_store_name, folder, cookies):"},{"line_number":629,"context_line":"                self.assertTrue(uuidutils.is_uuid_like(instance[\u0027uuid\u0027]))"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"            self.stubs.Set(self.conn._vmops, \u0027_create_config_drive\u0027,"},{"line_number":632,"context_line":"                           fake_create_config_drive)"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"        self._create_vm()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FHbo%3D","line":631,"in_reply_to":"AAAATn%2F%2FK%2F8%3D","updated":"2013-11-14 08:41:58.000000000","message":"My understanding was that this is for new test cases. This is just refactoring an existing one.","commit_id":"47316ba6473691607437da18f03520cad83bc671"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"cd4a8a13e688bba4ad24c1ef21cb06eeba928c9d","unresolved":false,"context_lines":[{"line_number":659,"context_line":"        def fake_detach_disk_from_vm(*args, **kwargs):"},{"line_number":660,"context_line":"            pass"},{"line_number":661,"context_line":""},{"line_number":662,"context_line":"        self.stubs.Set(self.conn._volumeops, \"detach_disk_from_vm\","},{"line_number":663,"context_line":"                       fake_detach_disk_from_vm)"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"        self.conn.unrescue(self.instance, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FK%2F4%3D","line":662,"updated":"2013-11-13 11:51:27.000000000","message":"ditto","commit_id":"47316ba6473691607437da18f03520cad83bc671"}],"nova/tests/virt/vmwareapi/test_vmwareapi_vm_util.py":[{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"c32a391eb4b39efe1eefb5e381ec03339439c3cd","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def test_get_vm_create_spec(self):"},{"line_number":382,"context_line":"        fake_instance \u003d {\u0027id\u0027: 7, \u0027name\u0027: \u0027fake!\u0027,"},{"line_number":383,"context_line":"                         \u0027uuid\u0027: \u0027fake-uuid\u0027,"},{"line_number":384,"context_line":"                         \u0027vcpus\u0027: 2, \u0027memory_mb\u0027: 2048}"},{"line_number":385,"context_line":"        result \u003d vm_util.get_vm_create_spec(fake.FakeFactory(),"},{"line_number":386,"context_line":"                                            fake_instance, \u0027fake-name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fg1w%3D","line":383,"updated":"2013-11-03 08:15:35.000000000","message":"Nit: I think a value that is a uuid string (something canned or generated on-the-fly) will aid in documenting what the call expects as input.","commit_id":"8de7a094efc84f1c25bc9c7beacb0f960bb500b8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ada01377d7d87e12c0b05f9d5a9514c4b993cc90","unresolved":false,"context_lines":[{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def test_get_vm_create_spec(self):"},{"line_number":382,"context_line":"        fake_instance \u003d {\u0027id\u0027: 7, \u0027name\u0027: \u0027fake!\u0027,"},{"line_number":383,"context_line":"                         \u0027uuid\u0027: \u0027fake-uuid\u0027,"},{"line_number":384,"context_line":"                         \u0027vcpus\u0027: 2, \u0027memory_mb\u0027: 2048}"},{"line_number":385,"context_line":"        result \u003d vm_util.get_vm_create_spec(fake.FakeFactory(),"},{"line_number":386,"context_line":"                                            fake_instance, \u0027fake-name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fg0c%3D","line":383,"in_reply_to":"AAAATn%2F%2Fg1w%3D","updated":"2013-11-03 09:04:48.000000000","message":"Done","commit_id":"8de7a094efc84f1c25bc9c7beacb0f960bb500b8"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":7400,"name":"Tracy Jones","email":"tjones@vmware.com","username":"tracyajones"},"change_message_id":"10971bb4857d4711e0ce41b8f19794a38e0cda94","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        if (device.__class__.__name__ \u003d\u003d \"VirtualDisk\"):"},{"line_number":991,"context_line":"            if (not path or path \u003d\u003d device.backing.fileName):"},{"line_number":992,"context_line":"                return device"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"def get_res_pool_ref(session, cluster, node_mo_id):"},{"line_number":996,"context_line":"    \"\"\"Get the resource pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FaKQ%3D","line":993,"updated":"2013-11-07 01:33:19.000000000","message":"so what is returned if this check fails?  Does it explicitly return None if there is no return statement?  Can you add that to be clear?","commit_id":"47316ba6473691607437da18f03520cad83bc671"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"c8780464973e7defde0ca233f11943b4d7a3e49c","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        if (device.__class__.__name__ \u003d\u003d \"VirtualDisk\"):"},{"line_number":991,"context_line":"            if (not path or path \u003d\u003d device.backing.fileName):"},{"line_number":992,"context_line":"                return device"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"def get_res_pool_ref(session, cluster, node_mo_id):"},{"line_number":996,"context_line":"    \"\"\"Get the resource pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FHRA%3D","line":993,"in_reply_to":"AAAATn%2F%2FJUw%3D","updated":"2013-11-14 09:24:20.000000000","message":"Thanks Shawn for the pointer.  Not that python has them, fortunately :-)","commit_id":"47316ba6473691607437da18f03520cad83bc671"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"28a155ea455a0a65a400eba34cc47c5357bba2aa","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        if (device.__class__.__name__ \u003d\u003d \"VirtualDisk\"):"},{"line_number":991,"context_line":"            if (not path or path \u003d\u003d device.backing.fileName):"},{"line_number":992,"context_line":"                return device"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"def get_res_pool_ref(session, cluster, node_mo_id):"},{"line_number":996,"context_line":"    \"\"\"Get the resource pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FJUw%3D","line":993,"in_reply_to":"AAAATn%2F%2FLJs%3D","updated":"2013-11-13 20:25:35.000000000","message":"I\u0027ve been dinged for writing the guard value version Michael proposed before so I wouldn\u0027t *necessarily* want to do that. Python in OpenStack seems to relish early short-circuit returns, returns from inside loops, and other practices that langs like C frown on. (Or langs like Java will stab you in the eye for.)\n\ndynamic langs like Python do implicit None and implicit boolean coercion a lot. This would be one case where I would not mind the implicit None return because it leverages the language\u0027s primitives.\n\n... however ... if you are looking for a *rule* then ...\n\nTypically I prefer explicit. Typically I try to follow the design philosophy of the language I\u0027m in. Things work better that way.\n\nSee: http://c2.com/cgi/wiki?PythonPhilosophy","commit_id":"47316ba6473691607437da18f03520cad83bc671"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3b82341c6b0a6bf2c1da29f38e3ffa4bdf7450e1","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        if (device.__class__.__name__ \u003d\u003d \"VirtualDisk\"):"},{"line_number":991,"context_line":"            if (not path or path \u003d\u003d device.backing.fileName):"},{"line_number":992,"context_line":"                return device"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"def get_res_pool_ref(session, cluster, node_mo_id):"},{"line_number":996,"context_line":"    \"\"\"Get the resource pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FZjM%3D","line":993,"in_reply_to":"AAAATn%2F%2FZ3A%3D","updated":"2013-11-07 08:10:54.000000000","message":"my concern here would be that people would say that it is not pythonic","commit_id":"47316ba6473691607437da18f03520cad83bc671"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"c2f11fb26aa5088effa4fbffdabc6b31bf8ec37b","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        if (device.__class__.__name__ \u003d\u003d \"VirtualDisk\"):"},{"line_number":991,"context_line":"            if (not path or path \u003d\u003d device.backing.fileName):"},{"line_number":992,"context_line":"                return device"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"def get_res_pool_ref(session, cluster, node_mo_id):"},{"line_number":996,"context_line":"    \"\"\"Get the resource pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FLJs%3D","line":993,"in_reply_to":"AAAATn%2F%2FZjM%3D","updated":"2013-11-13 11:10:51.000000000","message":"I\u0027m going to remove my objection and not rating this change - I think it\u0027s better to be explicit on the return type, but I appreciate that no-one else has commented on this hence the implicit return may be considered pythonic.","commit_id":"47316ba6473691607437da18f03520cad83bc671"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"59c8a374a21e94efd5915fe0666c7050faa6f3d4","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        if (device.__class__.__name__ \u003d\u003d \"VirtualDisk\"):"},{"line_number":991,"context_line":"            if (not path or path \u003d\u003d device.backing.fileName):"},{"line_number":992,"context_line":"                return device"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"def get_res_pool_ref(session, cluster, node_mo_id):"},{"line_number":996,"context_line":"    \"\"\"Get the resource pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FZ3A%3D","line":993,"in_reply_to":"AAAATn%2F%2FaDA%3D","updated":"2013-11-07 05:59:14.000000000","message":"Personally I\u0027d prefer it if this was explicit, so the reader isn\u0027t left wondering.  For example:\n\ndevice \u003d None\nfor dev in hardware_devices:\n    if (dev.__class__.__name__ \u003d\u003d \"VirtualDisk\"):\n        if (not path or path \u003d\u003d dev.backing.fileName):\n            device \u003d dev\nreturn device","commit_id":"47316ba6473691607437da18f03520cad83bc671"},{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"664a9dfc9d71dc34e3056cf318be71363b66dd35","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        if (device.__class__.__name__ \u003d\u003d \"VirtualDisk\"):"},{"line_number":991,"context_line":"            if (not path or path \u003d\u003d device.backing.fileName):"},{"line_number":992,"context_line":"                return device"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":""},{"line_number":995,"context_line":"def get_res_pool_ref(session, cluster, node_mo_id):"},{"line_number":996,"context_line":"    \"\"\"Get the resource pool.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FaDA%3D","line":993,"in_reply_to":"AAAATn%2F%2FaKQ%3D","updated":"2013-11-07 03:13:49.000000000","message":"It\u0027s standard python behavior to return None in this case, just like what this function does before the change. That said, we may want to consider log something useful and and raise an exception, since none of the call sites currently expects expects to handle None.","commit_id":"47316ba6473691607437da18f03520cad83bc671"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cdd7d9ce4e46790dd0c499b940cc1b52c493cba5","unresolved":false,"context_lines":[{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    for device in hardware_devices:"},{"line_number":993,"context_line":"        if (device.__class__.__name__ \u003d\u003d \"VirtualDisk\"):"},{"line_number":994,"context_line":"            if (not path or path \u003d\u003d device.backing.fileName):"},{"line_number":995,"context_line":"                return device"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2Fk5Q%3D","line":994,"updated":"2014-01-10 21:00:35.000000000","message":"The parentheses around the condition are not required here (femtonit)","commit_id":"99b19d16e91142c3b503983ec5497f3213470ce3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3c459c3fdae54941e6805ce942e064952d5c0267","unresolved":false,"context_lines":[{"line_number":991,"context_line":""},{"line_number":992,"context_line":"    for device in hardware_devices:"},{"line_number":993,"context_line":"        if (device.__class__.__name__ \u003d\u003d \"VirtualDisk\"):"},{"line_number":994,"context_line":"            if (not path or path \u003d\u003d device.backing.fileName):"},{"line_number":995,"context_line":"                return device"},{"line_number":996,"context_line":""},{"line_number":997,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2FiKk%3D","line":994,"in_reply_to":"AAAAUH%2F%2Fk5Q%3D","updated":"2014-01-12 10:10:07.000000000","message":"Done","commit_id":"99b19d16e91142c3b503983ec5497f3213470ce3"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":8027,"name":"Vui Lam","email":"vui@vmware.com","username":"vui"},"change_message_id":"c32a391eb4b39efe1eefb5e381ec03339439c3cd","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"        r_instance \u003d copy.deepcopy(instance)"},{"line_number":1033,"context_line":"        r_instance[\u0027name\u0027] \u003d r_instance[\u0027name\u0027] + self._rescue_suffix"},{"line_number":1034,"context_line":"        name \u003d r_instance[\u0027uuid\u0027] + self._rescue_suffix"},{"line_number":1035,"context_line":"        self.spawn(context, r_instance, image_meta,"},{"line_number":1036,"context_line":"                   None, None, network_info, name\u003dname)"},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        # Attach vmdk to the rescue VM"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fg1g%3D","line":1035,"updated":"2013-11-03 08:15:35.000000000","message":"This is more a preexisting issue, but I will put it out in case it becomes relevant:\nAttaching the disk_to_rescue in line 1048 after spawn() here powers on the rescue VM will not work for ide disks which are not hot-addable. We should probably look to attach the disk first before doing the power on.","commit_id":"8de7a094efc84f1c25bc9c7beacb0f960bb500b8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ada01377d7d87e12c0b05f9d5a9514c4b993cc90","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"        r_instance \u003d copy.deepcopy(instance)"},{"line_number":1033,"context_line":"        r_instance[\u0027name\u0027] \u003d r_instance[\u0027name\u0027] + self._rescue_suffix"},{"line_number":1034,"context_line":"        name \u003d r_instance[\u0027uuid\u0027] + self._rescue_suffix"},{"line_number":1035,"context_line":"        self.spawn(context, r_instance, image_meta,"},{"line_number":1036,"context_line":"                   None, None, network_info, name\u003dname)"},{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        # Attach vmdk to the rescue VM"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Fg0k%3D","line":1035,"in_reply_to":"AAAATn%2F%2Fg1g%3D","updated":"2013-11-03 09:04:48.000000000","message":"i have added this in a patch based on top of this one","commit_id":"8de7a094efc84f1c25bc9c7beacb0f960bb500b8"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"649051e3e7e4d81a47be3f596f11b5d7feb8a5e7","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def spawn(self, context, instance, image_meta, injected_files,"},{"line_number":162,"context_line":"              admin_password, network_info, block_device_info\u003dNone,"},{"line_number":163,"context_line":"              name\u003dNone):"},{"line_number":164,"context_line":"        \"\"\""},{"line_number":165,"context_line":"        Creates a VM instance."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BEBM%3D","line":163,"updated":"2013-12-02 22:36:34.000000000","message":"I see the use of this in line 1030 on this patch. Would \u0027vm_name\u0027 be better? This name is used for the VM in vCenter/ESX not the instance_name in Nova.","commit_id":"475fb70e1396cbf0a0dbc7327267563219610a61"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aa642f3a62a15a402aaf215fe59eb914f6a0e48f","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def spawn(self, context, instance, image_meta, injected_files,"},{"line_number":162,"context_line":"              admin_password, network_info, block_device_info\u003dNone,"},{"line_number":163,"context_line":"              name\u003dNone):"},{"line_number":164,"context_line":"        \"\"\""},{"line_number":165,"context_line":"        Creates a VM instance."},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BAhM%3D","line":163,"in_reply_to":"AAAATn%2F%2BEBM%3D","updated":"2013-12-03 15:06:42.000000000","message":"Done","commit_id":"475fb70e1396cbf0a0dbc7327267563219610a61"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"649051e3e7e4d81a47be3f596f11b5d7feb8a5e7","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # Get the create vm config spec"},{"line_number":279,"context_line":"        config_spec \u003d vm_util.get_vm_create_spec("},{"line_number":280,"context_line":"                            client_factory, instance, name,"},{"line_number":281,"context_line":"                            data_store_name, vif_infos, os_type)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        def _execute_create_vm():"},{"line_number":284,"context_line":"            \"\"\"Create VM on ESX host.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BECY%3D","line":281,"updated":"2013-12-02 22:36:34.000000000","message":"The need/use for \u0027name\u0027 as a variable is fairly clear at this point in the code.\n\nWould \u0027vm_name\u0027 or \u0027instance_name\u0027 be more appropriate seeing as we use this value again later on?","commit_id":"475fb70e1396cbf0a0dbc7327267563219610a61"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aa642f3a62a15a402aaf215fe59eb914f6a0e48f","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # Get the create vm config spec"},{"line_number":279,"context_line":"        config_spec \u003d vm_util.get_vm_create_spec("},{"line_number":280,"context_line":"                            client_factory, instance, name,"},{"line_number":281,"context_line":"                            data_store_name, vif_infos, os_type)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        def _execute_create_vm():"},{"line_number":284,"context_line":"            \"\"\"Create VM on ESX host.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BAg8%3D","line":281,"in_reply_to":"AAAATn%2F%2BECY%3D","updated":"2013-12-03 15:06:42.000000000","message":"Done","commit_id":"475fb70e1396cbf0a0dbc7327267563219610a61"},{"author":{"_account_id":7629,"name":"Shawn Hartsock","email":"hartsock@acm.org","username":"hartsocks"},"change_message_id":"3b1d6331af3cc792ed40021c52f1e572b7dfaba9","unresolved":false,"context_lines":[{"line_number":893,"context_line":"            LOG.exception(exc, instance\u003dinstance)"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    def destroy(self, instance, network_info, destroy_disks\u003dTrue,"},{"line_number":896,"context_line":"                name\u003dNone):"},{"line_number":897,"context_line":"        \"\"\""},{"line_number":898,"context_line":"        Destroy a VM instance. Steps followed are:"},{"line_number":899,"context_line":"        1. Power off the VM, if it is in poweredOn state."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BAbU%3D","line":896,"updated":"2013-12-03 15:16:56.000000000","message":"Note: same argument from above. We need to differentiate that this \"name\" concept is not the instance name, it is the vm_name in vSphere (vCenter or ESX).","commit_id":"475fb70e1396cbf0a0dbc7327267563219610a61"}]}