)]}'
{"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"fdf197981a590929dff7c43e9e2e0f43a8da6c0a","unresolved":false,"context_lines":[{"line_number":5683,"context_line":"            with self.compute._build_resources(self.context, self.instance,"},{"line_number":5684,"context_line":"                    self.requested_networks, self.security_groups,"},{"line_number":5685,"context_line":"                    self.image, self.block_device_mapping):"},{"line_number":5686,"context_line":"                self.fail()"},{"line_number":5687,"context_line":"        except Exception as e:"},{"line_number":5688,"context_line":"            self.assertEqual(expected_exc, e)"},{"line_number":5689,"context_line":"        mock_build_network.assert_called_once_with(self.context, self.instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_02a47956","line":5686,"updated":"2018-03-09 00:21:43.000000000","message":"Neither this nor the original code really make any sense.  We should be raising something like a test.TestingException here.  Using \u0027raise\u0027 is wrong because this is the wrong context for a bare raise (but it worked because the context manager dealt with the exception); using self.fail() is wrong because it\u0027s raising an AssertionFailure, which is not what we mean.","commit_id":"dd39a1857c6369d2b2cf39ab093ec864540f5f73"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"39883f38bf2e54a2f7a6de05ea19e36866cfff48","unresolved":false,"context_lines":[{"line_number":5683,"context_line":"            with self.compute._build_resources(self.context, self.instance,"},{"line_number":5684,"context_line":"                    self.requested_networks, self.security_groups,"},{"line_number":5685,"context_line":"                    self.image, self.block_device_mapping):"},{"line_number":5686,"context_line":"                self.fail()"},{"line_number":5687,"context_line":"        except Exception as e:"},{"line_number":5688,"context_line":"            self.assertEqual(expected_exc, e)"},{"line_number":5689,"context_line":"        mock_build_network.assert_called_once_with(self.context, self.instance,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_c708cada","line":5686,"in_reply_to":"df7087c5_02a47956","updated":"2018-03-09 10:02:29.000000000","message":"You are right. I was lazy ass and did not understand the full test case. I changed it to TestingException.","commit_id":"dd39a1857c6369d2b2cf39ab093ec864540f5f73"}]}