)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d280e7bbb2b83fceffa39007eb307e5fad250dd5","unresolved":false,"context_lines":[{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    target \u003d messaging.Target(version\u003d\u00275.0\u0027)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    # How long to wait in seconds before re-issuing a shutdown"},{"line_number":491,"context_line":"    # signal to an instance during power off.  The overall"},{"line_number":492,"context_line":"    # time to wait is set by CONF.shutdown_timeout."},{"line_number":493,"context_line":"    # SHUTDOWN_RETRY_INTERVAL \u003d 10"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    def __init__(self, compute_driver\u003dNone, *args, **kwargs):"},{"line_number":496,"context_line":"        \"\"\"Load configuration options and connect to the hypervisor.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_bdf799d3","line":493,"range":{"start_line":490,"start_character":0,"end_line":493,"end_character":34},"updated":"2018-03-13 11:49:15.000000000","message":"You should remove this altogether now","commit_id":"9561f9e0c27f60b88fa3bca311719a11c44a5680"}],"nova/conf/compute.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d280e7bbb2b83fceffa39007eb307e5fad250dd5","unresolved":false,"context_lines":[{"line_number":965,"context_line":"* Any positive integer in seconds (default value is 60)."},{"line_number":966,"context_line":"\"\"\"),"},{"line_number":967,"context_line":"    cfg.IntOpt(\"shutdown_retry_interval\","},{"line_number":968,"context_line":"            default\u003d10,"},{"line_number":969,"context_line":"            min\u003d1,"},{"line_number":970,"context_line":"            help\u003d\"\"\""},{"line_number":971,"context_line":"Time to wait before resending an acpi shutdown signal."},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"Used in all the same situations as the shutdown_timeout setting, it controls"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_1d30059f","line":970,"range":{"start_line":968,"start_character":0,"end_line":970,"end_character":20},"updated":"2018-03-13 11:49:15.000000000","message":"Indentation is off here","commit_id":"9561f9e0c27f60b88fa3bca311719a11c44a5680"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d280e7bbb2b83fceffa39007eb307e5fad250dd5","unresolved":false,"context_lines":[{"line_number":968,"context_line":"            default\u003d10,"},{"line_number":969,"context_line":"            min\u003d1,"},{"line_number":970,"context_line":"            help\u003d\"\"\""},{"line_number":971,"context_line":"Time to wait before resending an acpi shutdown signal."},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"Used in all the same situations as the shutdown_timeout setting, it controls"},{"line_number":974,"context_line":"the period of shutdown signals (in seconds). Default interval is 10 seconds."}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_3d35c98f","line":971,"range":{"start_line":971,"start_character":33,"end_line":971,"end_character":37},"updated":"2018-03-13 11:49:15.000000000","message":"ACPI","commit_id":"9561f9e0c27f60b88fa3bca311719a11c44a5680"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d280e7bbb2b83fceffa39007eb307e5fad250dd5","unresolved":false,"context_lines":[{"line_number":968,"context_line":"            default\u003d10,"},{"line_number":969,"context_line":"            min\u003d1,"},{"line_number":970,"context_line":"            help\u003d\"\"\""},{"line_number":971,"context_line":"Time to wait before resending an acpi shutdown signal."},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"Used in all the same situations as the shutdown_timeout setting, it controls"},{"line_number":974,"context_line":"the period of shutdown signals (in seconds). Default interval is 10 seconds."}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_fd2af129","line":971,"range":{"start_line":971,"start_character":53,"end_line":971,"end_character":54},"updated":"2018-03-13 11:49:15.000000000","message":"to instances.","commit_id":"9561f9e0c27f60b88fa3bca311719a11c44a5680"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d280e7bbb2b83fceffa39007eb307e5fad250dd5","unresolved":false,"context_lines":[{"line_number":970,"context_line":"            help\u003d\"\"\""},{"line_number":971,"context_line":"Time to wait before resending an acpi shutdown signal."},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"Used in all the same situations as the shutdown_timeout setting, it controls"},{"line_number":974,"context_line":"the period of shutdown signals (in seconds). Default interval is 10 seconds."},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_9d23b556","line":973,"range":{"start_line":973,"start_character":39,"end_line":973,"end_character":55},"updated":"2018-03-13 11:49:15.000000000","message":"``shutdown_timeout``","commit_id":"9561f9e0c27f60b88fa3bca311719a11c44a5680"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d280e7bbb2b83fceffa39007eb307e5fad250dd5","unresolved":false,"context_lines":[{"line_number":971,"context_line":"Time to wait before resending an acpi shutdown signal."},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"Used in all the same situations as the shutdown_timeout setting, it controls"},{"line_number":974,"context_line":"the period of shutdown signals (in seconds). Default interval is 10 seconds."},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"Possible values:"},{"line_number":977,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_5d199d1f","line":974,"range":{"start_line":974,"start_character":45,"end_line":974,"end_character":76},"updated":"2018-03-13 11:49:15.000000000","message":"Remove this - we can see the value above and it will be output in the docs.","commit_id":"9561f9e0c27f60b88fa3bca311719a11c44a5680"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d280e7bbb2b83fceffa39007eb307e5fad250dd5","unresolved":false,"context_lines":[{"line_number":970,"context_line":"            help\u003d\"\"\""},{"line_number":971,"context_line":"Time to wait before resending an acpi shutdown signal."},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"Used in all the same situations as the shutdown_timeout setting, it controls"},{"line_number":974,"context_line":"the period of shutdown signals (in seconds). Default interval is 10 seconds."},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"Possible values:"},{"line_number":977,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_5dee7ded","line":974,"range":{"start_line":973,"start_character":0,"end_line":974,"end_character":44},"updated":"2018-03-13 11:49:15.000000000","message":"This isn\u0027t very helpful. Could you just take the content from the comment in the previous file?\n\n    # How long to wait in seconds before re-issuing a shutdown\n    # signal to an instance during power off.  The overall\n    # time to wait is set by CONF.shutdown_timeout.","commit_id":"9561f9e0c27f60b88fa3bca311719a11c44a5680"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d280e7bbb2b83fceffa39007eb307e5fad250dd5","unresolved":false,"context_lines":[{"line_number":975,"context_line":""},{"line_number":976,"context_line":"Possible values:"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"* Any positive integer in seconds (default value is 10)"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"Related options:"},{"line_number":981,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_ddda8d49","line":978,"range":{"start_line":978,"start_character":2,"end_line":978,"end_character":33},"updated":"2018-03-13 11:49:15.000000000","message":"It also has to be greater than 0","commit_id":"9561f9e0c27f60b88fa3bca311719a11c44a5680"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d280e7bbb2b83fceffa39007eb307e5fad250dd5","unresolved":false,"context_lines":[{"line_number":975,"context_line":""},{"line_number":976,"context_line":"Possible values:"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"* Any positive integer in seconds (default value is 10)"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"Related options:"},{"line_number":981,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_7d16e1f3","line":978,"range":{"start_line":978,"start_character":33,"end_line":978,"end_character":55},"updated":"2018-03-13 11:49:15.000000000","message":"ditto","commit_id":"9561f9e0c27f60b88fa3bca311719a11c44a5680"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d280e7bbb2b83fceffa39007eb307e5fad250dd5","unresolved":false,"context_lines":[{"line_number":979,"context_line":""},{"line_number":980,"context_line":"Related options:"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"* shutdown_timeout"},{"line_number":983,"context_line":"\"\"\")"},{"line_number":984,"context_line":"]"},{"line_number":985,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_bde5590b","line":982,"range":{"start_line":982,"start_character":2,"end_line":982,"end_character":18},"updated":"2018-03-13 11:49:15.000000000","message":"``shutdown_timeout``","commit_id":"9561f9e0c27f60b88fa3bca311719a11c44a5680"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"46715ef0f122157e9d5d5c69c18a4c00e131f886","unresolved":false,"context_lines":[{"line_number":968,"context_line":"        default\u003d10,"},{"line_number":969,"context_line":"        min\u003d1,"},{"line_number":970,"context_line":"        help\u003d\"\"\""},{"line_number":971,"context_line":"Time to wait before resending an ACPI shutdown signal to instances."},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"How long to wait in seconds before re-issuing a shutdown signal to an"},{"line_number":974,"context_line":"instance during power off.  The overall time to wait is set by"},{"line_number":975,"context_line":"``shutdown_timeout``."},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_11dc45e2","line":974,"range":{"start_line":971,"start_character":0,"end_line":974,"end_character":26},"updated":"2018-03-31 22:09:56.000000000","message":"You can remove one of these two sentences.","commit_id":"552f58a7fdf16ecd5cbc591e19bb4daa6e09e8c1"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a74788473ada51448b9ab234a6d16097115f0a47","unresolved":false,"context_lines":[{"line_number":976,"context_line":""},{"line_number":977,"context_line":"Possible values:"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"* Any integer greater than 0 in seconds"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"Related options:"},{"line_number":982,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_1eca294d","line":979,"range":{"start_line":979,"start_character":0,"end_line":979,"end_character":39},"updated":"2018-03-30 03:17:51.000000000","message":"can we consider add something on the timeout need bigger than this one ? retry bigger than timeout seems not valid..","commit_id":"552f58a7fdf16ecd5cbc591e19bb4daa6e09e8c1"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"46715ef0f122157e9d5d5c69c18a4c00e131f886","unresolved":false,"context_lines":[{"line_number":976,"context_line":""},{"line_number":977,"context_line":"Possible values:"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"* Any integer greater than 0 in seconds"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"Related options:"},{"line_number":982,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_d1e1ed9c","line":979,"range":{"start_line":979,"start_character":0,"end_line":979,"end_character":39},"in_reply_to":"bf659307_1eca294d","updated":"2018-03-31 22:09:56.000000000","message":"Meh, what would that say?  \"Setting shutdown_retry_interval larger than shutdown_timeout would be a silly thing to do.\"","commit_id":"552f58a7fdf16ecd5cbc591e19bb4daa6e09e8c1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"909fcb12bbaa222405a8e9520efeb5c36efc6b45","unresolved":false,"context_lines":[{"line_number":624,"context_line":"\"\"\")"},{"line_number":625,"context_line":"]"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"compute_group_opts \u003d ["},{"line_number":628,"context_line":"    cfg.IntOpt(\u0027consecutive_build_service_disable_threshold\u0027,"},{"line_number":629,"context_line":"        default\u003d10,"},{"line_number":630,"context_line":"        help\u003d\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_7f54c7ca","line":627,"range":{"start_line":627,"start_character":0,"end_line":627,"end_character":18},"updated":"2018-04-09 21:42:13.000000000","message":"Why not put the new option in this group, so it\u0027s in [compute] rather than [DEFAULT]? I think long-term we\u0027ve wanted to move most things out of DEFAULT if they have a clear specific group home, and this one is pretty clearly in [compute].","commit_id":"72086f1776345e23eb1c77e706a6e67a2144ea9f"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"909fcb12bbaa222405a8e9520efeb5c36efc6b45","unresolved":false,"context_lines":[{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"    @mock.patch(\u0027nova.virt.fake.FakeDriver.power_off\u0027)"},{"line_number":1237,"context_line":"    @mock.patch.object(compute_utils, \u0027get_value_from_system_metadata\u0027,"},{"line_number":1238,"context_line":"            return_value\u003dCONF.shutdown_timeout)"},{"line_number":1239,"context_line":"    def test_power_off_values(self, mock_get_metadata, mock_power_off):"},{"line_number":1240,"context_line":"        instance \u003d fake_instance.fake_instance_obj("},{"line_number":1241,"context_line":"                self.context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_9f68bb87","line":1238,"range":{"start_line":1238,"start_character":25,"end_line":1238,"end_character":46},"updated":"2018-04-09 21:42:13.000000000","message":"This doesn\u0027t test that changing the value actually reads it. Instead, you should have something like this in the test:\n\nself.flags(shutdown_timeout\u003d20)\n\nAnd then assert that mock_power_off is called with 20 (the override) rather than 10, the default.","commit_id":"72086f1776345e23eb1c77e706a6e67a2144ea9f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2bfba9e852d6066bfe67a1e1a6ff444a4a7078f7","unresolved":false,"context_lines":[{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"    @mock.patch(\u0027nova.virt.fake.FakeDriver.power_off\u0027)"},{"line_number":1237,"context_line":"    @mock.patch.object(compute_utils, \u0027get_value_from_system_metadata\u0027,"},{"line_number":1238,"context_line":"            return_value\u003dCONF.shutdown_timeout)"},{"line_number":1239,"context_line":"    def test_power_off_values(self, mock_get_metadata, mock_power_off):"},{"line_number":1240,"context_line":"        instance \u003d fake_instance.fake_instance_obj("},{"line_number":1241,"context_line":"                self.context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_7f0287b6","line":1238,"range":{"start_line":1238,"start_character":25,"end_line":1238,"end_character":46},"in_reply_to":"bf659307_9f68bb87","updated":"2018-04-09 21:45:16.000000000","message":"Sorry, I mean shutdown_retry_interval here - you should override that and make sure it\u0027s used.","commit_id":"72086f1776345e23eb1c77e706a6e67a2144ea9f"}],"releasenotes/notes/expose-shutdown-retry-interval-d83724ade1b44e62.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3454f49430513e382161a1758e171601561d1b51","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The shutdown retry interval in powering off instances can now be set using"},{"line_number":5,"context_line":"    compute configuration setting ``shutdown_retry_interval``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df7087c5_d08ff92b","line":5,"updated":"2018-03-21 21:08:07.000000000","message":"...in the default conf group, right?","commit_id":"b4af31613a221b2b71880594205a29e2152ed04d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9d11654041a2013f951404d6d86de0c10491e1f7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The shutdown retry interval in powering off instances can now be set using"},{"line_number":5,"context_line":"    the configuration setting ``shutdown_retry_interval``, in the"},{"line_number":6,"context_line":"    compute configuration group."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_342ba595","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":11},"updated":"2018-04-11 10:24:19.000000000","message":"nit: ``[compute]``","commit_id":"197539d7a050042463802f6ece98473bbbf9743b"}]}