)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1dd5d318eccf59b43ad0496eeeef3c1ec542a4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update contributor/placement.rst to contemporary reality"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This udpates the placement contributor documentation to reflect the"},{"line_number":10,"context_line":"current state of affairs. Ininitially this was just going to be an"},{"line_number":11,"context_line":"update to reflect that the oslo versioned objects had moved. However,"},{"line_number":12,"context_line":"while reviewing the rest of the doc it became clear there were other"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_f947454b","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":12},"updated":"2018-03-14 11:47:25.000000000","message":"updates","commit_id":"eb637b9de718a5b4c2e29fe4467e374878ce9c7c"}],"doc/source/contributor/placement.rst":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"966ad91706cd72fe8ed0bf4a3c2408afce5d3357","unresolved":false,"context_lines":[{"line_number":176,"context_line":"multiple different handler methods of the same (fully-qualified by package)"},{"line_number":177,"context_line":"name, each available for a different microversion window.  If a request wants a"},{"line_number":178,"context_line":"microversion that\u0027s not available, a defined status code is returned (usually"},{"line_number":179,"context_line":"``404`` or ``405``). There is a unit test in place which will fail if there are"},{"line_number":180,"context_line":"version intersections."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Adding a New Handler"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_ef7061df","line":179,"range":{"start_line":179,"start_character":13,"end_line":179,"end_character":16},"updated":"2018-03-19 17:15:30.000000000","message":"406?","commit_id":"eb637b9de718a5b4c2e29fe4467e374878ce9c7c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e42192a5e5abf235a794d44e6f5c772004fa3199","unresolved":false,"context_lines":[{"line_number":176,"context_line":"multiple different handler methods of the same (fully-qualified by package)"},{"line_number":177,"context_line":"name, each available for a different microversion window.  If a request wants a"},{"line_number":178,"context_line":"microversion that\u0027s not available, a defined status code is returned (usually"},{"line_number":179,"context_line":"``404`` or ``405``). There is a unit test in place which will fail if there are"},{"line_number":180,"context_line":"version intersections."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"Adding a New Handler"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_aa7257e2","line":179,"range":{"start_line":179,"start_character":13,"end_line":179,"end_character":16},"in_reply_to":"df7087c5_ef7061df","updated":"2018-03-19 17:43:02.000000000","message":"This part should probably be explained in more detail as the nouns are probably not specified adequately.\n\n406 happens when you ask for a microversion that is not available, anywhere in the system, usually because the service is older than the client wants it to be. version_handler never returns that. 406 is returned by the middleware before version_handler is ever called.\n\n404 happens if you\u0027ve specified a microversion that is globally legit in the service, but for which there is no URL as that version (meaning if /foo was added at microversion 1.2 and you\u0027ve asked for 1.1, get a 404)\n\n405 happens when you\u0027ve asked for a method that doesn\u0027t exist on a url that does. GET /foo is supported in 1.2 PUT /foo is added in 1.3, you ask for PUT /foo at version 1.2 -\u003e 405\n\nIf you can think of some good ways to get that written down I encourage you to either write it down or help me to write it down.","commit_id":"eb637b9de718a5b4c2e29fe4467e374878ce9c7c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0c1dd5d318eccf59b43ad0496eeeef3c1ec542a4","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"When a handler needs to read or write the data store it should use methods on"},{"line_number":242,"context_line":"the objects found in the"},{"line_number":243,"context_line":"`nova.api.openstack.placement.objects.resource_provider` package. Doing so"},{"line_number":244,"context_line":"requires a context which is provided to the handler method via the WSGI"},{"line_number":245,"context_line":"environment. It can be retrieved as follows::"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_396b7db7","line":243,"range":{"start_line":243,"start_character":0,"end_line":243,"end_character":56},"updated":"2018-03-14 11:47:25.000000000","message":"nit: this should be double backticks, I imagine","commit_id":"eb637b9de718a5b4c2e29fe4467e374878ce9c7c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e3422d673b54bf0128f43c3ebc9d9c8b29bf89d1","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"When a handler needs to read or write the data store it should use methods on"},{"line_number":242,"context_line":"the objects found in the"},{"line_number":243,"context_line":"`nova.api.openstack.placement.objects.resource_provider` package. Doing so"},{"line_number":244,"context_line":"requires a context which is provided to the handler method via the WSGI"},{"line_number":245,"context_line":"environment. It can be retrieved as follows::"},{"line_number":246,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_793ed58b","line":243,"range":{"start_line":243,"start_character":0,"end_line":243,"end_character":56},"in_reply_to":"df7087c5_396b7db7","updated":"2018-03-14 11:51:45.000000000","message":"Yeah, it\u0027s inconsistent throughout the document and I decided in this case to maintain the pre-existing (but probably incorrect) styling.","commit_id":"eb637b9de718a5b4c2e29fe4467e374878ce9c7c"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"966ad91706cd72fe8ed0bf4a3c2408afce5d3357","unresolved":false,"context_lines":[{"line_number":262,"context_line":"`nova/tests/unit/api/openstack/placement/`. The back-end objects are tested"},{"line_number":263,"context_line":"with a combination of unit and functional tests found in"},{"line_number":264,"context_line":"``nova/tests/unit/api/openstack/placement/objects/test_resource_provider.py``"},{"line_number":265,"context_line":"and `nova/tests/functional/db`. Adding unit and non-gabbi functional tests is"},{"line_number":266,"context_line":"done in the same way as other aspects of nova."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Using Gabbi"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_4f586d55","line":265,"range":{"start_line":265,"start_character":5,"end_line":265,"end_character":29},"updated":"2018-03-19 17:15:30.000000000","message":"nova/tests/functional/api/openstack/placement ?","commit_id":"eb637b9de718a5b4c2e29fe4467e374878ce9c7c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"e42192a5e5abf235a794d44e6f5c772004fa3199","unresolved":false,"context_lines":[{"line_number":262,"context_line":"`nova/tests/unit/api/openstack/placement/`. The back-end objects are tested"},{"line_number":263,"context_line":"with a combination of unit and functional tests found in"},{"line_number":264,"context_line":"``nova/tests/unit/api/openstack/placement/objects/test_resource_provider.py``"},{"line_number":265,"context_line":"and `nova/tests/functional/db`. Adding unit and non-gabbi functional tests is"},{"line_number":266,"context_line":"done in the same way as other aspects of nova."},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"Using Gabbi"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_0a7823f6","line":265,"range":{"start_line":265,"start_character":5,"end_line":265,"end_character":29},"in_reply_to":"df7087c5_4f586d55","updated":"2018-03-19 17:43:02.000000000","message":"This sentence is specifically about testing the objects and the functional tests are in progress to move but haven\u0027t moved yet. This is probably not sufficiently clear so a followup is probably useful.","commit_id":"eb637b9de718a5b4c2e29fe4467e374878ce9c7c"}]}