)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a8948aed07e77dd592c436cf37a1c1e05898e9eb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Revert \"Refine waiting for vif plug events during _hard_reboot\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit aaf37a26d6caa124f0cc6c3fe21bfdf58ccb8517."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib3f10706a7191c58909ec1938042ce338df4d499"},{"line_number":12,"context_line":"Closes-Bug: #1755890"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_11652446","line":10,"updated":"2018-03-14 21:01:39.000000000","message":"A bit more context (we should probably put this into the commit message):\n\nThis gets us back to Ib0cf5d55750f13d0499a570f14024dca551ed4d4 which was meant to address an issue introduced by Id188d48609f3d22d14e16c7f6114291d547a8986. So we essentially had three changes:\n\n1. Hard reboot would blow away volumes and vifs and then wait for the vifs to be plugged; this caused a problem for some vif types (linuxbridge was reported) because the event never came and we timed out.\n\n2. To workaround that, a second change was made to simply not wait for vif plugging events.\n\n3. Since #2 was a bit heavy-handed for a problem that didn\u0027t impact openvswitch, another change was made to only wait for non-bridge vif types, so we\u0027d wait for OVS.\n\nBut it turns out that opendaylight is an OVS vif type and doesn\u0027t send events for plugging the vif, only for binding the port (and we don\u0027t re-bind the port during reboot). There is also a report of this being a problem for other types of ports, see If209f77cff2de00f694b01b2507c633ec3882c82.\n\nSo rather than try to special-case every possible vif type that could be impacted by this, we are simply reverting the change so we no longer wait for vif plugged events during hard reboot.\n\nNote that if we went back to Id188d48609f3d22d14e16c7f6114291d547a8986 and tweaked that to not unplug/plug the vifs we wouldn\u0027t have this problem either, and that change was really meant to deal with an encrypted volume issue on reboot. But changing that logic is out of the scope of this change. Alternatively, we could re-bind the port during reboot but that could have other implications, or neutron could put something into the port details telling us which vifs will send events and which won\u0027t, but again that\u0027s all outside of the scope of this patch.","commit_id":"c91e1462a0ffad3ba3f9a21a2cb85e1ef024fb15"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"3e12f3835512691bfcb1ed428f3dbd6d6888ddce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Revert \"Refine waiting for vif plug events during _hard_reboot\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit aaf37a26d6caa124f0cc6c3fe21bfdf58ccb8517."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib3f10706a7191c58909ec1938042ce338df4d499"},{"line_number":12,"context_line":"Closes-Bug: #1755890"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_71dee0da","line":10,"in_reply_to":"df7087c5_11652446","updated":"2018-03-16 14:08:48.000000000","message":"\u003e A bit more context (we should probably put this into the commit\n \u003e message):\n \u003e \n \u003e This gets us back to Ib0cf5d55750f13d0499a570f14024dca551ed4d4\n \u003e which was meant to address an issue introduced by Id188d48609f3d22d14e16c7f6114291d547a8986.\n \u003e So we essentially had three changes:\n \u003e \n \u003e 1. Hard reboot would blow away volumes and vifs and then wait for\n \u003e the vifs to be plugged; this caused a problem for some vif types\n \u003e (linuxbridge was reported) because the event never came and we\n \u003e timed out.\n \u003e \n \u003e 2. To workaround that, a second change was made to simply not wait\n \u003e for vif plugging events.\n \u003e \n \u003e 3. Since #2 was a bit heavy-handed for a problem that didn\u0027t impact\n \u003e openvswitch, another change was made to only wait for non-bridge\n \u003e vif types, so we\u0027d wait for OVS.\n \u003e \n \u003e But it turns out that opendaylight is an OVS vif type and doesn\u0027t\n \u003e send events for plugging the vif, only for binding the port (and we\n \u003e don\u0027t re-bind the port during reboot). There is also a report of\n \u003e this being a problem for other types of ports, see\n \u003e If209f77cff2de00f694b01b2507c633ec3882c82.\n \u003e \n \u003e So rather than try to special-case every possible vif type that\n \u003e could be impacted by this, we are simply reverting the change so we\n \u003e no longer wait for vif plugged events during hard reboot.\n \u003e \n \u003e Note that if we went back to Id188d48609f3d22d14e16c7f6114291d547a8986\n \u003e and tweaked that to not unplug/plug the vifs we wouldn\u0027t have this\n \u003e problem either, and that change was really meant to deal with an\n \u003e encrypted volume issue on reboot. But changing that logic is out of\n \u003e the scope of this change. Alternatively, we could re-bind the port\n \u003e during reboot but that could have other implications, or neutron\n \u003e could put something into the port details telling us which vifs\n \u003e will send events and which won\u0027t, but again that\u0027s all outside of\n \u003e the scope of this patch.","commit_id":"c91e1462a0ffad3ba3f9a21a2cb85e1ef024fb15"}]}