)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"73e08dc02356cf3b03c1d40b68453d979d62b046","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        Determines whether the node\u0027s resources should be presented"},{"line_number":199,"context_line":"        to Nova for use based on the current power, provision and maintenance"},{"line_number":200,"context_line":"        state. This is called after _node_resources_used, so any node that"},{"line_number":201,"context_line":"        is not used and not in AVAILABLE should be considered in a \u0027bad\u0027 state,"},{"line_number":202,"context_line":"        and unavailable for scheduling. Returns True if unacceptable."},{"line_number":203,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_fe025409","line":200,"updated":"2018-03-19 17:47:40.000000000","message":"Yup, says so right here.","commit_id":"ac20fc22adb133d9de5f2ec15faad11b2de1987a"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"82b912b856de49ec9467e6fda97d3e985c08653f","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        Determines whether the node\u0027s resources should be presented"},{"line_number":199,"context_line":"        to Nova for use based on the current power, provision and maintenance"},{"line_number":200,"context_line":"        state. This is called after _node_resources_used, so any node that"},{"line_number":201,"context_line":"        is not used and not in AVAILABLE should be considered in a \u0027bad\u0027 state,"},{"line_number":202,"context_line":"        and unavailable for scheduling. Returns True if unacceptable."},{"line_number":203,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_5e5fe5e4","line":200,"in_reply_to":"df7087c5_fe025409","updated":"2018-03-23 17:11:10.000000000","message":"a nice point.\nAnd another place which calls this method is covering this condition like:\n\n 298         if self._node_resources_used(node):\n 299             # Node is in the process of deploying, is deployed, or is in\n 300             # the process of cleaning up from a deploy. Report all of its\n 301             # resources as in use.\n 302             vcpus_used \u003d vcpus\n 303             memory_mb_used \u003d memory_mb\n 304             local_gb_used \u003d local_gb\n 305         # Always checking allows us to catch the case where Nova thinks there\n 306         # are available resources on the Node, but Ironic does not (because it\n 307         # is not in a usable state): https://launchpad.net/bugs/1503453\n 308         elif self._node_resources_unavailable(node):\n\nSo LGTM","commit_id":"ac20fc22adb133d9de5f2ec15faad11b2de1987a"}]}