)]}'
{"nova/compute/provider_tree.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"b2a6f7085574492e9ecfb3fd57c77d4dc403a464","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        with self.lock:"},{"line_number":523,"context_line":"            provider \u003d self._find_with_lock(name_or_uuid)"},{"line_number":524,"context_line":"            final_traits \u003d provider.traits | set(traits)"},{"line_number":525,"context_line":"            provider.update_traits(final_traits)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def remove_traits(self, name_or_uuid, *traits):"},{"line_number":528,"context_line":"        \"\"\"Unset traits on a provider, without affecting other existing traits."}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_0f6cf0cb","line":525,"range":{"start_line":525,"start_character":12,"end_line":525,"end_character":48},"updated":"2018-03-16 05:15:47.000000000","message":"...yup, I wouldn\u0027t return the return value not to confuse, either.","commit_id":"fd0b1bd0a014c8e1ea1d508af17c94f0b17cd50f"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"c92a0bb8ef691a19d122eb5a59eb4ea43b419160","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        with self.lock:"},{"line_number":523,"context_line":"            provider \u003d self._find_with_lock(name_or_uuid)"},{"line_number":524,"context_line":"            final_traits \u003d provider.traits | set(traits)"},{"line_number":525,"context_line":"            provider.update_traits(final_traits)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def remove_traits(self, name_or_uuid, *traits):"},{"line_number":528,"context_line":"        \"\"\"Unset traits on a provider, without affecting other existing traits."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_6d9bc865","line":525,"range":{"start_line":525,"start_character":12,"end_line":525,"end_character":48},"in_reply_to":"bf659307_17a74b0d","updated":"2018-04-09 18:25:06.000000000","message":"No, Eric, Tetsuro was asking to rename Provider.update_traits() to Provider._update_traits(). He wasn\u0027t suggesting to rename ProviderTree.update_traits() to ProviderTree._update_traits().","commit_id":"fd0b1bd0a014c8e1ea1d508af17c94f0b17cd50f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1018bad629c7ba18fd1e17659348d8f52f8f61e2","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        with self.lock:"},{"line_number":523,"context_line":"            provider \u003d self._find_with_lock(name_or_uuid)"},{"line_number":524,"context_line":"            final_traits \u003d provider.traits | set(traits)"},{"line_number":525,"context_line":"            provider.update_traits(final_traits)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def remove_traits(self, name_or_uuid, *traits):"},{"line_number":528,"context_line":"        \"\"\"Unset traits on a provider, without affecting other existing traits."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_2864dee4","line":525,"range":{"start_line":525,"start_character":12,"end_line":525,"end_character":48},"in_reply_to":"bf659307_6d9bc865","updated":"2018-04-09 18:49:10.000000000","message":"Oh.  _Provider is private anyway, and none of its other methods are marked private, so...","commit_id":"fd0b1bd0a014c8e1ea1d508af17c94f0b17cd50f"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"491866023d78f07488da139f9b7ff0563ce6ca60","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        with self.lock:"},{"line_number":523,"context_line":"            provider \u003d self._find_with_lock(name_or_uuid)"},{"line_number":524,"context_line":"            final_traits \u003d provider.traits | set(traits)"},{"line_number":525,"context_line":"            provider.update_traits(final_traits)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def remove_traits(self, name_or_uuid, *traits):"},{"line_number":528,"context_line":"        \"\"\"Unset traits on a provider, without affecting other existing traits."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_17a74b0d","line":525,"range":{"start_line":525,"start_character":12,"end_line":525,"end_character":48},"in_reply_to":"bf659307_79c32358","updated":"2018-04-02 13:22:29.000000000","message":"No, we still need it from the report client - _refresh_associations uses it to set the traits in the cache based on what exists in placement.\n\nhttps://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L835","commit_id":"fd0b1bd0a014c8e1ea1d508af17c94f0b17cd50f"},{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"54ef265f2513a208ff4fa5b1fe2880641c93cf7a","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        with self.lock:"},{"line_number":523,"context_line":"            provider \u003d self._find_with_lock(name_or_uuid)"},{"line_number":524,"context_line":"            final_traits \u003d provider.traits | set(traits)"},{"line_number":525,"context_line":"            provider.update_traits(final_traits)"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def remove_traits(self, name_or_uuid, *traits):"},{"line_number":528,"context_line":"        \"\"\"Unset traits on a provider, without affecting other existing traits."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_79c32358","line":525,"range":{"start_line":525,"start_character":12,"end_line":525,"end_character":48},"in_reply_to":"df7087c5_0f6cf0cb","updated":"2018-04-02 06:15:14.000000000","message":"Should we rename this \"update_traits\" to \"_update_traits\"?","commit_id":"fd0b1bd0a014c8e1ea1d508af17c94f0b17cd50f"}]}