)]}'
{"id":"openstack%2Fnova~554","triplet_id":"openstack%2Fnova~master~I86d491cfbf8be73672df7cfdf22e465627a86034","project":"openstack/nova","branch":"master","topic":"bug/819997","hashtags":[],"change_id":"I86d491cfbf8be73672df7cfdf22e465627a86034","subject":"Remove VolumeDriver.sync_exec method (lp:819997)","status":"MERGED","created":"2011-09-23 11:05:25.000000000","updated":"2011-10-13 08:45:59.000000000","submitted":"2011-10-13 08:45:57.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b38acfee8271c0cb786f4d29b5e098e8a1f7e88c","_number":554,"virtual_id_number":554,"owner":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2011-10-13 08:45:57.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},"recommended":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"all":[{"value":0,"date":"2011-10-13 08:26:08.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2011-10-13 07:33:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":2,"date":"2011-10-13 08:25:34.000000000","_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-10-13 07:33:35.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2011-10-13 08:25:34.000000000","updated_by":{"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},"reviewer":{"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},"state":"REVIEWER"},{"updated":"2011-10-13 08:45:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b07f4196a9bec0d50e0bb9f2b804c7a0f88aca69","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2011-09-23 11:34:59.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"970bb184566a320dc6879ae083096695cba003ba","author":{"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},"date":"2011-10-10 08:11:35.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nlgtm","accounts_in_message":[],"_revision_number":2},{"id":"60582058a0fb30e58047546d335fd7c9015f59ab","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-10-13 01:18:07.000000000","message":"Patch Set 2: Looks good to me, approved\n\nlgtm.","accounts_in_message":[],"_revision_number":2},{"id":"209250f3dce8e638563fa595ce113ea692e8c34e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 01:18:14.000000000","message":"Patch Set 2:\n\nBuild Started https://jenkins.openstack.org/job/nova-merge/109/ (1/3)","accounts_in_message":[],"_revision_number":2},{"id":"62518608634cfefc178b156a93bc214151051970","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 01:18:15.000000000","message":"Patch Set 2:\n\nBuild Started https://jenkins.openstack.org/job/nova-pep8/1481/ (2/3)","accounts_in_message":[],"_revision_number":2},{"id":"f901b66a56c0ec5faa64c9b072339c13c3fbbbe2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 01:18:53.000000000","message":"Patch Set 2:\n\nBuild Started https://jenkins.openstack.org/job/nova/121631/ (3/3)","accounts_in_message":[],"_revision_number":2},{"id":"257d559b0ff18853fbbbf326c1f0168d3585f095","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 01:19:21.000000000","message":"Patch Set 2: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/nova-merge/109/ : This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset. \nhttps://jenkins.openstack.org/job/nova-pep8/1481/ : FAILURE \nhttps://jenkins.openstack.org/job/nova/121631/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"cf91b0838dbcf97791b1528889e445128661fb4c","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2011-10-13 06:37:19.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9efcf40330c0dccae91be6b9287cb567d8b23c0d","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2011-10-13 07:33:35.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"d5856dd7c49f5377db0c6194ec614d7b99ba87bc","author":{"_account_id":518,"name":"Soren Hansen","email":"soren@linux2go.dk","username":"soren"},"date":"2011-10-13 08:25:34.000000000","message":"Patch Set 3: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"a841ae22df9c4723f775e747a2f7086f6e359009","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 08:26:08.000000000","message":"Patch Set 3:\n\nBuild Started https://jenkins.openstack.org/job/nova-merge/122/ (1/3)","accounts_in_message":[],"_revision_number":3},{"id":"98a92f2c6d476a284fc3d7b1d56ea5d63a4c8325","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 08:26:36.000000000","message":"Patch Set 3:\n\nBuild Started https://jenkins.openstack.org/job/nova-pep8/1494/ (2/3)","accounts_in_message":[],"_revision_number":3},{"id":"5dfe7ca7d766a46c63fc80d1d085ae5204244727","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 08:36:09.000000000","message":"Patch Set 3:\n\nBuild Started https://jenkins.openstack.org/job/nova/121644/ (3/3)","accounts_in_message":[],"_revision_number":3},{"id":"6ba278698053a2666730245c3c25bc9a1a851279","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 08:45:57.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/nova-merge/122/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova-pep8/1494/ : SUCCESS \nhttps://jenkins.openstack.org/job/nova/121644/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"08dccb880421c448af5d4f7d03603ae4b4765287","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-10-13 08:45:59.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"2522a4438b1bc6799845f733894bc1d64b2a755f","revisions":{"9b7789a0f01ed20eb31ea548487bd9f1f0891230":{"kind":"REWORK","_number":1,"created":"2011-09-23 11:05:25.000000000","uploader":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"ref":"refs/changes/54/554/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/554/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/554/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/554/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/554/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/554/1"}}},"commit":{"parents":[{"commit":"ad28eb20de8ec38d4f7e6deb22ffe1d95bac21ae","subject":"Allow the user to choose either ietadm or tgtadm","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ad28eb20de8ec38d4f7e6deb22ffe1d95bac21ae"}]}],"author":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2011-09-18 11:04:46.000000000","tz":60},"committer":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2011-09-23 11:05:00.000000000","tz":60},"subject":"Remove VolumeDriver.sync_exec method","message":"Remove VolumeDriver.sync_exec method\n\nWe always use the same functions for sync_exec and execute.\n\nThe execute method is always synchronous, so the distinction doesn\u0027t\nappear to make sense.\n\nFinally, it looks like it would make sense for execute to ever be\nasync, so the distinction isn\u0027t even serving a useful documentation\npurpose.\n\nChange-Id: I86d491cfbf8be73672df7cfdf22e465627a86034\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b7789a0f01ed20eb31ea548487bd9f1f0891230"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9b7789a0f01ed20eb31ea548487bd9f1f0891230"}]},"branch":"refs/heads/master"},"c9edb67e34baa988108ab505d60c71a078cb7a2e":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2011-09-23 11:34:59.000000000","uploader":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"ref":"refs/changes/54/554/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/554/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/554/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/554/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/554/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/554/2"}}},"commit":{"parents":[{"commit":"6363e961899024bbb72a9640edd1b1008f7157dc","subject":"Allow the user to choose either ietadm or tgtadm (lp:819997)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6363e961899024bbb72a9640edd1b1008f7157dc"}]}],"author":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2011-09-18 11:04:46.000000000","tz":60},"committer":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2011-09-23 11:34:43.000000000","tz":60},"subject":"Remove VolumeDriver.sync_exec method (lp:819997)","message":"Remove VolumeDriver.sync_exec method (lp:819997)\n\nWe always use the same functions for sync_exec and execute.\n\nThe execute method is always synchronous, so the distinction doesn\u0027t\nappear to make sense.\n\nFinally, it looks like it would make sense for execute to ever be\nasync, so the distinction isn\u0027t even serving a useful documentation\npurpose.\n\nChange-Id: I86d491cfbf8be73672df7cfdf22e465627a86034\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c9edb67e34baa988108ab505d60c71a078cb7a2e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c9edb67e34baa988108ab505d60c71a078cb7a2e"}]},"branch":"refs/heads/master"},"2522a4438b1bc6799845f733894bc1d64b2a755f":{"kind":"REWORK","_number":3,"created":"2011-10-13 06:37:19.000000000","uploader":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"ref":"refs/changes/54/554/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/554/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/554/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/554/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/554/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/554/3"}}},"commit":{"parents":[{"commit":"1d0a030e676cb33733ca1bd6b384ca9a682aa5dc","subject":"Merge \"Beef up nova/api/direct.py tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1d0a030e676cb33733ca1bd6b384ca9a682aa5dc"}]}],"author":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2011-09-18 11:04:46.000000000","tz":60},"committer":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2011-10-13 06:34:40.000000000","tz":60},"subject":"Remove VolumeDriver.sync_exec method (lp:819997)","message":"Remove VolumeDriver.sync_exec method (lp:819997)\n\nWe always use the same functions for sync_exec and execute.\n\nThe execute method is always synchronous, so the distinction doesn\u0027t\nappear to make sense.\n\nFinally, it looks like it would make sense for execute to ever be\nasync, so the distinction isn\u0027t even serving a useful documentation\npurpose.\n\nChange-Id: I86d491cfbf8be73672df7cfdf22e465627a86034\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2522a4438b1bc6799845f733894bc1d64b2a755f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2522a4438b1bc6799845f733894bc1d64b2a755f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}