)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5da473e3c57268eaac96bc5d5dd927dabd6a42e2","unresolved":false,"context_lines":[{"line_number":7419,"context_line":"                        self._shutdown_instance(context, instance, bdms,"},{"line_number":7420,"context_line":"                                                notify\u003dFalse)"},{"line_number":7421,"context_line":"                        self._cleanup_volumes(context, instance, bdms,"},{"line_number":7422,"context_line":"                                              detach\u003dFalse)"},{"line_number":7423,"context_line":"                    except Exception as e:"},{"line_number":7424,"context_line":"                        LOG.warning(\"Periodic cleanup failed to delete \""},{"line_number":7425,"context_line":"                                    \"instance: %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_7e64aee5","line":7422,"range":{"start_line":7422,"start_character":58,"end_line":7422,"end_character":59},"updated":"2018-03-22 10:43:30.000000000","message":"looks good but it might skip the notification things, is it ok? - https://github.com/openstack/nova/blob/315a4d63c223690c66fa448a20d77ec23148016f/nova/compute/manager.py#L5379","commit_id":"1a241d0fb374c8747e3712313417a4fa284a4e43"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0814e64f0c26a4730b5d17c5843ebc6d29b3d542","unresolved":false,"context_lines":[{"line_number":7419,"context_line":"                        self._shutdown_instance(context, instance, bdms,"},{"line_number":7420,"context_line":"                                                notify\u003dFalse)"},{"line_number":7421,"context_line":"                        self._cleanup_volumes(context, instance, bdms,"},{"line_number":7422,"context_line":"                                              detach\u003dFalse)"},{"line_number":7423,"context_line":"                    except Exception as e:"},{"line_number":7424,"context_line":"                        LOG.warning(\"Periodic cleanup failed to delete \""},{"line_number":7425,"context_line":"                                    \"instance: %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_b97260ac","line":7422,"range":{"start_line":7422,"start_character":58,"end_line":7422,"end_character":59},"in_reply_to":"df7087c5_7e64aee5","updated":"2018-03-22 11:26:53.000000000","message":"Yes this will cause that no detach notification will be emitted when this periodic task deletes a running instance having a volume attached. However the normal instance delete code patch doesn\u0027t emit such notification either[1] as it only calls _shutdown_instance()[2]. \nSo this change makes the emitted notification in sync between normal delete and zombie delete case. Which is I think an improvement. \nI don\u0027t think that any notification consumer relied on getting a volume detach notification in this case as that consume would fail on the normal delete case where no such notification is emitted.\n\n[1] https://github.com/openstack/nova/blob/8a6665bc58d53f6ba0346760ba86d97d3437bfc5/nova/tests/functional/notification_sample_tests/test_instance.py#L333\n\n[2] https://github.com/openstack/nova/blob/2ec8c49f6cb4a0e7dba217e824c20d9c703d2105/nova/compute/manager.py#L2475","commit_id":"1a241d0fb374c8747e3712313417a4fa284a4e43"},{"author":{"_account_id":12382,"name":"YaoZheng","email":"zheng.yao1@zte.com.cn","username":"YaoZheng"},"change_message_id":"8357435e96d1ae42db4d9a3aafeda7f236f73da1","unresolved":false,"context_lines":[{"line_number":7419,"context_line":"                        self._shutdown_instance(context, instance, bdms,"},{"line_number":7420,"context_line":"                                                notify\u003dFalse)"},{"line_number":7421,"context_line":"                        self._cleanup_volumes(context, instance, bdms,"},{"line_number":7422,"context_line":"                                              detach\u003dFalse)"},{"line_number":7423,"context_line":"                    except Exception as e:"},{"line_number":7424,"context_line":"                        LOG.warning(\"Periodic cleanup failed to delete \""},{"line_number":7425,"context_line":"                                    \"instance: %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_be480687","line":7422,"range":{"start_line":7422,"start_character":58,"end_line":7422,"end_character":59},"in_reply_to":"df7087c5_7e64aee5","updated":"2018-03-22 11:19:24.000000000","message":"yes, the function _shutdown_instance can call detach_volume that will notification.","commit_id":"1a241d0fb374c8747e3712313417a4fa284a4e43"}]}