)]}'
{"nova/db/sqlalchemy/migrate_repo/versions/216_sync_quota_usages.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"961185dbf2b6980ba16590ce589da1f7ae446370","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    reservations \u003d Table(\u0027reservations\u0027, meta, autoload\u003dTrue)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    #(yuyangbj): Move the resource_tuples and resources up to"},{"line_number":33,"context_line":"    # above is to fix the bug 1245746"},{"line_number":34,"context_line":"    resource_tuples \u003d select(columns\u003d[quota_usages.c.resource],"},{"line_number":35,"context_line":"            distinct\u003dTrue).execute().fetchall()"},{"line_number":36,"context_line":"    resources \u003d [resource[0] for resource in resource_tuples]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2Faxw%3D","line":33,"updated":"2013-11-06 17:37:04.000000000","message":"Remove this comment. Git will track the diffs and history and blame can be used to tell why it was moved/modified.  Also, shouldn\u0027t have bug numbers in the code comments anyway, the information should just be sufficient in the commit message so someone can use the git log to see the history.","commit_id":"0dd64796c04e7ba0665a8562a7269f71a8d9dde0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bfcc005ed6e3e02f658cbee24e4f2dde18be7f6e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        delete_null_rows(resource, quota_usages, reservations)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    for resource in [\u0027fixed_ips\u0027, \u0027floating_ips\u0027, \u0027networks\u0027]:"},{"line_number":55,"context_line":"        delete_per_user_rows(resource, quota_usages, reservations)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def delete_null_rows(resource, quota_usages, reservations):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Bcx4%3D","line":55,"updated":"2013-11-25 22:39:12.000000000","message":"Actually isn\u0027t this broken now if you move it after the syncs?","commit_id":"cde2a592ef5cdceaca29d990b4750490c411c568"}],"nova/tests/db/test_migrations.py":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"fbb82a3ad18df55dc54b046931ef75ccadd651b4","unresolved":false,"context_lines":[{"line_number":3227,"context_line":"                              \u0027deleted\u0027: 0},"},{"line_number":3228,"context_line":"                             {\u0027user_id\u0027: \u0027234\u0027, \u0027project_id\u0027: \u00275678\u0027,"},{"line_number":3229,"context_line":"                              \u0027vcpus\u0027: 1, \u0027memory_mb\u0027: 256, \u0027deleted\u0027: 0},"},{"line_number":3230,"context_line":"                             {\u0027user_id\u0027: \u00274321\u0027, \u0027project_id\u0027: \u00271234\u0027,"},{"line_number":3231,"context_line":"                              \u0027vcpus\u0027: 1, \u0027memory_mb\u0027: 512, \u0027deleted\u0027: 0}],"},{"line_number":3232,"context_line":"            \u0027security_groups\u0027: [{\u0027user_id\u0027: \u00271234\u0027, \u0027project_id\u0027: \u00275678\u0027,"},{"line_number":3233,"context_line":"                                 \u0027deleted\u0027: 0},"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FTGE%3D","line":3230,"updated":"2013-11-11 13:23:11.000000000","message":"Why not using the 234 entry above but adding a new entry?","commit_id":"cde2a592ef5cdceaca29d990b4750490c411c568"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"172f0c9ac65f7e881a092dad0a8af7a764242db7","unresolved":false,"context_lines":[{"line_number":3227,"context_line":"                              \u0027deleted\u0027: 0},"},{"line_number":3228,"context_line":"                             {\u0027user_id\u0027: \u0027234\u0027, \u0027project_id\u0027: \u00275678\u0027,"},{"line_number":3229,"context_line":"                              \u0027vcpus\u0027: 1, \u0027memory_mb\u0027: 256, \u0027deleted\u0027: 0},"},{"line_number":3230,"context_line":"                             {\u0027user_id\u0027: \u00274321\u0027, \u0027project_id\u0027: \u00271234\u0027,"},{"line_number":3231,"context_line":"                              \u0027vcpus\u0027: 1, \u0027memory_mb\u0027: 512, \u0027deleted\u0027: 0}],"},{"line_number":3232,"context_line":"            \u0027security_groups\u0027: [{\u0027user_id\u0027: \u00271234\u0027, \u0027project_id\u0027: \u00275678\u0027,"},{"line_number":3233,"context_line":"                                 \u0027deleted\u0027: 0},"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FS%2F0%3D","line":3230,"in_reply_to":"AAAATn%2F%2FTGE%3D","updated":"2013-11-11 13:52:19.000000000","message":"Because we need to create a scenario that the user_id in quota_usages is None, but user_id 234 exists in the table. See line 3256. If user_id is None in quota_usages, but user_id exists after migration. That\u0027s our target.","commit_id":"cde2a592ef5cdceaca29d990b4750490c411c568"},{"author":{"_account_id":7148,"name":"Zhu Zhu","email":"bjzzu.zz@gmail.com","username":"zhuzhubj"},"change_message_id":"9091361ad09ddc2916740993331ca09a9ff0d0bc","unresolved":false,"context_lines":[{"line_number":3228,"context_line":"                             {\u0027user_id\u0027: \u0027234\u0027, \u0027project_id\u0027: \u00275678\u0027,"},{"line_number":3229,"context_line":"                              \u0027vcpus\u0027: 1, \u0027memory_mb\u0027: 256, \u0027deleted\u0027: 0},"},{"line_number":3230,"context_line":"                             {\u0027user_id\u0027: \u00274321\u0027, \u0027project_id\u0027: \u00271234\u0027,"},{"line_number":3231,"context_line":"                              \u0027vcpus\u0027: 1, \u0027memory_mb\u0027: 512, \u0027deleted\u0027: 0}],"},{"line_number":3232,"context_line":"            \u0027security_groups\u0027: [{\u0027user_id\u0027: \u00271234\u0027, \u0027project_id\u0027: \u00275678\u0027,"},{"line_number":3233,"context_line":"                                 \u0027deleted\u0027: 0},"},{"line_number":3234,"context_line":"                                {\u0027user_id\u0027: \u0027234\u0027, \u0027project_id\u0027: \u00275678\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FS%2B0%3D","line":3231,"updated":"2013-11-11 13:53:53.000000000","message":"+1, agree with xuhan, why not just use userid 1234. The more record inroduced the less readablity the code is. Suggest to change.","commit_id":"cde2a592ef5cdceaca29d990b4750490c411c568"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"b088b190cfd3f055735593bf5cf30b97bb64f0cc","unresolved":false,"context_lines":[{"line_number":3228,"context_line":"                             {\u0027user_id\u0027: \u0027234\u0027, \u0027project_id\u0027: \u00275678\u0027,"},{"line_number":3229,"context_line":"                              \u0027vcpus\u0027: 1, \u0027memory_mb\u0027: 256, \u0027deleted\u0027: 0},"},{"line_number":3230,"context_line":"                             {\u0027user_id\u0027: \u00274321\u0027, \u0027project_id\u0027: \u00271234\u0027,"},{"line_number":3231,"context_line":"                              \u0027vcpus\u0027: 1, \u0027memory_mb\u0027: 512, \u0027deleted\u0027: 0}],"},{"line_number":3232,"context_line":"            \u0027security_groups\u0027: [{\u0027user_id\u0027: \u00271234\u0027, \u0027project_id\u0027: \u00275678\u0027,"},{"line_number":3233,"context_line":"                                 \u0027deleted\u0027: 0},"},{"line_number":3234,"context_line":"                                {\u0027user_id\u0027: \u0027234\u0027, \u0027project_id\u0027: \u00275678\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FO8k%3D","line":3231,"in_reply_to":"AAAATn%2F%2FS%2B0%3D","updated":"2013-11-12 14:23:02.000000000","message":"@Zhu Zhu,\n\nI created a new record with different user_id and project_id aims to create a clean scenario to test if the data is wiped out. If I reused the existing project id, it will block the existing test target. So I prefer to add a new one. Well, if you still think I should use the existing one, I think I can modify the other tests.","commit_id":"cde2a592ef5cdceaca29d990b4750490c411c568"}]}