)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a9f6e40159ece643a9ce6113d34e240796ef3a21","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove RequestContext.instance_lock_checked"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This was initially added in change I1127e31d86a061a93a64ee1eb4a4d900d8bf49b5"},{"line_number":10,"context_line":"but is no longer used anywhere in nova. I can\u0027t find the change that removed"},{"line_number":11,"context_line":"it\u0027s usage though."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Anyway, this change still allows it to be passed as a kwarg for now but will"},{"line_number":14,"context_line":"emit a UserWarning if it is, and then we can make it a hard failure starting"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_e3ccf462","line":11,"range":{"start_line":10,"start_character":40,"end_line":11,"end_character":18},"updated":"2018-03-20 00:29:13.000000000","message":"https://review.openstack.org/#/c/12057/","commit_id":"85721671944269221bc17d3faf78dd0d5103a240"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a9f6e40159ece643a9ce6113d34e240796ef3a21","unresolved":false,"context_lines":[{"line_number":11,"context_line":"it\u0027s usage though."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Anyway, this change still allows it to be passed as a kwarg for now but will"},{"line_number":14,"context_line":"emit a UserWarning if it is, and then we can make it a hard failure starting"},{"line_number":15,"context_line":"in the S release."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib0b23a47c2e833073108af6700b16f8026631a83"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_630a248b","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":17},"updated":"2018-03-20 00:29:13.000000000","message":"Not sure if we should bother.  Do we support anyone subclassing RequestContext?","commit_id":"85721671944269221bc17d3faf78dd0d5103a240"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"95ded21a532ec1e46fc3d41feb28cc22980f8241","unresolved":false,"context_lines":[{"line_number":11,"context_line":"it\u0027s usage though."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Anyway, this change still allows it to be passed as a kwarg for now but will"},{"line_number":14,"context_line":"emit a UserWarning if it is, and then we can make it a hard failure starting"},{"line_number":15,"context_line":"in the S release."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ib0b23a47c2e833073108af6700b16f8026631a83"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df7087c5_01547220","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":17},"in_reply_to":"df7087c5_630a248b","updated":"2018-03-20 13:48:46.000000000","message":"Not really, but this was easy to do.","commit_id":"85721671944269221bc17d3faf78dd0d5103a240"}],"nova/context.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a9f6e40159ece643a9ce6113d34e240796ef3a21","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            kwargs[\u0027tenant\u0027] \u003d project_id"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if kwargs.pop(\u0027instance_lock_checked\u0027, None) is not None:"},{"line_number":113,"context_line":"            # TODO(mriedem): Let this be a hard failure in 19.0.0 (S)."},{"line_number":114,"context_line":"            warnings.warn(\"The \u0027instance_lock_checked\u0027 kwarg to \""},{"line_number":115,"context_line":"                          \"nova.context.RequestContext is no longer used and \""},{"line_number":116,"context_line":"                          \"will be removed in a future version.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_e3f5d484","line":113,"range":{"start_line":113,"start_character":43,"end_line":113,"end_character":55},"updated":"2018-03-20 00:29:13.000000000","message":"Meh, why?  If we\u0027re just going to ignore it anyway, why not let it ride around in kwargs if it\u0027s there?","commit_id":"85721671944269221bc17d3faf78dd0d5103a240"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"37af1a55b6e328a45bcf7fe0650e0a5fe853e71b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            kwargs[\u0027tenant\u0027] \u003d project_id"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if kwargs.pop(\u0027instance_lock_checked\u0027, None) is not None:"},{"line_number":113,"context_line":"            # TODO(mriedem): Let this be a hard failure in 19.0.0 (S)."},{"line_number":114,"context_line":"            warnings.warn(\"The \u0027instance_lock_checked\u0027 kwarg to \""},{"line_number":115,"context_line":"                          \"nova.context.RequestContext is no longer used and \""},{"line_number":116,"context_line":"                          \"will be removed in a future version.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_10991a78","line":113,"range":{"start_line":113,"start_character":43,"end_line":113,"end_character":55},"in_reply_to":"df7087c5_41082a2c","updated":"2018-03-20 16:02:58.000000000","message":"Ah, cool.","commit_id":"85721671944269221bc17d3faf78dd0d5103a240"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"95ded21a532ec1e46fc3d41feb28cc22980f8241","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            kwargs[\u0027tenant\u0027] \u003d project_id"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        if kwargs.pop(\u0027instance_lock_checked\u0027, None) is not None:"},{"line_number":113,"context_line":"            # TODO(mriedem): Let this be a hard failure in 19.0.0 (S)."},{"line_number":114,"context_line":"            warnings.warn(\"The \u0027instance_lock_checked\u0027 kwarg to \""},{"line_number":115,"context_line":"                          \"nova.context.RequestContext is no longer used and \""},{"line_number":116,"context_line":"                          \"will be removed in a future version.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_41082a2c","line":113,"range":{"start_line":113,"start_character":43,"end_line":113,"end_character":55},"in_reply_to":"df7087c5_e3f5d484","updated":"2018-03-20 13:48:46.000000000","message":"Allowing it to get passed to the parent class in oslo.context will blow up since it\u0027s not an expected kwarg there:\n\nhttps://github.com/openstack/oslo.context/blob/2.20.0/oslo_context/context.py#L192\n\nAnd that doesn\u0027t take random kwargs.","commit_id":"85721671944269221bc17d3faf78dd0d5103a240"}]}