)]}'
{"nova/compute/api.py":[{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"654c04d36aa91c2224ed79b37f6dc9fadb9bc93f","unresolved":false,"context_lines":[{"line_number":1302,"context_line":"                                      task_states.SOFT_DELETING):"},{"line_number":1303,"context_line":"            LOG.info(_(\u0027Instance is already in deleting state, ignoring this \u0027"},{"line_number":1304,"context_line":"                       \u0027request\u0027), instance\u003dinstance)"},{"line_number":1305,"context_line":"            return"},{"line_number":1306,"context_line":""},{"line_number":1307,"context_line":"        host \u003d instance[\u0027host\u0027]"},{"line_number":1308,"context_line":"        bdms \u003d block_device.legacy_mapping("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FKns%3D","line":1305,"updated":"2013-11-13 14:00:39.000000000","message":"I think this logic should be later and only at the point where we have decided that the delete request can be sent to the host.\n\nIn the case where the host is down (which is why maybe the state is stuck as \"deleting\") then we want to still go ahead and process the delete locally in the API","commit_id":"f1b55f1b9ceb6a8d003ae621e527a2ff061c637e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b349e889558808542550b58b65cea41af203a0b2","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"                if self.servicegroup_api.service_is_up(service):"},{"line_number":1376,"context_line":"                    is_up \u003d True"},{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"                    if original_task_state in (task_states.DELETING,"},{"line_number":1379,"context_line":"                                                  task_states.SOFT_DELETING):"},{"line_number":1380,"context_line":"                        LOG.info(_(\u0027Instance is already in deleting state, \u0027"},{"line_number":1381,"context_line":"                                   \u0027ignoring this request\u0027), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9WLA%3D","line":1378,"updated":"2013-12-12 12:47:35.000000000","message":"why not do this test at line 1318?","commit_id":"dff256331ec3bda8cc028dd72c75932319b56957"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"810006eb576d09646b48dabb0da08e1e7f60f65c","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"                if self.servicegroup_api.service_is_up(service):"},{"line_number":1376,"context_line":"                    is_up \u003d True"},{"line_number":1377,"context_line":""},{"line_number":1378,"context_line":"                    if original_task_state in (task_states.DELETING,"},{"line_number":1379,"context_line":"                                                  task_states.SOFT_DELETING):"},{"line_number":1380,"context_line":"                        LOG.info(_(\u0027Instance is already in deleting state, \u0027"},{"line_number":1381,"context_line":"                                   \u0027ignoring this request\u0027), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9V44%3D","line":1378,"in_reply_to":"AAAATn%2F9WLA%3D","updated":"2013-12-12 13:43:03.000000000","message":"See comment on patchset 1. (in short, because it would short-circuit api\u0027s emergency delete)","commit_id":"dff256331ec3bda8cc028dd72c75932319b56957"},{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"9bd6b60427046c08a1e2efabd170ce4cad49918c","unresolved":false,"context_lines":[{"line_number":1346,"context_line":"        else:"},{"line_number":1347,"context_line":"            user_id \u003d context.user_id"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"        original_task_state \u003d instance[\u0027task_state\u0027]"},{"line_number":1350,"context_line":""},{"line_number":1351,"context_line":"        try:"},{"line_number":1352,"context_line":"            # NOTE(maoy): no expected_task_state needs to be set"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FsU0%3D","line":1349,"updated":"2014-01-09 16:05:08.000000000","message":"should be instance.task_state","commit_id":"b11e57099f93b5f2f3e3bd05b1ca8dd70f91804b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"d377278d8fc72348567ba5e42ca2e021d24b0566","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"                    is_up \u003d True"},{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"                    if original_task_state in (task_states.DELETING,"},{"line_number":1410,"context_line":"                                                  task_states.SOFT_DELETING):"},{"line_number":1411,"context_line":"                        LOG.info(_(\u0027Instance is already in deleting state, \u0027"},{"line_number":1412,"context_line":"                                   \u0027ignoring this request\u0027), instance\u003dinstance)"},{"line_number":1413,"context_line":"                        if reservations:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FHKM%3D","line":1410,"updated":"2014-01-17 10:35:37.000000000","message":"The indent here is weird.","commit_id":"b3c9cc504903eccbc68c441a81b0a727a83117fa"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3f6f16897b5ba051c1dedca21aaa4b9aad7a42a3","unresolved":false,"context_lines":[{"line_number":1408,"context_line":""},{"line_number":1409,"context_line":"                    if original_task_state in (task_states.DELETING,"},{"line_number":1410,"context_line":"                                                  task_states.SOFT_DELETING):"},{"line_number":1411,"context_line":"                        LOG.info(_(\u0027Instance is already in deleting state, \u0027"},{"line_number":1412,"context_line":"                                   \u0027ignoring this request\u0027), instance\u003dinstance)"},{"line_number":1413,"context_line":"                        if reservations:"},{"line_number":1414,"context_line":"                            QUOTAS.rollback(context, reservations,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BeRo%3D","line":1411,"updated":"2014-01-25 14:14:08.000000000","message":"I really think this should be a debug, but I\u0027ll fix that later.","commit_id":"b3c9cc504903eccbc68c441a81b0a727a83117fa"}],"nova/tests/api/openstack/compute/test_servers.py":[{"author":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"change_message_id":"35010b103c782c87a964d35555487178dae32c3b","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"        # Delete request can be ignored, because it\u0027s been accepted and"},{"line_number":1422,"context_line":"        # forwarded to the compute service already."},{"line_number":1423,"context_line":"        self.assertFalse(self.server_delete_called)"},{"line_number":1424,"context_line":""},{"line_number":1425,"context_line":"    def test_delete_server_instance_while_resize(self):"},{"line_number":1426,"context_line":"        req \u003d self._create_delete_request(FAKE_UUID)"},{"line_number":1427,"context_line":"        self.stubs.Set(db, \u0027instance_get_by_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9tbQ%3D","line":1424,"updated":"2013-12-06 21:11:27.000000000","message":"Can we have a test that it does still do the local delete when the service is down and task_state \u003d\u003d Deleting please","commit_id":"dff256331ec3bda8cc028dd72c75932319b56957"}]}