)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"05cee600fad9526adb2b9439291c742b317cb2b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check return code of command instead of checking stderr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Command \"ip link show\" return a no 0 return code when passing"},{"line_number":10,"context_line":"a no existing ip interface so we should use the return code"},{"line_number":11,"context_line":"instead of checking stderr because stderr can contain messages"},{"line_number":12,"context_line":"from the system even though the command succeeded."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2FVJM%3D","line":9,"updated":"2013-11-10 07:58:18.000000000","message":"Consider changing - \"return a no 0 return code\" \u003d\u003e \"returns 0\"","commit_id":"edc66467fc0dcf729990d8e7baed254f8ded9bfa"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"115c9e0903d8f90255bfde62ca0def99de439685","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Check return code of command instead of checking stderr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Command \"ip link show\" return a no 0 return code when passing"},{"line_number":10,"context_line":"a no existing ip interface so we should use the return code"},{"line_number":11,"context_line":"instead of checking stderr because stderr can contain messages"},{"line_number":12,"context_line":"from the system even though the command succeeded."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2FVD8%3D","line":9,"in_reply_to":"AAAATn%2F%2FVJM%3D","updated":"2013-11-10 12:48:29.000000000","message":"It don\u0027t \"return 0\" for no existing interface !?","commit_id":"edc66467fc0dcf729990d8e7baed254f8ded9bfa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"05cee600fad9526adb2b9439291c742b317cb2b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check return code of command instead of checking stderr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Command \"ip link show\" return a no 0 return code when passing"},{"line_number":10,"context_line":"a no existing ip interface so we should use the return code"},{"line_number":11,"context_line":"instead of checking stderr because stderr can contain messages"},{"line_number":12,"context_line":"from the system even though the command succeeded."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2FVJI%3D","line":10,"updated":"2013-11-10 07:58:18.000000000","message":"\"no existing\" - \"invalid\"","commit_id":"edc66467fc0dcf729990d8e7baed254f8ded9bfa"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"115c9e0903d8f90255bfde62ca0def99de439685","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Check return code of command instead of checking stderr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Command \"ip link show\" return a no 0 return code when passing"},{"line_number":10,"context_line":"a no existing ip interface so we should use the return code"},{"line_number":11,"context_line":"instead of checking stderr because stderr can contain messages"},{"line_number":12,"context_line":"from the system even though the command succeeded."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2FVEA%3D","line":10,"in_reply_to":"AAAATn%2F%2FVJI%3D","updated":"2013-11-10 12:48:29.000000000","message":"I am confused by this one, i don\u0027t think \"invalid ip interface\" mean the same think here, IMHO we want \"no existing interface\".","commit_id":"edc66467fc0dcf729990d8e7baed254f8ded9bfa"}],"nova/network/linux_net.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"05cee600fad9526adb2b9439291c742b317cb2b8","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"    try:"},{"line_number":1196,"context_line":"        _execute(\u0027ip\u0027, \u0027link\u0027, \u0027show\u0027, \u0027dev\u0027, device, run_as_root\u003dTrue)"},{"line_number":1197,"context_line":"    except processutils.ProcessExecutionError:"},{"line_number":1198,"context_line":"        return False"},{"line_number":1199,"context_line":"    return True"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FVJQ%3D","line":1198,"updated":"2013-11-10 07:58:18.000000000","message":"can we log a warning here to show the administrator that something fishy has occurred","commit_id":"edc66467fc0dcf729990d8e7baed254f8ded9bfa"},{"author":{"_account_id":7073,"name":"mouad benchchaoui","email":"m.benchchaoui@x-ion.de","username":"mouad"},"change_message_id":"115c9e0903d8f90255bfde62ca0def99de439685","unresolved":false,"context_lines":[{"line_number":1195,"context_line":"    try:"},{"line_number":1196,"context_line":"        _execute(\u0027ip\u0027, \u0027link\u0027, \u0027show\u0027, \u0027dev\u0027, device, run_as_root\u003dTrue)"},{"line_number":1197,"context_line":"    except processutils.ProcessExecutionError:"},{"line_number":1198,"context_line":"        return False"},{"line_number":1199,"context_line":"    return True"},{"line_number":1200,"context_line":""},{"line_number":1201,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FVEM%3D","line":1198,"in_reply_to":"AAAATn%2F%2FVJQ%3D","updated":"2013-11-10 12:48:29.000000000","message":"Why do you want to log a warning, it\u0027s not this function responsibility to do so, it should be the caller responsibility depending on the case that he used it for i.e. did he expect a device to be there or no.","commit_id":"edc66467fc0dcf729990d8e7baed254f8ded9bfa"}]}