)]}'
{"nova/tests/unit/virt/libvirt/volume/test_scaleio.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"27fb538617b9462d8e8b903769b34e79fb503f2d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                     \u0027name\u0027: \u0027vol01\u0027,"},{"line_number":71,"context_line":"                     \u0027device_path\u0027: \u0027/dev/vol01\u0027}"},{"line_number":72,"context_line":"        conn \u003d {\u0027data\u0027: disk_info}"},{"line_number":73,"context_line":"        sio.extend_volume(conn, mock.sentinel.instance)"},{"line_number":74,"context_line":"        self.assertEqual(extended_vol_size,"},{"line_number":75,"context_line":"                         conn[\u0027data\u0027][\u0027size\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_91dae2e6","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":55},"updated":"2018-03-22 00:41:30.000000000","message":"Validate return value.\n\n self.assertEqual(extended_vol_size, \u003cthis line\u003e)","commit_id":"3d773b5d3cc15e816c90d73b22e4664e7dc25287"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"44961925f5a018a85433c5610e16497f42aac79a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                     \u0027device_path\u0027: \u0027/dev/vol01\u0027}"},{"line_number":72,"context_line":"        conn \u003d {\u0027data\u0027: disk_info}"},{"line_number":73,"context_line":"        self.assertEqual(extended_vol_size,"},{"line_number":74,"context_line":"                         sio.extend_volume(conn, mock.sentinel.instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_5895393f","line":74,"updated":"2018-03-22 15:00:57.000000000","message":"missing closing paren","commit_id":"0d30a3e3b735b995ce54518aebbba7c2cb9d03d2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"26d0fe63b51d998aad97b66a35de515a19b51068","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        extended_vol_size \u003d 8"},{"line_number":67,"context_line":"        sio \u003d scaleio.LibvirtScaleIOVolumeDriver(self.fake_host)"},{"line_number":68,"context_line":"        sio.connector.extend_volume \u003d brick_extend_vol"},{"line_number":69,"context_line":"        disk_info \u003d {\u0027size\u0027: extended_vol_size,"},{"line_number":70,"context_line":"                     \u0027name\u0027: \u0027vol01\u0027,"},{"line_number":71,"context_line":"                     \u0027device_path\u0027: \u0027/dev/vol01\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_12463c23","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":54},"updated":"2018-04-04 19:21:43.000000000","message":"I\u0027m not crazy about this, but I see it\u0027s a pattern in the test module here. It would be better to mock out the extend_volume method and use a side_effect, e.g.:\n\nwith mock.patch.object(sio.connector, \u0027extend_volume\u0027, side_effect\u003dbrick_extend_vol):\n    self.assertEqual(extended_vol_size,\n                     sio.extend_volume(conn, mock.sentinel.instance))","commit_id":"3a78b511352a0d849475c0f0bbd3bad9e633477a"}],"nova/virt/libvirt/volume/scaleio.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"27fb538617b9462d8e8b903769b34e79fb503f2d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            connection_info, instance)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def extend_volume(self, connection_info, instance):"},{"line_number":66,"context_line":"        \"\"\"Extend the volume.\"\"\""},{"line_number":67,"context_line":"        LOG.debug(\"calling os-brick to extend ScaleIO Volume\","},{"line_number":68,"context_line":"                  instance\u003dinstance)"},{"line_number":69,"context_line":"        new_size \u003d self.connector.extend_volume(connection_info[\u0027data\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_714aaeac","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":32},"updated":"2018-03-22 00:41:30.000000000","message":"really?","commit_id":"3d773b5d3cc15e816c90d73b22e4664e7dc25287"}],"releasenotes/notes/scaleio-extend-volume-d82c39a30e0a09ca.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"26d0fe63b51d998aad97b66a35de515a19b51068","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added ability to extend an attached ScaleIO volume."},{"line_number":4,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bf659307_5212740b","line":3,"range":{"start_line":3,"start_character":54,"end_line":3,"end_character":55},"updated":"2018-04-04 19:21:43.000000000","message":"\"when using the libvirt compute driver.\"\n\nSince this only applies to the libvirt driver.","commit_id":"3a78b511352a0d849475c0f0bbd3bad9e633477a"}]}