)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ec1c6a14d63110f874b7129fd8576d45b5c20d0c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This introduces a new PowerVM conf option, proc_units_factor, which can"},{"line_number":10,"context_line":"range from 0.05 to 1.0 and will default to 0.1. It is used to calculate"},{"line_number":11,"context_line":"the number of processor units to assign per vCPU."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I67bfe2a6eff86f1947ada7661fc7c3fed81ed28f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf659307_db73d1e6","line":11,"updated":"2018-03-26 18:43:09.000000000","message":"we should probably better explain this for non-Power folks... maybe replace this line with:\n\n\"the physical processing power to assign per vCPU, where 1.0 is a whole physical processor and 0.05 is 1/20th of a physical processor.\"","commit_id":"44900d290edb3c3664121b1d025c99c5a1363746"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"c2d6efc14b9e51d0a9407ba0e79dca2f6013d34d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This introduces a new PowerVM conf option, proc_units_factor, which can"},{"line_number":10,"context_line":"range from 0.05 to 1.0 and will default to 0.1. It is used to calculate"},{"line_number":11,"context_line":"the number of processor units to assign per vCPU."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I67bfe2a6eff86f1947ada7661fc7c3fed81ed28f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bf659307_21ff3b02","line":11,"in_reply_to":"bf659307_db73d1e6","updated":"2018-03-26 21:31:55.000000000","message":"Done","commit_id":"44900d290edb3c3664121b1d025c99c5a1363746"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5219d50e6c3b3da615b506dd92941633c8cd0e91","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This introduces a new PowerVM conf option, proc_units_factor, which can"},{"line_number":10,"context_line":"range from 0.05 to 1.0 and will default to 0.1. It is used to calculate"},{"line_number":11,"context_line":"the physical processing power to assign per vCPU, where 1.0 is a whole"},{"line_number":12,"context_line":"physical processor and 0.05 is 1/20th of a physical processor. If the"},{"line_number":13,"context_line":"powervm:proc_units extra spec is specified it will supersede the nova"},{"line_number":14,"context_line":"config option."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I67bfe2a6eff86f1947ada7661fc7c3fed81ed28f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bf659307_22ece427","line":14,"range":{"start_line":12,"start_character":63,"end_line":14,"end_character":14},"updated":"2018-04-10 14:19:37.000000000","message":"Whoops, this is still wrong.  Strike.","commit_id":"c3ca88a902230270823551d8a9d25702f7b67017"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"abbeb14eb0e653fb04f7e34724f32d2ef7b3dabf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This introduces a new PowerVM conf option, proc_units_factor, which can"},{"line_number":10,"context_line":"range from 0.05 to 1.0 and will default to 0.1. It is used to calculate"},{"line_number":11,"context_line":"the physical processing power to assign per vCPU, where 1.0 is a whole"},{"line_number":12,"context_line":"physical processor and 0.05 is 1/20th of a physical processor. If the"},{"line_number":13,"context_line":"powervm:proc_units extra spec is specified it will supersede the nova"},{"line_number":14,"context_line":"config option."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I67bfe2a6eff86f1947ada7661fc7c3fed81ed28f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bf659307_756931bc","line":14,"range":{"start_line":12,"start_character":63,"end_line":14,"end_character":14},"in_reply_to":"bf659307_22ece427","updated":"2018-04-10 16:24:41.000000000","message":"Done","commit_id":"c3ca88a902230270823551d8a9d25702f7b67017"}],"nova/conf/powervm.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ec1c6a14d63110f874b7129fd8576d45b5c20d0c","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"powervm\","},{"line_number":21,"context_line":"    title\u003d\"PowerVM Options\","},{"line_number":22,"context_line":"    help\u003d\"\"\"PowerVM options allow cloud administrators to configure how"},{"line_number":23,"context_line":"         OpenStack will deploy against the PowerVM hypervisor."},{"line_number":24,"context_line":"         \"\"\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"powervm_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_952be892","line":23,"range":{"start_line":23,"start_character":24,"end_line":23,"end_character":38},"updated":"2018-03-26 18:43:09.000000000","message":"\"work with\"? It\u0027s more than just deploy","commit_id":"44900d290edb3c3664121b1d025c99c5a1363746"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"c2d6efc14b9e51d0a9407ba0e79dca2f6013d34d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    \"powervm\","},{"line_number":21,"context_line":"    title\u003d\"PowerVM Options\","},{"line_number":22,"context_line":"    help\u003d\"\"\"PowerVM options allow cloud administrators to configure how"},{"line_number":23,"context_line":"         OpenStack will deploy against the PowerVM hypervisor."},{"line_number":24,"context_line":"         \"\"\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"powervm_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_90ed33f1","line":23,"range":{"start_line":23,"start_character":24,"end_line":23,"end_character":38},"in_reply_to":"bf659307_952be892","updated":"2018-03-26 21:31:55.000000000","message":"Done","commit_id":"44900d290edb3c3664121b1d025c99c5a1363746"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ec1c6a14d63110f874b7129fd8576d45b5c20d0c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.FloatOpt(\u0027proc_units_factor\u0027,"},{"line_number":28,"context_line":"                 default\u003d0.1,"},{"line_number":29,"context_line":"                 help\u003d\u0027Factor used to calculate the processor units per vcpu. \u0027"},{"line_number":30,"context_line":"                      \u0027Valid values are: 0.05 - 1.0\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_4d2dc893","line":30,"range":{"start_line":30,"start_character":23,"end_line":30,"end_character":51},"updated":"2018-03-26 18:43:09.000000000","message":"\"Valid values range from 0.05 to 1.0 in increments of 0.05.\"\n\nAt least on newer systems. I know older systems only allowed increments of 0.1 and who knows what the future holds. Part of me wants to not say what valid values would be, since that will be up to pypowervm not nova-powervm. Yet we need to give the user a better idea how to fill this in and what it means. Maybe this would be better overall:\n\n\"Factor used to calculate the amount of physical processor compute power given to each vCPU when the powervm:proc_unit_factor extra spec is not specified. E.g. A value of 1.0 means a whole physical processor, whereas 0.05 means 1/20th of a physical processor.\"","commit_id":"44900d290edb3c3664121b1d025c99c5a1363746"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"c2d6efc14b9e51d0a9407ba0e79dca2f6013d34d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.FloatOpt(\u0027proc_units_factor\u0027,"},{"line_number":28,"context_line":"                 default\u003d0.1,"},{"line_number":29,"context_line":"                 help\u003d\u0027Factor used to calculate the processor units per vcpu. \u0027"},{"line_number":30,"context_line":"                      \u0027Valid values are: 0.05 - 1.0\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_70f09fca","line":30,"range":{"start_line":30,"start_character":23,"end_line":30,"end_character":51},"in_reply_to":"bf659307_4d2dc893","updated":"2018-03-26 21:31:55.000000000","message":"Done","commit_id":"44900d290edb3c3664121b1d025c99c5a1363746"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3f409b517cd617f6fbc113065b9e772b80298d32","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.FloatOpt("},{"line_number":29,"context_line":"        \u0027proc_units_factor\u0027,"},{"line_number":30,"context_line":"        default\u003d0.1,"},{"line_number":31,"context_line":"        help\u003d\"\"\"Factor used to calculate the amount of physical processor"},{"line_number":32,"context_line":"             compute power given to each vCPU when the powervm:proc_unit_factor"},{"line_number":33,"context_line":"             extra spec is not specified. E.g. A value of 1.0 means a whole"},{"line_number":34,"context_line":"             physical processor, whereas 0.05 means 1/20th of a physical"},{"line_number":35,"context_line":"             processor."},{"line_number":36,"context_line":"             \"\"\""},{"line_number":37,"context_line":"    ),"},{"line_number":38,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_3a3c39c7","line":35,"range":{"start_line":31,"start_character":14,"end_line":35,"end_character":22},"updated":"2018-03-27 06:49:56.000000000","message":"I think it should be \u003e 0 (can\u0027t be negative) ?","commit_id":"bb069810f6d87ec1733dbb1fef9fb7e6244850f3"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"351fe610a8a35c2ec0face5c06515b817fc9cd51","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.FloatOpt("},{"line_number":29,"context_line":"        \u0027proc_units_factor\u0027,"},{"line_number":30,"context_line":"        default\u003d0.1,"},{"line_number":31,"context_line":"        help\u003d\"\"\"Factor used to calculate the amount of physical processor"},{"line_number":32,"context_line":"             compute power given to each vCPU when the powervm:proc_unit_factor"},{"line_number":33,"context_line":"             extra spec is not specified. E.g. A value of 1.0 means a whole"},{"line_number":34,"context_line":"             physical processor, whereas 0.05 means 1/20th of a physical"},{"line_number":35,"context_line":"             processor."},{"line_number":36,"context_line":"             \"\"\""},{"line_number":37,"context_line":"    ),"},{"line_number":38,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_d73836a1","line":35,"range":{"start_line":31,"start_character":14,"end_line":35,"end_character":22},"in_reply_to":"bf659307_15657ce1","updated":"2018-03-28 21:35:41.000000000","message":"definitely can\u0027t be negative, because that would mean less than zero processors. :)\n\n@esberglu I specifically didn\u0027t want to explicitly give a range, since that will vary depending on your hardware level. That\u0027s why I just suggested an example that kind of hints at the likely range.","commit_id":"bb069810f6d87ec1733dbb1fef9fb7e6244850f3"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"4f83ec1bfe112809d1dcfc51cb596e5c56520d51","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.FloatOpt("},{"line_number":29,"context_line":"        \u0027proc_units_factor\u0027,"},{"line_number":30,"context_line":"        default\u003d0.1,"},{"line_number":31,"context_line":"        help\u003d\"\"\"Factor used to calculate the amount of physical processor"},{"line_number":32,"context_line":"             compute power given to each vCPU when the powervm:proc_unit_factor"},{"line_number":33,"context_line":"             extra spec is not specified. E.g. A value of 1.0 means a whole"},{"line_number":34,"context_line":"             physical processor, whereas 0.05 means 1/20th of a physical"},{"line_number":35,"context_line":"             processor."},{"line_number":36,"context_line":"             \"\"\""},{"line_number":37,"context_line":"    ),"},{"line_number":38,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_15657ce1","line":35,"range":{"start_line":31,"start_character":14,"end_line":35,"end_character":22},"in_reply_to":"bf659307_3a3c39c7","updated":"2018-03-27 13:23:33.000000000","message":"I should have specified more clearly that the range is 0.05 to 1.0. Will fix","commit_id":"bb069810f6d87ec1733dbb1fef9fb7e6244850f3"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"28fe1f9cb74539c118424535241da99e0c334cf9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 IBM Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_385bd787","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":31},"updated":"2018-04-09 13:02:32.000000000","message":"Corporation?","commit_id":"f876a943cccfab3903a3eead07974040175fd9ca"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2a3090b43a732f8b3859b32f8be0a333e186c039","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 IBM Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_61199a86","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":31},"in_reply_to":"bf659307_385bd787","updated":"2018-04-09 14:40:41.000000000","message":"Heh, good catch. If you\u0027re going to include a corp specific copyright, make sure it\u0027s the right one. :)","commit_id":"f876a943cccfab3903a3eead07974040175fd9ca"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"7cf5ceb5142a34f7387320967e0222761bf97558","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 IBM Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_ece5a10b","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":31},"in_reply_to":"bf659307_61199a86","updated":"2018-04-09 16:08:28.000000000","message":"Done","commit_id":"f876a943cccfab3903a3eead07974040175fd9ca"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"28fe1f9cb74539c118424535241da99e0c334cf9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"powervm_opts \u003d ["},{"line_number":28,"context_line":"    cfg.FloatOpt("},{"line_number":29,"context_line":"        \u0027proc_units_factor\u0027,"},{"line_number":30,"context_line":"        default\u003d0.1,"},{"line_number":31,"context_line":"        help\u003d\"\"\"Factor used to calculate the amount of physical processor"},{"line_number":32,"context_line":"             compute power given to each vCPU when the powervm:proc_unit_factor"},{"line_number":33,"context_line":"             extra spec is not specified. E.g. A value of 1.0 means a whole"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_9864634b","line":30,"updated":"2018-04-09 13:02:32.000000000","message":"\u0027max\u0027 and \u0027min\u0027 can be set.\nBut \u0027min\u0027 means \"greater than or equal\".","commit_id":"f876a943cccfab3903a3eead07974040175fd9ca"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"7cf5ceb5142a34f7387320967e0222761bf97558","unresolved":false,"context_lines":[{"line_number":27,"context_line":"powervm_opts \u003d ["},{"line_number":28,"context_line":"    cfg.FloatOpt("},{"line_number":29,"context_line":"        \u0027proc_units_factor\u0027,"},{"line_number":30,"context_line":"        default\u003d0.1,"},{"line_number":31,"context_line":"        help\u003d\"\"\"Factor used to calculate the amount of physical processor"},{"line_number":32,"context_line":"             compute power given to each vCPU when the powervm:proc_unit_factor"},{"line_number":33,"context_line":"             extra spec is not specified. E.g. A value of 1.0 means a whole"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_2cdcf944","line":30,"in_reply_to":"bf659307_9864634b","updated":"2018-04-09 16:08:28.000000000","message":"Done","commit_id":"f876a943cccfab3903a3eead07974040175fd9ca"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"395aedd9ea36dad0b8b81dd37fc3e527f1e01aff","unresolved":false,"context_lines":[{"line_number":27,"context_line":"powervm_opts \u003d ["},{"line_number":28,"context_line":"    cfg.FloatOpt("},{"line_number":29,"context_line":"        \u0027proc_units_factor\u0027,"},{"line_number":30,"context_line":"        default\u003d0.1,"},{"line_number":31,"context_line":"        min\u003d0.05,"},{"line_number":32,"context_line":"        max\u003d1,"},{"line_number":33,"context_line":"        help\u003d\"\"\"Factor used to calculate the amount of physical processor"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_4d34c44a","line":30,"range":{"start_line":30,"start_character":8,"end_line":30,"end_character":20},"updated":"2018-04-09 18:33:55.000000000","message":"Is this what you\u0027d get today without the \"powervm:proc_unit_factor\" flavor extra spec?\n\nWith the in-tree driver, it\u0027s not, because the default in the library is 0.5:\n\nhttps://github.com/powervm/pypowervm/blob/1.1.13/pypowervm/utils/lpar_builder.py#L88","commit_id":"b87b94a194052a6b8bc673881f0f784c2ef735e3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"395aedd9ea36dad0b8b81dd37fc3e527f1e01aff","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        min\u003d0.05,"},{"line_number":32,"context_line":"        max\u003d1,"},{"line_number":33,"context_line":"        help\u003d\"\"\"Factor used to calculate the amount of physical processor"},{"line_number":34,"context_line":"             compute power given to each vCPU when the powervm:proc_unit_factor"},{"line_number":35,"context_line":"             extra spec is not specified. E.g. A value of 1.0 means a whole"},{"line_number":36,"context_line":"             physical processor, whereas 0.05 means 1/20th of a physical"},{"line_number":37,"context_line":"             processor."},{"line_number":38,"context_line":"             \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_0d6c8c34","line":35,"range":{"start_line":34,"start_character":46,"end_line":35,"end_character":40},"updated":"2018-04-09 18:33:55.000000000","message":"The in-tree driver has no concept of this as far as I can tell, so why are we adding a config option for something that\u0027s not even within the in-tree driver? I don\u0027t even see a mention of this flavor extra spec in the out of tree driver.","commit_id":"b87b94a194052a6b8bc673881f0f784c2ef735e3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2c43a031856ec6a04839ca22a6c62ec0f49060d5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        min\u003d0.05,"},{"line_number":32,"context_line":"        max\u003d1,"},{"line_number":33,"context_line":"        help\u003d\"\"\"Factor used to calculate the amount of physical processor"},{"line_number":34,"context_line":"             compute power given to each vCPU when the powervm:proc_units extra"},{"line_number":35,"context_line":"             spec is not specified. E.g. A value of 1.0 means a whole physical"},{"line_number":36,"context_line":"             processor, whereas 0.05 means 1/20th of a physical processor."},{"line_number":37,"context_line":"             \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_1fbb4b72","line":34,"range":{"start_line":34,"start_character":63,"end_line":34,"end_character":73},"updated":"2018-04-09 22:21:56.000000000","message":"proc_units_factor, nah?","commit_id":"002f2b82c66d3d5bfc0f371b7d340850e2d44ebc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9fd9ec48fef0a86c438f7fab8e6feb13ea3cf01d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        min\u003d0.05,"},{"line_number":32,"context_line":"        max\u003d1,"},{"line_number":33,"context_line":"        help\u003d\"\"\"Factor used to calculate the amount of physical processor"},{"line_number":34,"context_line":"             compute power given to each vCPU when the powervm:proc_units extra"},{"line_number":35,"context_line":"             spec is not specified. E.g. A value of 1.0 means a whole physical"},{"line_number":36,"context_line":"             processor, whereas 0.05 means 1/20th of a physical processor."},{"line_number":37,"context_line":"             \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_c23bbace","line":34,"range":{"start_line":34,"start_character":63,"end_line":34,"end_character":73},"in_reply_to":"bf659307_1fbb4b72","updated":"2018-04-09 22:32:34.000000000","message":"Okay, so it *would* be powervm:proc_units_factor - if we wanted to support that, which this patch doesn\u0027t.  nova-powervm doesn\u0027t either, so I see no reason to add it here.  Just rip out \"when ... is not specified\".","commit_id":"002f2b82c66d3d5bfc0f371b7d340850e2d44ebc"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"c4acfc87dec4617f33f185cdbea8edae32680a3d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        min\u003d0.05,"},{"line_number":32,"context_line":"        max\u003d1,"},{"line_number":33,"context_line":"        help\u003d\"\"\"Factor used to calculate the amount of physical processor"},{"line_number":34,"context_line":"             compute power given to each vCPU when the powervm:proc_units extra"},{"line_number":35,"context_line":"             spec is not specified. E.g. A value of 1.0 means a whole physical"},{"line_number":36,"context_line":"             processor, whereas 0.05 means 1/20th of a physical processor."},{"line_number":37,"context_line":"             \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_628d0e30","line":34,"range":{"start_line":34,"start_character":63,"end_line":34,"end_character":73},"in_reply_to":"bf659307_c23bbace","updated":"2018-04-09 22:59:51.000000000","message":"Done","commit_id":"002f2b82c66d3d5bfc0f371b7d340850e2d44ebc"}],"nova/tests/unit/virt/powervm/test_vm.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"ec1c6a14d63110f874b7129fd8576d45b5c20d0c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            name\u003d\u0027lpar_name\u0027, uuid\u003d\u0027lpar_uuid\u0027,"},{"line_number":64,"context_line":"            flavor\u003dmock.Mock(memory_mb\u003d\u0027mem\u0027, vcpus\u003d\u0027vcpus\u0027, extra_specs\u003d{}))"},{"line_number":65,"context_line":"        vmb \u003d vm.VMBuilder(\u0027host\u0027, \u0027adap\u0027)"},{"line_number":66,"context_line":"        mock_def_stdz.assert_called_once_with(\u0027host\u0027)"},{"line_number":67,"context_line":"        self.assertEqual(mock_lpar_bldr.return_value,"},{"line_number":68,"context_line":"                         vmb.lpar_builder(inst))"},{"line_number":69,"context_line":"        self.san_lpar_name.assert_called_once_with(\u0027lpar_name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_0d14b0f4","side":"PARENT","line":66,"updated":"2018-03-26 18:43:09.000000000","message":"this tests the default, but what about testing a non-default conf value?","commit_id":"5e0829824940c45dfd9122025a1b3032f468fe8a"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"c2d6efc14b9e51d0a9407ba0e79dca2f6013d34d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            name\u003d\u0027lpar_name\u0027, uuid\u003d\u0027lpar_uuid\u0027,"},{"line_number":64,"context_line":"            flavor\u003dmock.Mock(memory_mb\u003d\u0027mem\u0027, vcpus\u003d\u0027vcpus\u0027, extra_specs\u003d{}))"},{"line_number":65,"context_line":"        vmb \u003d vm.VMBuilder(\u0027host\u0027, \u0027adap\u0027)"},{"line_number":66,"context_line":"        mock_def_stdz.assert_called_once_with(\u0027host\u0027)"},{"line_number":67,"context_line":"        self.assertEqual(mock_lpar_bldr.return_value,"},{"line_number":68,"context_line":"                         vmb.lpar_builder(inst))"},{"line_number":69,"context_line":"        self.san_lpar_name.assert_called_once_with(\u0027lpar_name\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_6680e98c","side":"PARENT","line":66,"in_reply_to":"bf659307_0d14b0f4","updated":"2018-03-26 21:31:55.000000000","message":"Done","commit_id":"5e0829824940c45dfd9122025a1b3032f468fe8a"}],"nova/virt/powervm/vm.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3f409b517cd617f6fbc113065b9e772b80298d32","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        self.adapter \u003d adapter"},{"line_number":410,"context_line":"        self.host_w \u003d host_w"},{"line_number":411,"context_line":"        kwargs \u003d dict(proc_units_factor\u003dCONF.powervm.proc_units_factor)"},{"line_number":412,"context_line":"        self.stdz \u003d lpar_bldr.DefaultStandardize(host_w, **kwargs)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def lpar_builder(self, inst):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_7a571104","line":411,"range":{"start_line":411,"start_character":7,"end_line":411,"end_character":71},"updated":"2018-03-27 06:49:56.000000000","message":"should some validation and UT for negative test?","commit_id":"bb069810f6d87ec1733dbb1fef9fb7e6244850f3"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"556e0746fc4ef1630ad686ebb0ea303d2d4107ee","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        self.adapter \u003d adapter"},{"line_number":410,"context_line":"        self.host_w \u003d host_w"},{"line_number":411,"context_line":"        kwargs \u003d dict(proc_units_factor\u003dCONF.powervm.proc_units_factor)"},{"line_number":412,"context_line":"        self.stdz \u003d lpar_bldr.DefaultStandardize(host_w, **kwargs)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def lpar_builder(self, inst):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_6c61e311","line":411,"range":{"start_line":411,"start_character":7,"end_line":411,"end_character":71},"in_reply_to":"bf659307_7a571104","updated":"2018-04-04 18:24:34.000000000","message":"Done","commit_id":"bb069810f6d87ec1733dbb1fef9fb7e6244850f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"395aedd9ea36dad0b8b81dd37fc3e527f1e01aff","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        self.adapter \u003d adapter"},{"line_number":410,"context_line":"        self.host_w \u003d host_w"},{"line_number":411,"context_line":"        kwargs \u003d dict(proc_units_factor\u003dCONF.powervm.proc_units_factor)"},{"line_number":412,"context_line":"        self.stdz \u003d lpar_bldr.DefaultStandardize(host_w, **kwargs)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def lpar_builder(self, inst):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_6d10a8a9","line":411,"range":{"start_line":411,"start_character":53,"end_line":411,"end_character":70},"updated":"2018-04-09 18:33:55.000000000","message":"So today this defaults to .5:\n\nhttps://github.com/powervm/pypowervm/blob/1.1.13/pypowervm/utils/lpar_builder.py#L88","commit_id":"b87b94a194052a6b8bc673881f0f784c2ef735e3"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"c4acfc87dec4617f33f185cdbea8edae32680a3d","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        \"\"\""},{"line_number":409,"context_line":"        self.adapter \u003d adapter"},{"line_number":410,"context_line":"        self.host_w \u003d host_w"},{"line_number":411,"context_line":"        kwargs \u003d dict(proc_units_factor\u003dCONF.powervm.proc_units_factor)"},{"line_number":412,"context_line":"        self.stdz \u003d lpar_bldr.DefaultStandardize(host_w, **kwargs)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def lpar_builder(self, inst):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_1c87d911","line":411,"range":{"start_line":411,"start_character":53,"end_line":411,"end_character":70},"in_reply_to":"bf659307_6d10a8a9","updated":"2018-04-09 22:59:51.000000000","message":"Yep, prior to this would be 0.5","commit_id":"b87b94a194052a6b8bc673881f0f784c2ef735e3"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9fd9ec48fef0a86c438f7fab8e6feb13ea3cf01d","unresolved":false,"context_lines":[{"line_number":373,"context_line":"    # \u0027\u0027 is used for attributes that are not implemented yet."},{"line_number":374,"context_line":"    # None means there is no direct attribute mapping and must"},{"line_number":375,"context_line":"    # be handled individually"},{"line_number":376,"context_line":"    _ATTRS_MAP \u003d {"},{"line_number":377,"context_line":"        \u0027powervm:min_mem\u0027: lpar_bldr.MIN_MEM,"},{"line_number":378,"context_line":"        \u0027powervm:max_mem\u0027: lpar_bldr.MAX_MEM,"},{"line_number":379,"context_line":"        \u0027powervm:min_vcpu\u0027: lpar_bldr.MIN_VCPU,"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf659307_1f17cb53","line":376,"range":{"start_line":376,"start_character":4,"end_line":376,"end_character":14},"updated":"2018-04-09 22:32:34.000000000","message":"here","commit_id":"002f2b82c66d3d5bfc0f371b7d340850e2d44ebc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"72b4122b7e1a6632b6aafbf8986b15b0432c03cb","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        \u0027powervm:max_mem\u0027: lpar_bldr.MAX_MEM,"},{"line_number":379,"context_line":"        \u0027powervm:min_vcpu\u0027: lpar_bldr.MIN_VCPU,"},{"line_number":380,"context_line":"        \u0027powervm:max_vcpu\u0027: lpar_bldr.MAX_VCPU,"},{"line_number":381,"context_line":"        \u0027powervm:proc_units\u0027: lpar_bldr.PROC_UNITS,"},{"line_number":382,"context_line":"        \u0027powervm:min_proc_units\u0027: lpar_bldr.MIN_PROC_U,"},{"line_number":383,"context_line":"        \u0027powervm:max_proc_units\u0027: lpar_bldr.MAX_PROC_U,"},{"line_number":384,"context_line":"        \u0027powervm:dedicated_proc\u0027: lpar_bldr.DED_PROCS,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_4576d4a6","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":51},"updated":"2018-04-09 23:49:20.000000000","message":"So we\u0027ll pass in the config option value when initialize the lpar builder but anything specified in the extra spec for this will later overwrite it?","commit_id":"d3eaf0b139824b404412898bbde4a4a84d5a32fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2bcf825ef433bbbb350e91a3b31fadd490b99f47","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        \u0027powervm:max_mem\u0027: lpar_bldr.MAX_MEM,"},{"line_number":379,"context_line":"        \u0027powervm:min_vcpu\u0027: lpar_bldr.MIN_VCPU,"},{"line_number":380,"context_line":"        \u0027powervm:max_vcpu\u0027: lpar_bldr.MAX_VCPU,"},{"line_number":381,"context_line":"        \u0027powervm:proc_units\u0027: lpar_bldr.PROC_UNITS,"},{"line_number":382,"context_line":"        \u0027powervm:min_proc_units\u0027: lpar_bldr.MIN_PROC_U,"},{"line_number":383,"context_line":"        \u0027powervm:max_proc_units\u0027: lpar_bldr.MAX_PROC_U,"},{"line_number":384,"context_line":"        \u0027powervm:dedicated_proc\u0027: lpar_bldr.DED_PROCS,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_a8d7754f","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":51},"in_reply_to":"bf659307_172b20eb","updated":"2018-04-10 15:18:04.000000000","message":"Then why does the commit message say,\n\n  \"If the powervm:proc_units extra spec is specified it will supersede the nova config option.\"\n\nThat, to me, sounds like the flavor extra spec overrides the config option.","commit_id":"d3eaf0b139824b404412898bbde4a4a84d5a32fa"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f934f3ff8d91c15191dd94c34389f1f779cfe1cb","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        \u0027powervm:max_mem\u0027: lpar_bldr.MAX_MEM,"},{"line_number":379,"context_line":"        \u0027powervm:min_vcpu\u0027: lpar_bldr.MIN_VCPU,"},{"line_number":380,"context_line":"        \u0027powervm:max_vcpu\u0027: lpar_bldr.MAX_VCPU,"},{"line_number":381,"context_line":"        \u0027powervm:proc_units\u0027: lpar_bldr.PROC_UNITS,"},{"line_number":382,"context_line":"        \u0027powervm:min_proc_units\u0027: lpar_bldr.MIN_PROC_U,"},{"line_number":383,"context_line":"        \u0027powervm:max_proc_units\u0027: lpar_bldr.MAX_PROC_U,"},{"line_number":384,"context_line":"        \u0027powervm:dedicated_proc\u0027: lpar_bldr.DED_PROCS,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_172b20eb","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":51},"in_reply_to":"bf659307_4576d4a6","updated":"2018-04-10 14:00:42.000000000","message":"No, the proc_units extra spec is not related to the proc_units_factor conf option.  (I mean, the two things are related - see below - but they don\u0027t affect each other in the driver code in any way.)\n\nproc_units is the number of processor units I want my VM to have.\n\nproc_units_factor is the fraction of a physical CPU each of those proc_units comprises.\n\nWe want proc_units_factor to be a one-and-done conf-level setting so that, when we\u0027re looking at different VMs with different numbers of proc_units, we\u0027re comparing apples to apples.","commit_id":"d3eaf0b139824b404412898bbde4a4a84d5a32fa"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"abbeb14eb0e653fb04f7e34724f32d2ef7b3dabf","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        \u0027powervm:max_mem\u0027: lpar_bldr.MAX_MEM,"},{"line_number":379,"context_line":"        \u0027powervm:min_vcpu\u0027: lpar_bldr.MIN_VCPU,"},{"line_number":380,"context_line":"        \u0027powervm:max_vcpu\u0027: lpar_bldr.MAX_VCPU,"},{"line_number":381,"context_line":"        \u0027powervm:proc_units\u0027: lpar_bldr.PROC_UNITS,"},{"line_number":382,"context_line":"        \u0027powervm:min_proc_units\u0027: lpar_bldr.MIN_PROC_U,"},{"line_number":383,"context_line":"        \u0027powervm:max_proc_units\u0027: lpar_bldr.MAX_PROC_U,"},{"line_number":384,"context_line":"        \u0027powervm:dedicated_proc\u0027: lpar_bldr.DED_PROCS,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_b56fc9c3","line":381,"range":{"start_line":381,"start_character":8,"end_line":381,"end_character":51},"in_reply_to":"bf659307_a8d7754f","updated":"2018-04-10 16:24:41.000000000","message":"Because I was all sorts of confused earlier, and forgot to update the commit message once we got it squared away.","commit_id":"d3eaf0b139824b404412898bbde4a4a84d5a32fa"}],"releasenotes/notes/pvm_proc_units_factor-50d1e4ba079d7a6c.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"2c43a031856ec6a04839ca22a6c62ec0f49060d5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    Previously the PowerVM driver would default to 0.5 physical processors per"},{"line_number":10,"context_line":"    vCPU, which is the default from the pypowervm library. The default will now"},{"line_number":11,"context_line":"    be 0.1 physical processors per vCPU, from the ``proc_units_factor``"},{"line_number":12,"context_line":"    configuration option in the ``powervm`` configuration group."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf659307_7f80478c","line":12,"updated":"2018-04-09 22:21:56.000000000","message":"Should we mention that this can (still) be overridden via the extra spec?","commit_id":"002f2b82c66d3d5bfc0f371b7d340850e2d44ebc"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9fd9ec48fef0a86c438f7fab8e6feb13ea3cf01d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    Previously the PowerVM driver would default to 0.5 physical processors per"},{"line_number":10,"context_line":"    vCPU, which is the default from the pypowervm library. The default will now"},{"line_number":11,"context_line":"    be 0.1 physical processors per vCPU, from the ``proc_units_factor``"},{"line_number":12,"context_line":"    configuration option in the ``powervm`` configuration group."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf659307_9f02fb0a","line":12,"in_reply_to":"bf659307_7f80478c","updated":"2018-04-09 22:32:34.000000000","message":"Sorry, there\u0027s no \"still\".  We should decide if we want to be able to override it via extra_specs, in which case we should add it to _ATTRS_MAP (marked in vm.py).  Otherwise, we can leave that and this alone.\n\nRight now OOT matches what you have there - i.e. you can\u0027t override via extra_specs - so I say leave it alone, and disregard my comment above.","commit_id":"002f2b82c66d3d5bfc0f371b7d340850e2d44ebc"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"c4acfc87dec4617f33f185cdbea8edae32680a3d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    Previously the PowerVM driver would default to 0.5 physical processors per"},{"line_number":10,"context_line":"    vCPU, which is the default from the pypowervm library. The default will now"},{"line_number":11,"context_line":"    be 0.1 physical processors per vCPU, from the ``proc_units_factor``"},{"line_number":12,"context_line":"    configuration option in the ``powervm`` configuration group."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf659307_a2724648","line":12,"in_reply_to":"bf659307_9f02fb0a","updated":"2018-04-09 22:59:51.000000000","message":"Leaving for now, others can weigh in on adding to _ATTRS_MAP","commit_id":"002f2b82c66d3d5bfc0f371b7d340850e2d44ebc"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"72b4122b7e1a6632b6aafbf8986b15b0432c03cb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduces the ``powervm`` configuration group which contains the"},{"line_number":5,"context_line":"    ``proc_units_factor`` configuration option. This allows the user to specify"},{"line_number":6,"context_line":"    the physical processing power to assign per vCPU."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_6550b80b","line":5,"range":{"start_line":5,"start_character":64,"end_line":5,"end_character":68},"updated":"2018-04-09 23:49:20.000000000","message":"operator - I consider \u0027users\u0027 for the most part end users of the cloud, i.e. non-admin tenant users.","commit_id":"d3eaf0b139824b404412898bbde4a4a84d5a32fa"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"e494ad65f9285410ba1535ba278390fe9bd22170","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduces the ``powervm`` configuration group which contains the"},{"line_number":5,"context_line":"    ``proc_units_factor`` configuration option. This allows the user to specify"},{"line_number":6,"context_line":"    the physical processing power to assign per vCPU."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_1762403f","line":5,"range":{"start_line":5,"start_character":64,"end_line":5,"end_character":68},"in_reply_to":"bf659307_6550b80b","updated":"2018-04-10 14:12:05.000000000","message":"Done","commit_id":"d3eaf0b139824b404412898bbde4a4a84d5a32fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"72b4122b7e1a6632b6aafbf8986b15b0432c03cb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduces the ``powervm`` configuration group which contains the"},{"line_number":5,"context_line":"    ``proc_units_factor`` configuration option. This allows the user to specify"},{"line_number":6,"context_line":"    the physical processing power to assign per vCPU."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Previously the PowerVM driver would default to 0.5 physical processors per"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_4584945e","line":6,"updated":"2018-04-09 23:49:20.000000000","message":"Why doesn\u0027t this mention the extra spec that overrides the default set via the config option?","commit_id":"d3eaf0b139824b404412898bbde4a4a84d5a32fa"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"f934f3ff8d91c15191dd94c34389f1f779cfe1cb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduces the ``powervm`` configuration group which contains the"},{"line_number":5,"context_line":"    ``proc_units_factor`` configuration option. This allows the user to specify"},{"line_number":6,"context_line":"    the physical processing power to assign per vCPU."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Previously the PowerVM driver would default to 0.5 physical processors per"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_f7378c4c","line":6,"in_reply_to":"bf659307_4584945e","updated":"2018-04-10 14:00:42.000000000","message":"Cause it doesn\u0027t - see previous comment.","commit_id":"d3eaf0b139824b404412898bbde4a4a84d5a32fa"},{"author":{"_account_id":16710,"name":"Eric Berglund","email":"esberglu@us.ibm.com","username":"esberglu"},"change_message_id":"abbeb14eb0e653fb04f7e34724f32d2ef7b3dabf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduces the ``powervm`` configuration group which contains the"},{"line_number":5,"context_line":"    ``proc_units_factor`` configuration option. This allows the user to specify"},{"line_number":6,"context_line":"    the physical processing power to assign per vCPU."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Previously the PowerVM driver would default to 0.5 physical processors per"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_d5727dad","line":6,"in_reply_to":"bf659307_88c5d190","updated":"2018-04-10 16:24:41.000000000","message":"Done","commit_id":"d3eaf0b139824b404412898bbde4a4a84d5a32fa"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2bcf825ef433bbbb350e91a3b31fadd490b99f47","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Introduces the ``powervm`` configuration group which contains the"},{"line_number":5,"context_line":"    ``proc_units_factor`` configuration option. This allows the user to specify"},{"line_number":6,"context_line":"    the physical processing power to assign per vCPU."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Previously the PowerVM driver would default to 0.5 physical processors per"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_88c5d190","line":6,"in_reply_to":"bf659307_f7378c4c","updated":"2018-04-10 15:18:04.000000000","message":"Then the commit message should be cleaned up.","commit_id":"d3eaf0b139824b404412898bbde4a4a84d5a32fa"}]}