)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"16d953c4bf4656d226686b9cbcf04d996f474e2b","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"        # NOTE(sbauza): We want the compute node to hard fail if it won\u0027t be"},{"line_number":1132,"context_line":"        # able to provide its resources to the placement API, or it will not"},{"line_number":1133,"context_line":"        # be able to be eligible as a destination."},{"line_number":1134,"context_line":"        if (CONF.placement.os_region_name is None and"},{"line_number":1135,"context_line":"                CONF.placement.region_name is None):"},{"line_number":1136,"context_line":"            raise exception.PlacementNotConfigured()"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        self.driver.init_host(host\u003dself.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_0b79bffa","line":1135,"range":{"start_line":1134,"start_character":12,"end_line":1135,"end_character":50},"updated":"2018-03-21 22:44:00.000000000","message":"Actually, I *think* because of [1], oslo_config will alias os_region_name to region_name regardless.  So I *think* you can just change this to\n\n if CONF.placement.region_name is None:\n\n[1] https://review.openstack.org/#/c/492247/20/nova/conf/placement.py@56","commit_id":"685be7678b31faf0fd48d91afc131487f78ec448"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5f035928922e6e1056cd790dd3f616925ce5e480","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"        # NOTE(sbauza): We want the compute node to hard fail if it won\u0027t be"},{"line_number":1132,"context_line":"        # able to provide its resources to the placement API, or it will not"},{"line_number":1133,"context_line":"        # be able to be eligible as a destination."},{"line_number":1134,"context_line":"        if (CONF.placement.os_region_name is None and"},{"line_number":1135,"context_line":"                CONF.placement.region_name is None):"},{"line_number":1136,"context_line":"            raise exception.PlacementNotConfigured()"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        self.driver.init_host(host\u003dself.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_54fd1838","line":1135,"range":{"start_line":1134,"start_character":12,"end_line":1135,"end_character":50},"in_reply_to":"df7087c5_0b79bffa","updated":"2018-03-22 01:31:19.000000000","message":"Worth a try I guess. https://review.openstack.org/#/c/554577/ is passing so we can change it and then recheck that devstack patch to see.","commit_id":"685be7678b31faf0fd48d91afc131487f78ec448"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5ac317d64f9cfccb218257bc1fdd42403a63a19a","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"        # NOTE(sbauza): We want the compute node to hard fail if it won\u0027t be"},{"line_number":1132,"context_line":"        # able to provide its resources to the placement API, or it will not"},{"line_number":1133,"context_line":"        # be able to be eligible as a destination."},{"line_number":1134,"context_line":"        if (CONF.placement.os_region_name is None and"},{"line_number":1135,"context_line":"                CONF.placement.region_name is None):"},{"line_number":1136,"context_line":"            raise exception.PlacementNotConfigured()"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        self.driver.init_host(host\u003dself.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_cfd3c137","line":1135,"range":{"start_line":1134,"start_character":12,"end_line":1135,"end_character":50},"in_reply_to":"df7087c5_54fd1838","updated":"2018-03-22 13:09:51.000000000","message":"Done","commit_id":"685be7678b31faf0fd48d91afc131487f78ec448"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"5ac317d64f9cfccb218257bc1fdd42403a63a19a","unresolved":false,"context_lines":[{"line_number":3699,"context_line":"        self.assertRaises(exception.PciDeviceInvalidDeviceName,"},{"line_number":3700,"context_line":"                          self.compute.init_host)"},{"line_number":3701,"context_line":""},{"line_number":3702,"context_line":"    def test_init_host_placement_ensures_default_config_is_unset(self):"},{"line_number":3703,"context_line":"        # Tests that by default the placement config option is unset"},{"line_number":3704,"context_line":"        # NOTE(sbauza): Just resets the conf opt to the real value and not"},{"line_number":3705,"context_line":"        # the faked one."},{"line_number":3706,"context_line":"        fake_conf \u003d copy.copy(CONF)"},{"line_number":3707,"context_line":"        fake_conf.clear_default(\u0027os_region_name\u0027, group\u003d\u0027placement\u0027)"},{"line_number":3708,"context_line":"        self.assertIsNone(CONF.placement.os_region_name)"},{"line_number":3709,"context_line":""},{"line_number":3710,"context_line":"    def test_init_host_placement_config_failure(self):"},{"line_number":3711,"context_line":"        # Tests that we fail init_host if the placement section is"}],"source_content_type":"text/x-python","patch_set":1,"id":"df7087c5_6f48752c","line":3708,"range":{"start_line":3702,"start_character":0,"end_line":3708,"end_character":56},"updated":"2018-03-22 13:09:51.000000000","message":"I totally don\u0027t understand what this test case is accomplishing.","commit_id":"685be7678b31faf0fd48d91afc131487f78ec448"}]}