)]}'
{"etc/nova/nova.conf.sample":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"058ab6846bfb80153d81b928e82bd92c7c8168fd","unresolved":false,"context_lines":[{"line_number":2882,"context_line":""},{"line_number":2883,"context_line":"# Set to a named libvirt CPU model (see names listed in"},{"line_number":2884,"context_line":"# /usr/share/libvirt/cpu_map.xml). Only has effect if"},{"line_number":2885,"context_line":"# libvirt_cpu_mode\u003d\"custom\" and driver_type\u003d\"kvm|qemu\" (string"},{"line_number":2886,"context_line":"# value)"},{"line_number":2887,"context_line":"#cpu_model\u003d\u003cNone\u003e"},{"line_number":2888,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAATn%2F%2FQN4%3D","line":2885,"updated":"2013-11-12 08:13:58.000000000","message":"it should be \u0027cpu_mode\u003d\"custom\" and driver_type\u003d\"kvm|qemu\"\u0027","commit_id":"c5da080a29b3cb41fb8379598c8549c437ace415"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"88640dd61f5d3c8170932949b88d485e6e62ad8c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    cfg.StrOpt(\u0027rescue_ramdisk_id\u0027,"},{"line_number":122,"context_line":"               help\u003d\u0027Rescue ari image\u0027,"},{"line_number":123,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":124,"context_line":"    cfg.StrOpt(\u0027libvirt_type\u0027,"},{"line_number":125,"context_line":"               default\u003d\u0027kvm\u0027,"},{"line_number":126,"context_line":"               help\u003d\u0027Libvirt domain type (valid options are: \u0027"},{"line_number":127,"context_line":"                    \u0027kvm, lxc, qemu, uml, xen)\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FZrY%3D","line":124,"updated":"2013-11-07 06:57:50.000000000","message":"Now that we are moving this into the \u0027libvirt\u0027 group should we rename this to just \u0027type\u0027 (obviously keeping the deprecated \u0027libvirt_type\u0027 option as well)?","commit_id":"e5e50dec6baab6aa175ce33fe5db7aa3645dd536"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"88640dd61f5d3c8170932949b88d485e6e62ad8c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"               help\u003d\u0027Override the default libvirt URI \u0027"},{"line_number":132,"context_line":"                    \u0027(which is dependent on libvirt_type)\u0027,"},{"line_number":133,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":134,"context_line":"    cfg.BoolOpt(\u0027libvirt_inject_password\u0027,"},{"line_number":135,"context_line":"                default\u003dFalse,"},{"line_number":136,"context_line":"                help\u003d\u0027Inject the admin password at boot time, \u0027"},{"line_number":137,"context_line":"                     \u0027without an agent.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FZrI%3D","line":134,"updated":"2013-11-07 06:57:50.000000000","message":"ditto here: should we call this \u0027inject_password\u0027","commit_id":"e5e50dec6baab6aa175ce33fe5db7aa3645dd536"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"88640dd61f5d3c8170932949b88d485e6e62ad8c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                default\u003dTrue,"},{"line_number":141,"context_line":"                help\u003d\u0027Inject the ssh public key at boot time\u0027,"},{"line_number":142,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":143,"context_line":"    cfg.IntOpt(\u0027libvirt_inject_partition\u0027,"},{"line_number":144,"context_line":"                default\u003d1,"},{"line_number":145,"context_line":"                help\u003d\u0027The partition to inject to : \u0027"},{"line_number":146,"context_line":"                     \u0027-2 \u003d\u003e disable, -1 \u003d\u003e inspect (libguestfs only), \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FZrE%3D","line":143,"updated":"2013-11-07 06:57:50.000000000","message":"ditto here: should we call this inject_partition?","commit_id":"e5e50dec6baab6aa175ce33fe5db7aa3645dd536"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"88640dd61f5d3c8170932949b88d485e6e62ad8c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    \u0027raw, qcow2, vmdk, vdi). \u0027"},{"line_number":175,"context_line":"                    \u0027Defaults to same as source image\u0027,"},{"line_number":176,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":177,"context_line":"    cfg.StrOpt(\u0027libvirt_vif_driver\u0027,"},{"line_number":178,"context_line":"               default\u003d\u0027nova.virt.libvirt.vif.LibvirtGenericVIFDriver\u0027,"},{"line_number":179,"context_line":"               help\u003d\u0027The libvirt VIF driver to configure the VIFs.\u0027,"},{"line_number":180,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FZrA%3D","line":177,"updated":"2013-11-07 06:57:50.000000000","message":"vif_driver instead?","commit_id":"e5e50dec6baab6aa175ce33fe5db7aa3645dd536"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"88640dd61f5d3c8170932949b88d485e6e62ad8c","unresolved":false,"context_lines":[{"line_number":178,"context_line":"               default\u003d\u0027nova.virt.libvirt.vif.LibvirtGenericVIFDriver\u0027,"},{"line_number":179,"context_line":"               help\u003d\u0027The libvirt VIF driver to configure the VIFs.\u0027,"},{"line_number":180,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":181,"context_line":"    cfg.ListOpt(\u0027libvirt_volume_drivers\u0027,"},{"line_number":182,"context_line":"                default\u003d["},{"line_number":183,"context_line":"                  \u0027iscsi\u003dnova.virt.libvirt.volume.LibvirtISCSIVolumeDriver\u0027,"},{"line_number":184,"context_line":"                  \u0027iser\u003dnova.virt.libvirt.volume.LibvirtISERVolumeDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FZq4%3D","line":181,"updated":"2013-11-07 06:57:50.000000000","message":"volume_drivers?","commit_id":"e5e50dec6baab6aa175ce33fe5db7aa3645dd536"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"88640dd61f5d3c8170932949b88d485e6e62ad8c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                    \u0027 to a server, which is dependent on libvirt_type. \u0027"},{"line_number":203,"context_line":"                    \u0027(valid options are: sd, xvd, uvd, vd)\u0027,"},{"line_number":204,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":205,"context_line":"    cfg.IntOpt(\u0027libvirt_wait_soft_reboot_seconds\u0027,"},{"line_number":206,"context_line":"               default\u003d120,"},{"line_number":207,"context_line":"               help\u003d\u0027Number of seconds to wait for instance to shut down after\u0027"},{"line_number":208,"context_line":"                    \u0027 soft reboot request is made. We fall back to hard reboot\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FZq0%3D","line":205,"updated":"2013-11-07 06:57:50.000000000","message":"wait_soft_reboot_seconds?","commit_id":"e5e50dec6baab6aa175ce33fe5db7aa3645dd536"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"88640dd61f5d3c8170932949b88d485e6e62ad8c","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                    \u0027 soft reboot request is made. We fall back to hard reboot\u0027"},{"line_number":209,"context_line":"                    \u0027 if instance does not shutdown within this window.\u0027,"},{"line_number":210,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":211,"context_line":"    cfg.BoolOpt(\u0027libvirt_nonblocking\u0027,"},{"line_number":212,"context_line":"                default\u003dTrue,"},{"line_number":213,"context_line":"                help\u003d\u0027Use a separated OS thread pool to realize non-blocking\u0027"},{"line_number":214,"context_line":"                     \u0027 libvirt calls\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FZqw%3D","line":211,"updated":"2013-11-07 06:57:50.000000000","message":"nonblocking?","commit_id":"e5e50dec6baab6aa175ce33fe5db7aa3645dd536"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"88640dd61f5d3c8170932949b88d485e6e62ad8c","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                help\u003d\u0027Use a separated OS thread pool to realize non-blocking\u0027"},{"line_number":214,"context_line":"                     \u0027 libvirt calls\u0027,"},{"line_number":215,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":216,"context_line":"    cfg.StrOpt(\u0027libvirt_cpu_mode\u0027,"},{"line_number":217,"context_line":"               help\u003d\u0027Set to \"host-model\" to clone the host CPU feature flags; \u0027"},{"line_number":218,"context_line":"                    \u0027to \"host-passthrough\" to use the host CPU model exactly; \u0027"},{"line_number":219,"context_line":"                    \u0027to \"custom\" to use a named CPU model; \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FZqs%3D","line":216,"updated":"2013-11-07 06:57:50.000000000","message":"cpu_mode?","commit_id":"e5e50dec6baab6aa175ce33fe5db7aa3645dd536"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"88640dd61f5d3c8170932949b88d485e6e62ad8c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                    \u0027If libvirt_type\u003d\"kvm|qemu\", it will default to \u0027"},{"line_number":222,"context_line":"                    \u0027\"host-model\", otherwise it will default to \"none\"\u0027,"},{"line_number":223,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":224,"context_line":"    cfg.StrOpt(\u0027libvirt_cpu_model\u0027,"},{"line_number":225,"context_line":"               help\u003d\u0027Set to a named libvirt CPU model (see names listed \u0027"},{"line_number":226,"context_line":"                    \u0027in /usr/share/libvirt/cpu_map.xml). Only has effect if \u0027"},{"line_number":227,"context_line":"                    \u0027libvirt_cpu_mode\u003d\"custom\" and libvirt_type\u003d\"kvm|qemu\"\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FZqo%3D","line":224,"updated":"2013-11-07 06:57:50.000000000","message":"cpu_model?","commit_id":"e5e50dec6baab6aa175ce33fe5db7aa3645dd536"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"88640dd61f5d3c8170932949b88d485e6e62ad8c","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                    \u0027in /usr/share/libvirt/cpu_map.xml). Only has effect if \u0027"},{"line_number":227,"context_line":"                    \u0027libvirt_cpu_mode\u003d\"custom\" and libvirt_type\u003d\"kvm|qemu\"\u0027,"},{"line_number":228,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":229,"context_line":"    cfg.StrOpt(\u0027libvirt_snapshots_directory\u0027,"},{"line_number":230,"context_line":"               default\u003d\u0027$instances_path/snapshots\u0027,"},{"line_number":231,"context_line":"               help\u003d\u0027Location where libvirt driver will store snapshots \u0027"},{"line_number":232,"context_line":"                    \u0027before uploading them to image service\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FZqk%3D","line":229,"updated":"2013-11-07 06:57:50.000000000","message":"snapshots_directory?","commit_id":"e5e50dec6baab6aa175ce33fe5db7aa3645dd536"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"8e053ba18eb79b5644990ce83c3948bbbeefe2e1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    cfg.StrOpt(\u0027rescue_ramdisk_id\u0027,"},{"line_number":121,"context_line":"               help\u003d\u0027Rescue ari image\u0027,"},{"line_number":122,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027conn_type\u0027,"},{"line_number":124,"context_line":"               default\u003d\u0027kvm\u0027,"},{"line_number":125,"context_line":"               help\u003d\u0027Libvirt domain type (valid options are: \u0027"},{"line_number":126,"context_line":"                    \u0027kvm, lxc, qemu, uml, xen)\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FXyM%3D","line":123,"updated":"2013-11-08 01:58:28.000000000","message":"Isn\u0027t this a driver_type? (as opposed to a conn_type)\n\nhttp://libvirt.org/guide/html/Application_Development_Guide-Architecture-Remote_URIs.html","commit_id":"e7ba910b04297f312f51ec22639e39ac7f39d790"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"551d89c37d631336f35f7c5f71b25402d5165ad3","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    cfg.StrOpt(\u0027rescue_ramdisk_id\u0027,"},{"line_number":121,"context_line":"               help\u003d\u0027Rescue ari image\u0027,"},{"line_number":122,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027conn_type\u0027,"},{"line_number":124,"context_line":"               default\u003d\u0027kvm\u0027,"},{"line_number":125,"context_line":"               help\u003d\u0027Libvirt domain type (valid options are: \u0027"},{"line_number":126,"context_line":"                    \u0027kvm, lxc, qemu, uml, xen)\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FXX8%3D","line":123,"in_reply_to":"AAAATn%2F%2FXyM%3D","updated":"2013-11-08 05:56:15.000000000","message":"A connection object has a driver type. eg virConnectGetType(), hence I suggested conn_type","commit_id":"e7ba910b04297f312f51ec22639e39ac7f39d790"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"181dc6d091e0851a2a5c8dcd351d9914f5142adf","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    cfg.StrOpt(\u0027rescue_ramdisk_id\u0027,"},{"line_number":121,"context_line":"               help\u003d\u0027Rescue ari image\u0027,"},{"line_number":122,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027conn_type\u0027,"},{"line_number":124,"context_line":"               default\u003d\u0027kvm\u0027,"},{"line_number":125,"context_line":"               help\u003d\u0027Libvirt domain type (valid options are: \u0027"},{"line_number":126,"context_line":"                    \u0027kvm, lxc, qemu, uml, xen)\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FXpI%3D","line":123,"in_reply_to":"AAAATn%2F%2FXyM%3D","updated":"2013-11-08 03:25:28.000000000","message":"Done","commit_id":"e7ba910b04297f312f51ec22639e39ac7f39d790"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"8e053ba18eb79b5644990ce83c3948bbbeefe2e1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                    \u0027kvm, lxc, qemu, uml, xen)\u0027,"},{"line_number":127,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":128,"context_line":"               deprecated_name\u003d\u0027libvirt_type\u0027),"},{"line_number":129,"context_line":"    cfg.StrOpt(\u0027conn_uri\u0027,"},{"line_number":130,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":131,"context_line":"               help\u003d\u0027Override the default libvirt URI \u0027"},{"line_number":132,"context_line":"                    \u0027(which is dependent on conn_type)\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FXyE%3D","line":129,"updated":"2013-11-08 01:58:28.000000000","message":"possibly expand this to connection_uri?","commit_id":"e7ba910b04297f312f51ec22639e39ac7f39d790"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"181dc6d091e0851a2a5c8dcd351d9914f5142adf","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                    \u0027kvm, lxc, qemu, uml, xen)\u0027,"},{"line_number":127,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":128,"context_line":"               deprecated_name\u003d\u0027libvirt_type\u0027),"},{"line_number":129,"context_line":"    cfg.StrOpt(\u0027conn_uri\u0027,"},{"line_number":130,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":131,"context_line":"               help\u003d\u0027Override the default libvirt URI \u0027"},{"line_number":132,"context_line":"                    \u0027(which is dependent on conn_type)\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FXo4%3D","line":129,"in_reply_to":"AAAATn%2F%2FXyE%3D","updated":"2013-11-08 03:25:28.000000000","message":"Done","commit_id":"e7ba910b04297f312f51ec22639e39ac7f39d790"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"551d89c37d631336f35f7c5f71b25402d5165ad3","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                    \u0027kvm, lxc, qemu, uml, xen)\u0027,"},{"line_number":127,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":128,"context_line":"               deprecated_name\u003d\u0027libvirt_type\u0027),"},{"line_number":129,"context_line":"    cfg.StrOpt(\u0027conn_uri\u0027,"},{"line_number":130,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":131,"context_line":"               help\u003d\u0027Override the default libvirt URI \u0027"},{"line_number":132,"context_line":"                    \u0027(which is dependent on conn_type)\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FXX0%3D","line":129,"in_reply_to":"AAAATn%2F%2FXyE%3D","updated":"2013-11-08 05:56:15.000000000","message":"Meh, overly verbose IMHO.","commit_id":"e7ba910b04297f312f51ec22639e39ac7f39d790"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"058ab6846bfb80153d81b928e82bd92c7c8168fd","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    cfg.StrOpt(\u0027cpu_model\u0027,"},{"line_number":236,"context_line":"               help\u003d\u0027Set to a named libvirt CPU model (see names listed \u0027"},{"line_number":237,"context_line":"                    \u0027in /usr/share/libvirt/cpu_map.xml). Only has effect if \u0027"},{"line_number":238,"context_line":"                    \u0027libvirt_cpu_mode\u003d\"custom\" and driver_type\u003d\"kvm|qemu\"\u0027,"},{"line_number":239,"context_line":"               deprecated_name\u003d\u0027libvirt_cpu_model\u0027,"},{"line_number":240,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":241,"context_line":"    cfg.StrOpt(\u0027snapshots_directory\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FQOw%3D","line":238,"updated":"2013-11-12 08:13:58.000000000","message":"it should be \u0027cpu_mode\u003d\"custom\" and driver_type\u003d\"kvm|qemu\"\u0027","commit_id":"c5da080a29b3cb41fb8379598c8549c437ace415"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"20730f86172656e20d8e87f9364bdff8b455f011","unresolved":false,"context_lines":[{"line_number":235,"context_line":"    cfg.StrOpt(\u0027cpu_model\u0027,"},{"line_number":236,"context_line":"               help\u003d\u0027Set to a named libvirt CPU model (see names listed \u0027"},{"line_number":237,"context_line":"                    \u0027in /usr/share/libvirt/cpu_map.xml). Only has effect if \u0027"},{"line_number":238,"context_line":"                    \u0027libvirt_cpu_mode\u003d\"custom\" and driver_type\u003d\"kvm|qemu\"\u0027,"},{"line_number":239,"context_line":"               deprecated_name\u003d\u0027libvirt_cpu_model\u0027,"},{"line_number":240,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027),"},{"line_number":241,"context_line":"    cfg.StrOpt(\u0027snapshots_directory\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2FPpM%3D","line":238,"in_reply_to":"AAAATn%2F%2FQOw%3D","updated":"2013-11-12 11:01:37.000000000","message":"Done","commit_id":"c5da080a29b3cb41fb8379598c8549c437ace415"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"625043bcdf0a4b88e731f10a3f8260a095cda81f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"               help\u003d\u0027Libvirt domain type (valid options are: \u0027"},{"line_number":127,"context_line":"                    \u0027kvm, lxc, qemu, uml, xen)\u0027,"},{"line_number":128,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":129,"context_line":"               deprecated_name\u003d\u0027libvirt_type\u0027),"},{"line_number":130,"context_line":"    cfg.StrOpt(\u0027connection_uri\u0027,"},{"line_number":131,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":132,"context_line":"               help\u003d\u0027Override the default libvirt URI \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FHD8%3D","line":129,"updated":"2013-11-14 10:19:38.000000000","message":"I\u0027m actually thinking we should change this name again.\n\nIn libvirt you have a driver type (QEMU, Xen, XenAPI, XenLight, LXC, and so on) which is associated with a connection URI\n\nEach driver can handle multiple virtualization types. eg the QEMU driver type can handle QEMU and KVM virtualization types. And different driver types can handle the same virtualization type (eg Xen, XenLight and XenAPI can all handle Xen virtualization).\n\nSo what we\u0027re configuring here is actually the virtualization type - the driver type is being implied indirectly.\n\nSee also this bug https://bugs.launchpad.net/openstack-manuals/+bug/1195361\n\n\nSo I\u0027d like this to be called \u0027virt_type\u0027 instead of \u0027driver_type\u0027 to make the distinction between virtualization type and libvirt driver types clearer","commit_id":"0599fadddebe6c48d5c3ea90e3b81b790b855947"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"50331414bbd7d5f6b0c341d49e2c3c85e8404d7f","unresolved":false,"context_lines":[{"line_number":126,"context_line":"               help\u003d\u0027Libvirt domain type (valid options are: \u0027"},{"line_number":127,"context_line":"                    \u0027kvm, lxc, qemu, uml, xen)\u0027,"},{"line_number":128,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":129,"context_line":"               deprecated_name\u003d\u0027libvirt_type\u0027),"},{"line_number":130,"context_line":"    cfg.StrOpt(\u0027connection_uri\u0027,"},{"line_number":131,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":132,"context_line":"               help\u003d\u0027Override the default libvirt URI \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FEPg%3D","line":129,"in_reply_to":"AAAATn%2F%2FHD8%3D","updated":"2013-11-14 22:06:30.000000000","message":"Done","commit_id":"0599fadddebe6c48d5c3ea90e3b81b790b855947"}]}