)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a4b5e9e1180b366df14fa6f7d1037dd741d7690a","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"            context, filters, sort_key\u003dsort_key, sort_dir\u003dsort_dir,"},{"line_number":1247,"context_line":"            limit\u003dlimit, marker\u003dmarker, expected_attrs\u003dexpected_attrs,"},{"line_number":1248,"context_line":"            use_slave\u003duse_slave, sort_keys\u003dsort_keys, sort_dirs\u003dsort_dirs)"},{"line_number":1249,"context_line":"        # NOTE(melwitt): _make_instance_list will result in objects\u0027"},{"line_number":1250,"context_line":"        # _from_db_object methods being called, each of which might choose to"},{"line_number":1251,"context_line":"        # perform database writes. So, we call this outside of"},{"line_number":1252,"context_line":"        # _get_by_filters_impl to avoid being nested inside a \u0027reader\u0027 database"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_8bddab71","line":1249,"range":{"start_line":1249,"start_character":66,"end_line":1249,"end_character":68},"updated":"2018-03-23 01:17:17.000000000","message":"?","commit_id":"fdae41aa59aabb5a9cc36880dcab24e6f6b7e096"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9f8fd148f30d3b2f8183e66198996387a69e3fe3","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"            context, filters, sort_key\u003dsort_key, sort_dir\u003dsort_dir,"},{"line_number":1247,"context_line":"            limit\u003dlimit, marker\u003dmarker, expected_attrs\u003dexpected_attrs,"},{"line_number":1248,"context_line":"            use_slave\u003duse_slave, sort_keys\u003dsort_keys, sort_dirs\u003dsort_dirs)"},{"line_number":1249,"context_line":"        # NOTE(melwitt): _make_instance_list will result in objects\u0027"},{"line_number":1250,"context_line":"        # _from_db_object methods being called, each of which might choose to"},{"line_number":1251,"context_line":"        # perform database writes. So, we call this outside of"},{"line_number":1252,"context_line":"        # _get_by_filters_impl to avoid being nested inside a \u0027reader\u0027 database"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_a7ef14e8","line":1249,"range":{"start_line":1249,"start_character":66,"end_line":1249,"end_character":68},"in_reply_to":"df7087c5_4e9b0ec8","updated":"2018-03-23 19:02:37.000000000","message":"I understand the bug, I\u0027m just failing to parse this sentence.","commit_id":"fdae41aa59aabb5a9cc36880dcab24e6f6b7e096"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"713e425d523429485245f3c7d0ecc89f78a14efa","unresolved":false,"context_lines":[{"line_number":1246,"context_line":"            context, filters, sort_key\u003dsort_key, sort_dir\u003dsort_dir,"},{"line_number":1247,"context_line":"            limit\u003dlimit, marker\u003dmarker, expected_attrs\u003dexpected_attrs,"},{"line_number":1248,"context_line":"            use_slave\u003duse_slave, sort_keys\u003dsort_keys, sort_dirs\u003dsort_dirs)"},{"line_number":1249,"context_line":"        # NOTE(melwitt): _make_instance_list will result in objects\u0027"},{"line_number":1250,"context_line":"        # _from_db_object methods being called, each of which might choose to"},{"line_number":1251,"context_line":"        # perform database writes. So, we call this outside of"},{"line_number":1252,"context_line":"        # _get_by_filters_impl to avoid being nested inside a \u0027reader\u0027 database"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_4e9b0ec8","line":1249,"range":{"start_line":1249,"start_character":66,"end_line":1249,"end_character":68},"in_reply_to":"df7087c5_8bddab71","updated":"2018-03-23 15:14:15.000000000","message":"It will call joined other objects\u0027 _from_db_object methods, like the bug example is Service._from_db_object","commit_id":"fdae41aa59aabb5a9cc36880dcab24e6f6b7e096"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0a654c0b662eda07075e0c93e8d6b330d83e385d","unresolved":false,"context_lines":[{"line_number":1235,"context_line":"            db_inst_list \u003d db.instance_get_all_by_filters("},{"line_number":1236,"context_line":"                context, filters, sort_key, sort_dir, limit\u003dlimit,"},{"line_number":1237,"context_line":"                marker\u003dmarker, columns_to_join\u003d_expected_cols(expected_attrs))"},{"line_number":1238,"context_line":"        return _make_instance_list(context, cls(), db_inst_list,"},{"line_number":1239,"context_line":"                                   expected_attrs)"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_b262f0d7","side":"PARENT","line":1238,"updated":"2018-03-23 19:41:37.000000000","message":"Yeah this was dumb. It would be like returning an object from nova/db/sqlalchemy/api.py. I hope I didn\u0027t do this. I won\u0027t look to see.","commit_id":"464985a4d58f45ee6a5e8f8705cdcdddcd365038"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0a654c0b662eda07075e0c93e8d6b330d83e385d","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"        # database writes. So, we call this outside of _get_by_filters_impl to"},{"line_number":1253,"context_line":"        # avoid being nested inside a \u0027reader\u0027 database transaction context."},{"line_number":1254,"context_line":"        return _make_instance_list(context, cls(), db_inst_list,"},{"line_number":1255,"context_line":"                                   expected_attrs)"},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"    @staticmethod"},{"line_number":1258,"context_line":"    @db.select_db_reader_mode"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_32a4a008","line":1255,"updated":"2018-03-23 19:41:37.000000000","message":"This is the pattern anyway, I dunno why that one was done differently, so it\u0027s almost weird to have this comment.","commit_id":"b1ed92c7af01a9ac7e122a541ce1bdb9be0524c4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"519c0ea67000102f86c7f88a1db4796d1f706b32","unresolved":false,"context_lines":[{"line_number":1252,"context_line":"        # database writes. So, we call this outside of _get_by_filters_impl to"},{"line_number":1253,"context_line":"        # avoid being nested inside a \u0027reader\u0027 database transaction context."},{"line_number":1254,"context_line":"        return _make_instance_list(context, cls(), db_inst_list,"},{"line_number":1255,"context_line":"                                   expected_attrs)"},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"    @staticmethod"},{"line_number":1258,"context_line":"    @db.select_db_reader_mode"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_f25e2844","line":1255,"in_reply_to":"bf659307_32a4a008","updated":"2018-03-23 20:11:54.000000000","message":"Yeah, I thought similar and was torn about it because as you said, it was the oddball in the file.\n\nBut I went ahead and erred on the side of caution, in case someone else comes in to make a change in this file in the future, maybe this heads up will help avoid issues.","commit_id":"b1ed92c7af01a9ac7e122a541ce1bdb9be0524c4"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0a654c0b662eda07075e0c93e8d6b330d83e385d","unresolved":false,"context_lines":[{"line_number":1266,"context_line":"        db_inst_list \u003d cls._db_instance_get_all_by_host("},{"line_number":1267,"context_line":"            context, host, columns_to_join\u003d_expected_cols(expected_attrs),"},{"line_number":1268,"context_line":"            use_slave\u003duse_slave)"},{"line_number":1269,"context_line":"        return _make_instance_list(context, cls(), db_inst_list,"},{"line_number":1270,"context_line":"                                   expected_attrs)"},{"line_number":1271,"context_line":""},{"line_number":1272,"context_line":"    @base.remotable_classmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_52a914dd","line":1269,"updated":"2018-03-23 19:41:37.000000000","message":"example ^","commit_id":"b1ed92c7af01a9ac7e122a541ce1bdb9be0524c4"}],"nova/tests/functional/regressions/test_bug_1746509.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a4b5e9e1180b366df14fa6f7d1037dd741d7690a","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        insts \u003d objects.InstanceList.get_by_filters("},{"line_number":59,"context_line":"            self.context, {}, expected_attrs\u003d[\u0027services\u0027])"},{"line_number":60,"context_line":"        self.assertEqual(1, len(insts))"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_ebcd47b7","line":60,"updated":"2018-03-23 01:17:17.000000000","message":"Could you also pull the service off the instance and assert the uuid is set?","commit_id":"fdae41aa59aabb5a9cc36880dcab24e6f6b7e096"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"713e425d523429485245f3c7d0ecc89f78a14efa","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        insts \u003d objects.InstanceList.get_by_filters("},{"line_number":59,"context_line":"            self.context, {}, expected_attrs\u003d[\u0027services\u0027])"},{"line_number":60,"context_line":"        self.assertEqual(1, len(insts))"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_2ea6da10","line":60,"in_reply_to":"df7087c5_ebcd47b7","updated":"2018-03-23 15:14:15.000000000","message":"Sure","commit_id":"fdae41aa59aabb5a9cc36880dcab24e6f6b7e096"}]}