)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"851f7640bd190dc0de49b522e7032c8c9d49db9a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"https://github.com/openstack/nova/blob/ef6f4e4c8ec82e2c9f9988fe2e04591ee01220e6/nova/api/openstack/auth.py#L56"},{"line_number":11,"context_line":"as the openstack.request_id from req.environ, previously created in:"},{"line_number":12,"context_line":"https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/request_id.py#L57"},{"line_number":13,"context_line":"was not included in the initialize of the context obj, nova will generate"},{"line_number":14,"context_line":"a new request_id for context obj."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"As the req.environ[\u0027openstack.request_id\u0027] will latter returned to user as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_a098336a","line":13,"range":{"start_line":13,"start_character":55,"end_line":13,"end_character":59},"updated":"2018-03-26 13:51:36.000000000","message":"nit: actually it is the oslo_context.context.Context.__init__ that will generate a new request_id if not provided.","commit_id":"cd4778a5f450699df4e5d191bf5ba9f344bd5b9b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e4fa1de956123e925467f9472b01b37e6469dd06","unresolved":false,"context_lines":[{"line_number":14,"context_line":"oslo_context.context.Context.__init__ will generate a new request_id for"},{"line_number":15,"context_line":"context obj."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"As the req.environ[\u0027openstack.request_id\u0027] will latter returned to user as"},{"line_number":18,"context_line":"the \u0027x-openstack-request-id\u0027"},{"line_number":19,"context_line":"field in the response header, users may use this for searching etc. But"},{"line_number":20,"context_line":"the latter Nova workflow will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bf659307_cc726f4a","line":17,"range":{"start_line":17,"start_character":48,"end_line":17,"end_character":54},"updated":"2018-04-04 18:15:14.000000000","message":"later be returned?","commit_id":"b479de9c4777301aa8292fdabbafa591b2260195"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e4fa1de956123e925467f9472b01b37e6469dd06","unresolved":false,"context_lines":[{"line_number":17,"context_line":"As the req.environ[\u0027openstack.request_id\u0027] will latter returned to user as"},{"line_number":18,"context_line":"the \u0027x-openstack-request-id\u0027"},{"line_number":19,"context_line":"field in the response header, users may use this for searching etc. But"},{"line_number":20,"context_line":"the latter Nova workflow will"},{"line_number":21,"context_line":"all use the context.request_id, which will lead to an inconsistency"},{"line_number":22,"context_line":"problem."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bf659307_8c92374b","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":10},"updated":"2018-04-04 18:15:14.000000000","message":"s/latter//","commit_id":"b479de9c4777301aa8292fdabbafa591b2260195"}],"nova/api/openstack/auth.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"851f7640bd190dc0de49b522e7032c8c9d49db9a","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        req.environ[\u0027nova.context\u0027] \u003d ctx"},{"line_number":62,"context_line":"        return self.application"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class NoAuthMiddleware(NoAuthMiddlewareBase):"},{"line_number":66,"context_line":"    \"\"\"Return a fake token if one isn\u0027t specified."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_20dae316","line":63,"updated":"2018-03-26 13:51:36.000000000","message":"I suggest to add a unit test to cover this.","commit_id":"cd4778a5f450699df4e5d191bf5ba9f344bd5b9b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e4fa1de956123e925467f9472b01b37e6469dd06","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        ctx \u003d context.RequestContext("},{"line_number":57,"context_line":"            user_id, project_id, is_admin\u003dis_admin,"},{"line_number":58,"context_line":"            remote_address\u003dremote_address,"},{"line_number":59,"context_line":"            request_id\u003dreq.environ.get(\u0027openstack.request_id\u0027))"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        req.environ[\u0027nova.context\u0027] \u003d ctx"},{"line_number":62,"context_line":"        return self.application"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_4ceadfac","line":59,"range":{"start_line":59,"start_character":40,"end_line":59,"end_character":60},"updated":"2018-04-04 18:15:14.000000000","message":"Can we re-use the constant defined in the oslo.middlware library?\n\nhttps://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/request_id.py#L24","commit_id":"b479de9c4777301aa8292fdabbafa591b2260195"}]}