)]}'
{"doc/source/cli/nova-manage.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bf7d965dc6387c86c7849ab207c87c1d454ee02d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    transport_url or/and database_connection is/are same as another cell,"},{"line_number":243,"context_line":"    this command will return an exit code of 3. If the properties cannot be set,"},{"line_number":244,"context_line":"    this will return 2. If an attempt is made to disable and enable a cell at the"},{"line_number":245,"context_line":"    same time, this command will return an exit code of 4. If an attempt is made"},{"line_number":246,"context_line":"    to disable or enable cell0 this command will return an exit code of 5."},{"line_number":247,"context_line":"    Otherwise, the exit code will be 0."},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    .. note::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_dc7ff463","line":246,"range":{"start_line":245,"start_character":59,"end_line":246,"end_character":73},"updated":"2018-03-22 20:23:52.000000000","message":"Oooh, nice :)","commit_id":"b6a96ea9a6268bd58a31e5e22d69c8e61f32fed8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bf7d965dc6387c86c7849ab207c87c1d454ee02d","unresolved":false,"context_lines":[{"line_number":252,"context_line":"      running system will NOT result in all nodes immediately using the new"},{"line_number":253,"context_line":"      values.  Use caution when changing these values."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"      Enabling or disabling a cell needs to be followed up by a SIGHUP signal"},{"line_number":256,"context_line":"      to the scheduler so that the global cache of enabled cell list is refreshed"},{"line_number":257,"context_line":"      to accommodate the new changes."},{"line_number":258,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_1cd80c79","line":255,"range":{"start_line":255,"start_character":64,"end_line":255,"end_character":77},"updated":"2018-03-22 20:23:52.000000000","message":"...or service restart.\n\nYou might also word this differently, like \"The scheduler will not notice that a cell has been en/disabled until it is restarted or sent the SIGHUP signal.\"\n\nJust because you could not care a whole lot or something. What you have here sounds almost like something might break if they don\u0027t SIGHUP the scheduler immediately.","commit_id":"b6a96ea9a6268bd58a31e5e22d69c8e61f32fed8"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"000d483ea68c4dc450aef866ae258b225c76f83f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"      running system will NOT result in all nodes immediately using the new"},{"line_number":253,"context_line":"      values.  Use caution when changing these values."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"      Enabling or disabling a cell needs to be followed up by a SIGHUP signal"},{"line_number":256,"context_line":"      to the scheduler so that the global cache of enabled cell list is refreshed"},{"line_number":257,"context_line":"      to accommodate the new changes."},{"line_number":258,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_74c7ca13","line":255,"range":{"start_line":255,"start_character":64,"end_line":255,"end_character":77},"in_reply_to":"df7087c5_1cd80c79","updated":"2018-03-23 14:18:53.000000000","message":"\u003e ...or service restart.\n \u003e \n \u003e You might also word this differently, like \"The scheduler will not\n \u003e notice that a cell has been en/disabled until it is restarted or\n \u003e sent the SIGHUP signal.\"\n\nDone.\n\n \u003e \n \u003e Just because you could not care a whole lot or something. What you\n \u003e have here sounds almost like something might break if they don\u0027t\n \u003e SIGHUP the scheduler immediately.\n\nhehe, agreed when I re-read this.","commit_id":"b6a96ea9a6268bd58a31e5e22d69c8e61f32fed8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bf7d965dc6387c86c7849ab207c87c1d454ee02d","unresolved":false,"context_lines":[{"line_number":253,"context_line":"      values.  Use caution when changing these values."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"      Enabling or disabling a cell needs to be followed up by a SIGHUP signal"},{"line_number":256,"context_line":"      to the scheduler so that the global cache of enabled cell list is refreshed"},{"line_number":257,"context_line":"      to accommodate the new changes."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"``nova-manage cell_v2 delete_host --cell_uuid \u003ccell_uuid\u003e --host \u003chost\u003e``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_bc3d608f","line":256,"range":{"start_line":256,"start_character":31,"end_line":256,"end_character":47},"updated":"2018-03-22 20:23:52.000000000","message":"\"its cached list\"\n\nIt\u0027s global in the scheduler code, but that\u0027s probably lost on sysadmin, and this kinda sounds like the scheduler is responsible for maintaining a centralized list or something. The global-ness of the way we do the cache in the scheduler is just an implementation detail.","commit_id":"b6a96ea9a6268bd58a31e5e22d69c8e61f32fed8"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"000d483ea68c4dc450aef866ae258b225c76f83f","unresolved":false,"context_lines":[{"line_number":253,"context_line":"      values.  Use caution when changing these values."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"      Enabling or disabling a cell needs to be followed up by a SIGHUP signal"},{"line_number":256,"context_line":"      to the scheduler so that the global cache of enabled cell list is refreshed"},{"line_number":257,"context_line":"      to accommodate the new changes."},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"``nova-manage cell_v2 delete_host --cell_uuid \u003ccell_uuid\u003e --host \u003chost\u003e``"}],"source_content_type":"text/x-rst","patch_set":1,"id":"df7087c5_f403da40","line":256,"range":{"start_line":256,"start_character":31,"end_line":256,"end_character":47},"in_reply_to":"df7087c5_bc3d608f","updated":"2018-03-23 14:18:53.000000000","message":"woot! I will go with your line \"The scheduler...\"","commit_id":"b6a96ea9a6268bd58a31e5e22d69c8e61f32fed8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    of 1. Otherwise, the exit code will be 0."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"``nova-manage cell_v2 update_cell --cell_uuid \u003ccell_uuid\u003e [--name \u003ccell_name\u003e] [--transport-url \u003ctransport_url\u003e] [--database_connection \u003cdatabase_connection\u003e] [--disable] [--enable]``"},{"line_number":241,"context_line":"    Updates the properties of, enables or disables a cell by the given uuid. If a"},{"line_number":242,"context_line":"    database_connection is not specified, it will attempt to use the one"},{"line_number":243,"context_line":"    defined by ``[database]/connection`` in the configuration file.  If a"},{"line_number":244,"context_line":"    transport_url is not specified, it will attempt to use the one defined by"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf659307_2ab56f7e","line":241,"range":{"start_line":241,"start_character":29,"end_line":241,"end_character":50},"updated":"2018-03-29 22:45:30.000000000","message":"This makes this sentence sound weird. The disabled flag is a property, so just leaving the sentence as it was would be fine IMO.","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    of 1. Otherwise, the exit code will be 0."},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"``nova-manage cell_v2 update_cell --cell_uuid \u003ccell_uuid\u003e [--name \u003ccell_name\u003e] [--transport-url \u003ctransport_url\u003e] [--database_connection \u003cdatabase_connection\u003e] [--disable] [--enable]``"},{"line_number":241,"context_line":"    Updates the properties of, enables or disables a cell by the given uuid. If a"},{"line_number":242,"context_line":"    database_connection is not specified, it will attempt to use the one"},{"line_number":243,"context_line":"    defined by ``[database]/connection`` in the configuration file.  If a"},{"line_number":244,"context_line":"    transport_url is not specified, it will attempt to use the one defined by"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf659307_6cea6ed8","line":241,"range":{"start_line":241,"start_character":29,"end_line":241,"end_character":50},"in_reply_to":"bf659307_2ab56f7e","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    found by uuid, this command will return an exit code of 1. If the provided"},{"line_number":247,"context_line":"    transport_url or/and database_connection is/are same as another cell,"},{"line_number":248,"context_line":"    this command will return an exit code of 3. If the properties cannot be set,"},{"line_number":249,"context_line":"    this will return 2. If an attempt is made to disable and enable a cell at the"},{"line_number":250,"context_line":"    same time, this command will return an exit code of 4. If an attempt is made"},{"line_number":251,"context_line":"    to disable or enable cell0 this command will return an exit code of 5."},{"line_number":252,"context_line":"    Otherwise, the exit code will be 0."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    .. note::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf659307_4a6f83fb","line":251,"range":{"start_line":249,"start_character":24,"end_line":251,"end_character":74},"updated":"2018-03-29 22:45:30.000000000","message":"Again, we really need a patch at some point, after this series is OK, but we need to re-format this mega block of prose and call out the exit codes in a list format.","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    found by uuid, this command will return an exit code of 1. If the provided"},{"line_number":247,"context_line":"    transport_url or/and database_connection is/are same as another cell,"},{"line_number":248,"context_line":"    this command will return an exit code of 3. If the properties cannot be set,"},{"line_number":249,"context_line":"    this will return 2. If an attempt is made to disable and enable a cell at the"},{"line_number":250,"context_line":"    same time, this command will return an exit code of 4. If an attempt is made"},{"line_number":251,"context_line":"    to disable or enable cell0 this command will return an exit code of 5."},{"line_number":252,"context_line":"    Otherwise, the exit code will be 0."},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    .. note::"}],"source_content_type":"text/x-rst","patch_set":9,"id":"bf659307_2c31d65a","line":251,"range":{"start_line":249,"start_character":24,"end_line":251,"end_character":74},"in_reply_to":"bf659307_4a6f83fb","updated":"2018-04-03 09:43:51.000000000","message":"\u003e Again, we really need a patch at some point, after this series is\n \u003e OK, but we need to re-format this mega block of prose and call out\n \u003e the exit codes in a list format.\n\nWill do a clean up patch for this after the series.","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"}],"nova/cmd/manage.py":[{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"feca650b071f0928548b827f9e75d4ac0cbdcdea","unresolved":false,"context_lines":[{"line_number":1540,"context_line":"        if name:"},{"line_number":1541,"context_line":"            cell_mapping.name \u003d name"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":"        transport_url \u003d transport_url or CONF.transport_url"},{"line_number":1544,"context_line":"        db_connection \u003d db_connection or CONF.database.connection"},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"        if (self._non_unique_transport_url_database_connection_checker(ctxt,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_6e6a1781","line":1543,"updated":"2018-03-26 08:43:09.000000000","message":"The slight problem with using the update_cell command is that even if we are only updating the name of the cell/enabling/disabling the particular cell, the transport url and database connection will also be set again by taking this info from the config file.","commit_id":"a731ea4560833fac35d86e6f3be72f40fd4a26e8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":1542,"context_line":"          help\u003d_(\u0027Set the cell database_connection. NOTE that running nodes \u0027"},{"line_number":1543,"context_line":"                 \u0027will not see the change until restart!\u0027))"},{"line_number":1544,"context_line":"    @args(\u0027--disable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027disable\u0027,"},{"line_number":1545,"context_line":"          help\u003d_(\u0027Disables the cell. NOTE that the scheduling will be blocked \u0027"},{"line_number":1546,"context_line":"                 \u0027to this cell until its enabled\u0027))"},{"line_number":1547,"context_line":"    @args(\u0027--enable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027enable\u0027,"},{"line_number":1548,"context_line":"          help\u003d_(\u0027Enables the cell. NOTE that the scheduling will be \u0027"},{"line_number":1549,"context_line":"                 \u0027unblocked to this cell until its disabled\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_8a527b3a","line":1546,"range":{"start_line":1545,"start_character":37,"end_line":1546,"end_character":48},"updated":"2018-03-29 22:45:30.000000000","message":"Yeah, but not until you SIGHUP or restart nova-scheduler to refresh the cache. But we don\u0027t need to mention that here.","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":1542,"context_line":"          help\u003d_(\u0027Set the cell database_connection. NOTE that running nodes \u0027"},{"line_number":1543,"context_line":"                 \u0027will not see the change until restart!\u0027))"},{"line_number":1544,"context_line":"    @args(\u0027--disable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027disable\u0027,"},{"line_number":1545,"context_line":"          help\u003d_(\u0027Disables the cell. NOTE that the scheduling will be blocked \u0027"},{"line_number":1546,"context_line":"                 \u0027to this cell until its enabled\u0027))"},{"line_number":1547,"context_line":"    @args(\u0027--enable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027enable\u0027,"},{"line_number":1548,"context_line":"          help\u003d_(\u0027Enables the cell. NOTE that the scheduling will be \u0027"},{"line_number":1549,"context_line":"                 \u0027unblocked to this cell until its disabled\u0027))"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_2cc476f4","line":1546,"range":{"start_line":1545,"start_character":37,"end_line":1546,"end_character":48},"in_reply_to":"bf659307_8a527b3a","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"          help\u003d_(\u0027Disables the cell. NOTE that the scheduling will be blocked \u0027"},{"line_number":1546,"context_line":"                 \u0027to this cell until its enabled\u0027))"},{"line_number":1547,"context_line":"    @args(\u0027--enable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027enable\u0027,"},{"line_number":1548,"context_line":"          help\u003d_(\u0027Enables the cell. NOTE that the scheduling will be \u0027"},{"line_number":1549,"context_line":"                 \u0027unblocked to this cell until its disabled\u0027))"},{"line_number":1550,"context_line":"    def update_cell(self, cell_uuid, name\u003dNone, transport_url\u003dNone,"},{"line_number":1551,"context_line":"                    db_connection\u003dNone, disable\u003dFalse, enable\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_4a48e385","line":1548,"range":{"start_line":1548,"start_character":36,"end_line":1548,"end_character":40},"updated":"2018-03-29 22:45:30.000000000","message":"s/NOTE/Note/","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"          help\u003d_(\u0027Disables the cell. NOTE that the scheduling will be blocked \u0027"},{"line_number":1546,"context_line":"                 \u0027to this cell until its enabled\u0027))"},{"line_number":1547,"context_line":"    @args(\u0027--enable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027enable\u0027,"},{"line_number":1548,"context_line":"          help\u003d_(\u0027Enables the cell. NOTE that the scheduling will be \u0027"},{"line_number":1549,"context_line":"                 \u0027unblocked to this cell until its disabled\u0027))"},{"line_number":1550,"context_line":"    def update_cell(self, cell_uuid, name\u003dNone, transport_url\u003dNone,"},{"line_number":1551,"context_line":"                    db_connection\u003dNone, disable\u003dFalse, enable\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_ccb61a8b","line":1548,"range":{"start_line":1548,"start_character":36,"end_line":1548,"end_character":40},"in_reply_to":"bf659307_4a48e385","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":1546,"context_line":"                 \u0027to this cell until its enabled\u0027))"},{"line_number":1547,"context_line":"    @args(\u0027--enable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027enable\u0027,"},{"line_number":1548,"context_line":"          help\u003d_(\u0027Enables the cell. NOTE that the scheduling will be \u0027"},{"line_number":1549,"context_line":"                 \u0027unblocked to this cell until its disabled\u0027))"},{"line_number":1550,"context_line":"    def update_cell(self, cell_uuid, name\u003dNone, transport_url\u003dNone,"},{"line_number":1551,"context_line":"                    db_connection\u003dNone, disable\u003dFalse, enable\u003dFalse):"},{"line_number":1552,"context_line":"        \"\"\"Updates the properties of a cell by the given uuid."}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_2a380fec","line":1549,"range":{"start_line":1549,"start_character":18,"end_line":1549,"end_character":59},"updated":"2018-03-29 22:45:30.000000000","message":"This is kind of odd to say. I would think disabled cells are the exceptional case, and aren\u0027t the default, so it might just be better to say something like, \"This makes a disabled cell available for scheduling after a SIGHUP of the nova-scheduler service.\"","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":1546,"context_line":"                 \u0027to this cell until its enabled\u0027))"},{"line_number":1547,"context_line":"    @args(\u0027--enable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027enable\u0027,"},{"line_number":1548,"context_line":"          help\u003d_(\u0027Enables the cell. NOTE that the scheduling will be \u0027"},{"line_number":1549,"context_line":"                 \u0027unblocked to this cell until its disabled\u0027))"},{"line_number":1550,"context_line":"    def update_cell(self, cell_uuid, name\u003dNone, transport_url\u003dNone,"},{"line_number":1551,"context_line":"                    db_connection\u003dNone, disable\u003dFalse, enable\u003dFalse):"},{"line_number":1552,"context_line":"        \"\"\"Updates the properties of a cell by the given uuid."}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_ecb99e78","line":1549,"range":{"start_line":1549,"start_character":18,"end_line":1549,"end_character":59},"in_reply_to":"bf659307_2a380fec","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"            return 4"},{"line_number":1597,"context_line":"        if disable or enable:"},{"line_number":1598,"context_line":"            if cell_mapping.is_cell0():"},{"line_number":1599,"context_line":"                print(_(\u0027Cell 0 cannot be disabled and it is always enabled \u0027"},{"line_number":1600,"context_line":"                        \u0027by default\u0027))"},{"line_number":1601,"context_line":"                return 5"},{"line_number":1602,"context_line":"            elif disable and not cell_mapping.disabled:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_8d05b513","line":1599,"range":{"start_line":1599,"start_character":25,"end_line":1599,"end_character":31},"updated":"2018-03-29 22:45:30.000000000","message":"\u0027Cell0\u0027 I think - I\u0027ve never seen it referred to as \u0027Cell 0\u0027.","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"            return 4"},{"line_number":1597,"context_line":"        if disable or enable:"},{"line_number":1598,"context_line":"            if cell_mapping.is_cell0():"},{"line_number":1599,"context_line":"                print(_(\u0027Cell 0 cannot be disabled and it is always enabled \u0027"},{"line_number":1600,"context_line":"                        \u0027by default\u0027))"},{"line_number":1601,"context_line":"                return 5"},{"line_number":1602,"context_line":"            elif disable and not cell_mapping.disabled:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_4caa0a19","line":1599,"range":{"start_line":1599,"start_character":25,"end_line":1599,"end_character":31},"in_reply_to":"bf659307_8d05b513","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"            return 4"},{"line_number":1597,"context_line":"        if disable or enable:"},{"line_number":1598,"context_line":"            if cell_mapping.is_cell0():"},{"line_number":1599,"context_line":"                print(_(\u0027Cell 0 cannot be disabled and it is always enabled \u0027"},{"line_number":1600,"context_line":"                        \u0027by default\u0027))"},{"line_number":1601,"context_line":"                return 5"},{"line_number":1602,"context_line":"            elif disable and not cell_mapping.disabled:"},{"line_number":1603,"context_line":"                cell_mapping.disabled \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_6a1b6780","line":1600,"range":{"start_line":1599,"start_character":50,"end_line":1600,"end_character":35},"updated":"2018-03-29 22:45:30.000000000","message":"remove this part, saying cell0 can\u0027t be disabled is enough","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"            return 4"},{"line_number":1597,"context_line":"        if disable or enable:"},{"line_number":1598,"context_line":"            if cell_mapping.is_cell0():"},{"line_number":1599,"context_line":"                print(_(\u0027Cell 0 cannot be disabled and it is always enabled \u0027"},{"line_number":1600,"context_line":"                        \u0027by default\u0027))"},{"line_number":1601,"context_line":"                return 5"},{"line_number":1602,"context_line":"            elif disable and not cell_mapping.disabled:"},{"line_number":1603,"context_line":"                cell_mapping.disabled \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_6ca58e46","line":1600,"range":{"start_line":1599,"start_character":50,"end_line":1600,"end_character":35},"in_reply_to":"bf659307_6a1b6780","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"            elif enable and cell_mapping.disabled:"},{"line_number":1605,"context_line":"                cell_mapping.disabled \u003d False"},{"line_number":1606,"context_line":"            elif disable and cell_mapping.disabled:"},{"line_number":1607,"context_line":"                print(_(\u0027This cell with uuid %s is already disabled\u0027)"},{"line_number":1608,"context_line":"                        % cell_uuid)"},{"line_number":1609,"context_line":"            elif enable and not cell_mapping.disabled:"},{"line_number":1610,"context_line":"                print(_(\u0027This cell with uuid %s is already enabled\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_4a16a357","line":1607,"range":{"start_line":1607,"start_character":25,"end_line":1607,"end_character":67},"updated":"2018-03-29 22:45:30.000000000","message":"nit: this is overly verbose, just say:\n\n\"Cell %s is already disabled\" % cell_uuid","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"            elif enable and cell_mapping.disabled:"},{"line_number":1605,"context_line":"                cell_mapping.disabled \u003d False"},{"line_number":1606,"context_line":"            elif disable and cell_mapping.disabled:"},{"line_number":1607,"context_line":"                print(_(\u0027This cell with uuid %s is already disabled\u0027)"},{"line_number":1608,"context_line":"                        % cell_uuid)"},{"line_number":1609,"context_line":"            elif enable and not cell_mapping.disabled:"},{"line_number":1610,"context_line":"                print(_(\u0027This cell with uuid %s is already enabled\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_4c7f6aaa","line":1607,"range":{"start_line":1607,"start_character":25,"end_line":1607,"end_character":67},"in_reply_to":"bf659307_4a16a357","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"                print(_(\u0027This cell with uuid %s is already disabled\u0027)"},{"line_number":1608,"context_line":"                        % cell_uuid)"},{"line_number":1609,"context_line":"            elif enable and not cell_mapping.disabled:"},{"line_number":1610,"context_line":"                print(_(\u0027This cell with uuid %s is already enabled\u0027)"},{"line_number":1611,"context_line":"                        % cell_uuid)"},{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_ea0e9739","line":1610,"updated":"2018-03-29 22:45:30.000000000","message":"Same","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"                print(_(\u0027This cell with uuid %s is already disabled\u0027)"},{"line_number":1608,"context_line":"                        % cell_uuid)"},{"line_number":1609,"context_line":"            elif enable and not cell_mapping.disabled:"},{"line_number":1610,"context_line":"                print(_(\u0027This cell with uuid %s is already enabled\u0027)"},{"line_number":1611,"context_line":"                        % cell_uuid)"},{"line_number":1612,"context_line":""},{"line_number":1613,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_cc44da76","line":1610,"in_reply_to":"bf659307_ea0e9739","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6b44d325f8b526b4eee37ccd6c8e47262ab74e9f","unresolved":false,"context_lines":[{"line_number":1542,"context_line":"          help\u003d_(\u0027Set the cell database_connection. NOTE that running nodes \u0027"},{"line_number":1543,"context_line":"                 \u0027will not see the change until restart!\u0027))"},{"line_number":1544,"context_line":"    @args(\u0027--disable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027disable\u0027,"},{"line_number":1545,"context_line":"          help\u003d_(\u0027Disables the cell. NOTE that the scheduling will be blocked \u0027"},{"line_number":1546,"context_line":"                 \u0027to this cell until its enabled\u0027))"},{"line_number":1547,"context_line":"    @args(\u0027--enable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027enable\u0027,"},{"line_number":1548,"context_line":"          help\u003d_(\u0027Enables the cell. NOTE that the scheduling will be \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_01511063","line":1545,"range":{"start_line":1545,"start_character":37,"end_line":1545,"end_character":41},"updated":"2018-04-04 17:31:25.000000000","message":"s/NOTE/Note/","commit_id":"2a6cbd046fbe5c231276bd0487e3419f3d136862"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6b44d325f8b526b4eee37ccd6c8e47262ab74e9f","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"          help\u003d_(\u0027Disables the cell. NOTE that the scheduling will be blocked \u0027"},{"line_number":1546,"context_line":"                 \u0027to this cell until its enabled\u0027))"},{"line_number":1547,"context_line":"    @args(\u0027--enable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027enable\u0027,"},{"line_number":1548,"context_line":"          help\u003d_(\u0027Enables the cell. NOTE that the scheduling will be \u0027"},{"line_number":1549,"context_line":"                 \u0027unblocked to this cell until its disabled\u0027))"},{"line_number":1550,"context_line":"    def update_cell(self, cell_uuid, name\u003dNone, transport_url\u003dNone,"},{"line_number":1551,"context_line":"                    db_connection\u003dNone, disable\u003dFalse, enable\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_61c56c0a","line":1548,"range":{"start_line":1548,"start_character":36,"end_line":1548,"end_character":40},"updated":"2018-04-04 17:31:25.000000000","message":"Note","commit_id":"2a6cbd046fbe5c231276bd0487e3419f3d136862"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6b44d325f8b526b4eee37ccd6c8e47262ab74e9f","unresolved":false,"context_lines":[{"line_number":1546,"context_line":"                 \u0027to this cell until its enabled\u0027))"},{"line_number":1547,"context_line":"    @args(\u0027--enable\u0027, action\u003d\u0027store_true\u0027, dest\u003d\u0027enable\u0027,"},{"line_number":1548,"context_line":"          help\u003d_(\u0027Enables the cell. NOTE that the scheduling will be \u0027"},{"line_number":1549,"context_line":"                 \u0027unblocked to this cell until its disabled\u0027))"},{"line_number":1550,"context_line":"    def update_cell(self, cell_uuid, name\u003dNone, transport_url\u003dNone,"},{"line_number":1551,"context_line":"                    db_connection\u003dNone, disable\u003dFalse, enable\u003dFalse):"},{"line_number":1552,"context_line":"        \"\"\"Updates the properties of a cell by the given uuid."}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_81ca0018","line":1549,"range":{"start_line":1549,"start_character":18,"end_line":1549,"end_character":59},"updated":"2018-04-04 17:31:25.000000000","message":"Relaying from PS9:\n\n\u003e This is kind of odd to say. I would think disabled cells are the exceptional case, and aren\u0027t the default, so it might just be better to say something like, \"This makes a disabled cell available for scheduling after a SIGHUP of the nova-scheduler service.\"","commit_id":"2a6cbd046fbe5c231276bd0487e3419f3d136862"}],"nova/tests/unit/test_nova_manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"                            transport_url\u003d\u0027fake://mq\u0027,"},{"line_number":2095,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027).create()"},{"line_number":2096,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2097,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2098,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuid, disable\u003dTrue))"},{"line_number":2099,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2100,"context_line":"        self.assertIs(cm.disabled, True)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_cd164d4a","line":2097,"range":{"start_line":2097,"start_character":8,"end_line":2097,"end_character":41},"updated":"2018-03-29 22:45:30.000000000","message":"self.assertFalse(cm.disabled)","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":2094,"context_line":"                            transport_url\u003d\u0027fake://mq\u0027,"},{"line_number":2095,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027).create()"},{"line_number":2096,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2097,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2098,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuid, disable\u003dTrue))"},{"line_number":2099,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2100,"context_line":"        self.assertIs(cm.disabled, True)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_dfac7aa0","line":2097,"range":{"start_line":2097,"start_character":8,"end_line":2097,"end_character":41},"in_reply_to":"bf659307_cd164d4a","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":2097,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2098,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuid, disable\u003dTrue))"},{"line_number":2099,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2100,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2101,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":2102,"context_line":"        self.assertEqual(\u0027\u0027, output)"},{"line_number":2103,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_6d294188","line":2100,"updated":"2018-03-29 22:45:30.000000000","message":"assertTrue","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":2097,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2098,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuid, disable\u003dTrue))"},{"line_number":2099,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2100,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2101,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":2102,"context_line":"        self.assertEqual(\u0027\u0027, output)"},{"line_number":2103,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_ac0ba627","line":2100,"in_reply_to":"bf659307_6d294188","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":2110,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027,"},{"line_number":2111,"context_line":"                            disabled\u003dTrue).create()"},{"line_number":2112,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2113,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2114,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuid, enable\u003dTrue))"},{"line_number":2115,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2116,"context_line":"        self.assertIs(cm.disabled, False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_8d2e1590","line":2113,"updated":"2018-03-29 22:45:30.000000000","message":"assertTrue","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":2110,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027,"},{"line_number":2111,"context_line":"                            disabled\u003dTrue).create()"},{"line_number":2112,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2113,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2114,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuid, enable\u003dTrue))"},{"line_number":2115,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2116,"context_line":"        self.assertIs(cm.disabled, False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_df01da6b","line":2113,"in_reply_to":"bf659307_8d2e1590","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":2113,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2114,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuid, enable\u003dTrue))"},{"line_number":2115,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2116,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2117,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":2118,"context_line":"        self.assertEqual(\u0027\u0027, output)"},{"line_number":2119,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_2d1fc95b","line":2116,"updated":"2018-03-29 22:45:30.000000000","message":"assertFalse","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":2113,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2114,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuid, enable\u003dTrue))"},{"line_number":2115,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuid)"},{"line_number":2116,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2117,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":2118,"context_line":"        self.assertEqual(\u0027\u0027, output)"},{"line_number":2119,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_dfe8fab3","line":2116,"in_reply_to":"bf659307_2d1fc95b","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":2125,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027,"},{"line_number":2126,"context_line":"                            disabled\u003dTrue).create()"},{"line_number":2127,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuidsentinel.cell1)"},{"line_number":2128,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2129,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuidsentinel.cell1,"},{"line_number":2130,"context_line":"                                                      disable\u003dTrue))"},{"line_number":2131,"context_line":"        self.assertIs(cm.disabled, True)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_4d247daf","line":2128,"updated":"2018-03-29 22:45:30.000000000","message":"same","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":2125,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027,"},{"line_number":2126,"context_line":"                            disabled\u003dTrue).create()"},{"line_number":2127,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuidsentinel.cell1)"},{"line_number":2128,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2129,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuidsentinel.cell1,"},{"line_number":2130,"context_line":"                                                      disable\u003dTrue))"},{"line_number":2131,"context_line":"        self.assertIs(cm.disabled, True)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_7fd3ee04","line":2128,"in_reply_to":"bf659307_4d247daf","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":2128,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2129,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuidsentinel.cell1,"},{"line_number":2130,"context_line":"                                                      disable\u003dTrue))"},{"line_number":2131,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2132,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":2133,"context_line":"        self.assertIn(\u0027is already disabled\u0027, output)"},{"line_number":2134,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_0d3a05cb","line":2131,"updated":"2018-03-29 22:45:30.000000000","message":"same","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":2128,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2129,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuidsentinel.cell1,"},{"line_number":2130,"context_line":"                                                      disable\u003dTrue))"},{"line_number":2131,"context_line":"        self.assertIs(cm.disabled, True)"},{"line_number":2132,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":2133,"context_line":"        self.assertIn(\u0027is already disabled\u0027, output)"},{"line_number":2134,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_9fce0258","line":2131,"in_reply_to":"bf659307_0d3a05cb","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":2139,"context_line":"                            transport_url\u003d\u0027fake://mq\u0027,"},{"line_number":2140,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027).create()"},{"line_number":2141,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuidsentinel.cell1)"},{"line_number":2142,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2143,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuidsentinel.cell1,"},{"line_number":2144,"context_line":"                                                      enable\u003dTrue))"},{"line_number":2145,"context_line":"        self.assertIs(cm.disabled, False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_cd2f2d86","line":2142,"updated":"2018-03-29 22:45:30.000000000","message":"same","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":2139,"context_line":"                            transport_url\u003d\u0027fake://mq\u0027,"},{"line_number":2140,"context_line":"                            database_connection\u003d\u0027fake:///db\u0027).create()"},{"line_number":2141,"context_line":"        cm \u003d objects.CellMapping.get_by_uuid(ctxt, uuidsentinel.cell1)"},{"line_number":2142,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2143,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuidsentinel.cell1,"},{"line_number":2144,"context_line":"                                                      enable\u003dTrue))"},{"line_number":2145,"context_line":"        self.assertIs(cm.disabled, False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_3fd9f620","line":2142,"in_reply_to":"bf659307_cd2f2d86","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":2142,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2143,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuidsentinel.cell1,"},{"line_number":2144,"context_line":"                                                      enable\u003dTrue))"},{"line_number":2145,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2146,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":2147,"context_line":"        self.assertIn(\u0027is already enabled\u0027, output)"},{"line_number":2148,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_8d537517","line":2145,"updated":"2018-03-29 22:45:30.000000000","message":"same","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":2142,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2143,"context_line":"        self.assertEqual(0, self.commands.update_cell(uuidsentinel.cell1,"},{"line_number":2144,"context_line":"                                                      enable\u003dTrue))"},{"line_number":2145,"context_line":"        self.assertIs(cm.disabled, False)"},{"line_number":2146,"context_line":"        output \u003d self.output.getvalue().strip()"},{"line_number":2147,"context_line":"        self.assertIn(\u0027is already enabled\u0027, output)"},{"line_number":2148,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_ff085e92","line":2145,"in_reply_to":"bf659307_8d537517","updated":"2018-04-03 09:43:51.000000000","message":"Done","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"}],"releasenotes/notes/add-enable-and-disable-to-update_cell-2a87026a2dd4a95f.yaml":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bf7d965dc6387c86c7849ab207c87c1d454ee02d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Two new options ``--enable`` and ``disable`` have been added to the"},{"line_number":5,"context_line":"    nova-manage cell_v2 update_cell command. Using these new flags, users can"},{"line_number":6,"context_line":"    enable or disable a cell. Note that disabling a cell would stop new"},{"line_number":7,"context_line":"    schedulings to that cell."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df7087c5_bc248061","line":6,"range":{"start_line":6,"start_character":57,"end_line":6,"end_character":62},"updated":"2018-03-22 20:23:52.000000000","message":"\"will\"","commit_id":"b6a96ea9a6268bd58a31e5e22d69c8e61f32fed8"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"000d483ea68c4dc450aef866ae258b225c76f83f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Two new options ``--enable`` and ``disable`` have been added to the"},{"line_number":5,"context_line":"    nova-manage cell_v2 update_cell command. Using these new flags, users can"},{"line_number":6,"context_line":"    enable or disable a cell. Note that disabling a cell would stop new"},{"line_number":7,"context_line":"    schedulings to that cell."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df7087c5_349b9217","line":6,"range":{"start_line":6,"start_character":57,"end_line":6,"end_character":62},"in_reply_to":"df7087c5_bc248061","updated":"2018-03-23 14:18:53.000000000","message":"Done","commit_id":"b6a96ea9a6268bd58a31e5e22d69c8e61f32fed8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bf7d965dc6387c86c7849ab207c87c1d454ee02d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Two new options ``--enable`` and ``disable`` have been added to the"},{"line_number":5,"context_line":"    nova-manage cell_v2 update_cell command. Using these new flags, users can"},{"line_number":6,"context_line":"    enable or disable a cell. Note that disabling a cell would stop new"},{"line_number":7,"context_line":"    schedulings to that cell."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df7087c5_5cea04d8","line":7,"updated":"2018-03-22 20:23:52.000000000","message":"This might just be me, but the way you have described this, it sounds like the scheduling impact is secondary. Like.. \"this disables a cell, and by the way, that will also mean scheduling to that cells stops.\" The reason that may be important is because people might imply that disabling a cell means more than just your note here.\n\nSo maybe just say \"Using these flags users can enable or disable scheduling to a cell.\" or something like that?\n\nMaybe get another opinion and ignore me if they don\u0027t agree :)","commit_id":"b6a96ea9a6268bd58a31e5e22d69c8e61f32fed8"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"000d483ea68c4dc450aef866ae258b225c76f83f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Two new options ``--enable`` and ``disable`` have been added to the"},{"line_number":5,"context_line":"    nova-manage cell_v2 update_cell command. Using these new flags, users can"},{"line_number":6,"context_line":"    enable or disable a cell. Note that disabling a cell would stop new"},{"line_number":7,"context_line":"    schedulings to that cell."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df7087c5_54b96676","line":7,"in_reply_to":"df7087c5_5cea04d8","updated":"2018-03-23 14:18:53.000000000","message":"No, makes sense to me.","commit_id":"b6a96ea9a6268bd58a31e5e22d69c8e61f32fed8"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"8687f294d22991bd17915f176db7c0df0c0e3a58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Two new options ``--enable`` and ``disable`` have been added to the"},{"line_number":5,"context_line":"    nova-manage cell_v2 update_cell command. Using these flags users can enable"},{"line_number":6,"context_line":"    or disable scheduling to a cell."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf659307_34ed49ef","line":4,"range":{"start_line":4,"start_character":39,"end_line":4,"end_character":46},"updated":"2018-03-26 11:42:35.000000000","message":"--disable","commit_id":"a731ea4560833fac35d86e6f3be72f40fd4a26e8"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"3d2113858ab877c07140659701a2d7fd590bd74f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Two new options ``--enable`` and ``disable`` have been added to the"},{"line_number":5,"context_line":"    nova-manage cell_v2 update_cell command. Using these flags users can enable"},{"line_number":6,"context_line":"    or disable scheduling to a cell."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf659307_b49dd95a","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":35},"updated":"2018-03-26 11:44:03.000000000","message":"``nova-manage cell_v2 update_cell``","commit_id":"a731ea4560833fac35d86e6f3be72f40fd4a26e8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f28d648169a313617639099006556939285fdbf1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Two new options ``--enable`` and ``--disable`` have been added to the"},{"line_number":5,"context_line":"    ``nova-manage cell_v2 update_cell`` command. Using these flags users can enable"},{"line_number":6,"context_line":"    or disable scheduling to a cell."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_0a874bb7","line":4,"updated":"2018-03-29 22:45:30.000000000","message":"This is now the 3rd separate release note just for the CLI changes for disabled cells alone (create and list were separate, and now this one). I wish these would have all just built on top of each other in a single release note bullet, but the other two have merged already, so I guess there isn\u0027t going back on that now.","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"93c1ad3918b9277eff2ddd7fa8102d87c874c734","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Two new options ``--enable`` and ``--disable`` have been added to the"},{"line_number":5,"context_line":"    ``nova-manage cell_v2 update_cell`` command. Using these flags users can enable"},{"line_number":6,"context_line":"    or disable scheduling to a cell."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bf659307_ffdffe09","line":4,"in_reply_to":"bf659307_0a874bb7","updated":"2018-04-03 09:43:51.000000000","message":"\u003e This is now the 3rd separate release note just for the CLI changes\n \u003e for disabled cells alone (create and list were separate, and now\n \u003e this one).\n\nlist_cells did not have a reno :) , so this is the second reno for the CLI.\n\n \u003e I wish these would have all just built on top of each\n \u003e other in a single release note bullet,\n\nI hereby fulfill your wish...in the next PS (only problem is I cannot change the name of the release note to a more generic one, but I am guessing its not that important and priority is for building this note over the existing one which is merged).","commit_id":"e238c408e252a5f9dda6f7c4b42e0d5bf7ab6579"}]}