)]}'
{"nova/quota.py":[{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"9b5b55e01754783f622d5f03281b466ee171359d","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            quotas[resource.name] \u003d -1"},{"line_number":652,"context_line":"        return quotas"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def _get_noop_quotas(self, resources, usages\u003dNone, remains\u003dFalse):"},{"line_number":655,"context_line":"        quotas \u003d {}"},{"line_number":656,"context_line":"        for resource in resources.values():"},{"line_number":657,"context_line":"            quotas[resource.name] \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FWCI%3D","line":654,"updated":"2013-11-08 19:08:27.000000000","message":"While functionally the same.  usages\u003dTrue( or False?) makes more sense.  Definitely not None.","commit_id":"a0c699eeb3b89a8b8c1624ffd73b801db62bc6f3"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"eef81c8879b3ca5d065eb50e9e54f3a26b8749b4","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            quotas[resource.name] \u003d -1"},{"line_number":652,"context_line":"        return quotas"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def _get_noop_quotas(self, resources, usages\u003dNone, remains\u003dFalse):"},{"line_number":655,"context_line":"        quotas \u003d {}"},{"line_number":656,"context_line":"        for resource in resources.values():"},{"line_number":657,"context_line":"            quotas[resource.name] \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FVDA%3D","line":654,"in_reply_to":"AAAATn%2F%2FWCI%3D","updated":"2013-11-10 12:57:08.000000000","message":"@Christopher,\n\nThanks for your comments. But as you known, it is a cherry-pick, so may I fix this comment in another code review? I am not sure if the cherry-pick could modify code.","commit_id":"a0c699eeb3b89a8b8c1624ffd73b801db62bc6f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db1a9d5c45682c83ff6e3c989632abc442f213b8","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            quotas[resource.name] \u003d -1"},{"line_number":652,"context_line":"        return quotas"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def _get_noop_quotas(self, resources, usages\u003dTrue, remains\u003dFalse):"},{"line_number":655,"context_line":"        quotas \u003d {}"},{"line_number":656,"context_line":"        for resource in resources.values():"},{"line_number":657,"context_line":"            quotas[resource.name] \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B%2B1s%3D","line":654,"updated":"2013-11-16 19:53:29.000000000","message":"In the master branch version of this, usages\u003dNone, why is it different here?","commit_id":"1963c70bdf7ff1ee2881830cd7930269e2ab664c"},{"author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"change_message_id":"ad6758b9d3b4fad6c0c795c89ebd63c8ffe8d607","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            quotas[resource.name] \u003d -1"},{"line_number":652,"context_line":"        return quotas"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def _get_noop_quotas(self, resources, usages\u003dTrue, remains\u003dFalse):"},{"line_number":655,"context_line":"        quotas \u003d {}"},{"line_number":656,"context_line":"        for resource in resources.values():"},{"line_number":657,"context_line":"            quotas[resource.name] \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B83Q%3D","line":654,"in_reply_to":"AAAATn%2F%2B%2B1s%3D","updated":"2013-11-18 07:49:39.000000000","message":"@Matt, it is a comment from another reviewer, for the usages variable, the correct default value should be True/False, so I submit another code review to fix this issue https://review.openstack.org/#/c/56871","commit_id":"1963c70bdf7ff1ee2881830cd7930269e2ab664c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f07c67a216d266a3c182f7d4814274866121c540","unresolved":false,"context_lines":[{"line_number":651,"context_line":"            quotas[resource.name] \u003d -1"},{"line_number":652,"context_line":"        return quotas"},{"line_number":653,"context_line":""},{"line_number":654,"context_line":"    def _get_noop_quotas(self, resources, usages\u003dTrue, remains\u003dFalse):"},{"line_number":655,"context_line":"        quotas \u003d {}"},{"line_number":656,"context_line":"        for resource in resources.values():"},{"line_number":657,"context_line":"            quotas[resource.name] \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B4lM%3D","line":654,"in_reply_to":"AAAATn%2F%2B83Q%3D","updated":"2013-11-19 00:12:15.000000000","message":"OK, then let\u0027s fix it on master and cherry pick that back too, but we shouldn\u0027t change the code in a cherry pick (as you pointed out in patch set 1, so I\u0027m not sure why you changed it).","commit_id":"1963c70bdf7ff1ee2881830cd7930269e2ab664c"}]}