)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"9d322e1b33bf19249865e9a50f452d27cb15a93a","unresolved":false,"context_lines":[{"line_number":661,"context_line":"                self._delete_instance(context, instance, bdms)"},{"line_number":662,"context_line":"            except Exception:"},{"line_number":663,"context_line":"                self._set_instance_error_state(context, instance[\u0027uuid\u0027])"},{"line_number":664,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":665,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":666,"context_line":"                LOG.exception(msg, instance\u003dinstance)"},{"line_number":667,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FNG8%3D","line":664,"updated":"2013-11-12 23:12:18.000000000","message":"This comment reads difficultly. What are you trying to say here?","commit_id":"eeefb22d13b4bc94bc471c42564ce645ca3cd098"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"9e303ffcbdcf535d2c2ff655ea80154ef8cfd4d8","unresolved":false,"context_lines":[{"line_number":661,"context_line":"                self._delete_instance(context, instance, bdms)"},{"line_number":662,"context_line":"            except Exception:"},{"line_number":663,"context_line":"                self._set_instance_error_state(context, instance[\u0027uuid\u0027])"},{"line_number":664,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":665,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":666,"context_line":"                LOG.exception(msg, instance\u003dinstance)"},{"line_number":667,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BYUc%3D","line":664,"in_reply_to":"AAAATn%2F%2FK%2BE%3D","updated":"2013-11-26 17:52:28.000000000","message":"I would change the log message to something like: \"The instance was in the process of being deleted, but did not finish. Restarting the deletion how.\"","commit_id":"eeefb22d13b4bc94bc471c42564ce645ca3cd098"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"a7d4c012c1ee94f89abbdfe3a0c41ad17b77b538","unresolved":false,"context_lines":[{"line_number":661,"context_line":"                self._delete_instance(context, instance, bdms)"},{"line_number":662,"context_line":"            except Exception:"},{"line_number":663,"context_line":"                self._set_instance_error_state(context, instance[\u0027uuid\u0027])"},{"line_number":664,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":665,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":666,"context_line":"                LOG.exception(msg, instance\u003dinstance)"},{"line_number":667,"context_line":"            finally:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FK%2BE%3D","line":664,"in_reply_to":"AAAATn%2F%2FNG8%3D","updated":"2013-11-13 12:03:34.000000000","message":"It\u0027s copied from a similar block above. This function is called by init_host. No exception should be propagated up from here, otherwise it would stop the compute\u0027s startup.","commit_id":"eeefb22d13b4bc94bc471c42564ce645ca3cd098"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"be64f3207ea4455a7fd10570e5ff46d2db48c331","unresolved":false,"context_lines":[{"line_number":663,"context_line":"                self._set_instance_error_state(context, instance[\u0027uuid\u0027])"},{"line_number":664,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":665,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":666,"context_line":"                LOG.exception(msg, instance\u003dinstance)"},{"line_number":667,"context_line":"            finally:"},{"line_number":668,"context_line":"                return"},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FH6Q%3D","line":666,"updated":"2013-11-14 05:55:22.000000000","message":"Shouldn\u0027t a failure to delete here trigger the delete retry code? In fact, shouldn\u0027t this case already be being handled by the delete retry code?","commit_id":"eeefb22d13b4bc94bc471c42564ce645ca3cd098"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"9e303ffcbdcf535d2c2ff655ea80154ef8cfd4d8","unresolved":false,"context_lines":[{"line_number":663,"context_line":"                self._set_instance_error_state(context, instance[\u0027uuid\u0027])"},{"line_number":664,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":665,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":666,"context_line":"                LOG.exception(msg, instance\u003dinstance)"},{"line_number":667,"context_line":"            finally:"},{"line_number":668,"context_line":"                return"},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BYUA%3D","line":666,"in_reply_to":"AAAATn%2F%2BZBU%3D","updated":"2013-11-26 17:52:28.000000000","message":"Agreed, there is no retry code (at least none at the moment).","commit_id":"eeefb22d13b4bc94bc471c42564ce645ca3cd098"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"ded5c20400cf334e04927f64a4fadf7cf900a5ab","unresolved":false,"context_lines":[{"line_number":663,"context_line":"                self._set_instance_error_state(context, instance[\u0027uuid\u0027])"},{"line_number":664,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":665,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":666,"context_line":"                LOG.exception(msg, instance\u003dinstance)"},{"line_number":667,"context_line":"            finally:"},{"line_number":668,"context_line":"                return"},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BZBU%3D","line":666,"in_reply_to":"AAAATn%2F%2FH6Q%3D","updated":"2013-11-26 16:11:56.000000000","message":"What do you mean by \"delete retry code\"? I couldn\u0027t find that bit. Could you point me to the right file/function?","commit_id":"eeefb22d13b4bc94bc471c42564ce645ca3cd098"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"93f1dc2daa6d015a2a64fa06bada0b2179d527ff","unresolved":false,"context_lines":[{"line_number":780,"context_line":"        context \u003d nova.context.get_admin_context()"},{"line_number":781,"context_line":"        instances \u003d instance_obj.InstanceList.get_by_host("},{"line_number":782,"context_line":"            context, self.host, expected_attrs\u003d[\u0027info_cache\u0027, \u0027metadata\u0027,"},{"line_number":783,"context_line":"                                                \u0027system_metadata\u0027])"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        if CONF.defer_iptables_apply:"},{"line_number":786,"context_line":"            self.driver.filter_defer_apply_on()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FJzs%3D","line":783,"updated":"2013-11-13 17:20:58.000000000","message":"This drags in a lot of additional stuff for every instance, which most of the time will not be needed. Can\u0027t we just let it lazy-load as needed?","commit_id":"eeefb22d13b4bc94bc471c42564ce645ca3cd098"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"ded5c20400cf334e04927f64a4fadf7cf900a5ab","unresolved":false,"context_lines":[{"line_number":780,"context_line":"        context \u003d nova.context.get_admin_context()"},{"line_number":781,"context_line":"        instances \u003d instance_obj.InstanceList.get_by_host("},{"line_number":782,"context_line":"            context, self.host, expected_attrs\u003d[\u0027info_cache\u0027, \u0027metadata\u0027,"},{"line_number":783,"context_line":"                                                \u0027system_metadata\u0027])"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        if CONF.defer_iptables_apply:"},{"line_number":786,"context_line":"            self.driver.filter_defer_apply_on()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2BY5c%3D","line":783,"in_reply_to":"AAAATn%2F%2FJzs%3D","updated":"2013-11-26 16:11:56.000000000","message":"Will do this via \"obj_load_attr\" if possible (haven\u0027t tried yet)","commit_id":"eeefb22d13b4bc94bc471c42564ce645ca3cd098"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5727314fa24a0d0d523a9db1007edb4bbe165b0f","unresolved":false,"context_lines":[{"line_number":642,"context_line":"        # recovery in any case"},{"line_number":643,"context_line":"        if instance.vm_state \u003d\u003d vm_states.SOFT_DELETED:"},{"line_number":644,"context_line":"            return"},{"line_number":645,"context_line":""},{"line_number":646,"context_line":"        if instance.vm_state \u003d\u003d vm_states.DELETED:"},{"line_number":647,"context_line":"            try:"},{"line_number":648,"context_line":"                self._complete_partial_deletion(context, instance)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2B9wI%3D","line":645,"updated":"2014-01-20 10:40:03.000000000","message":"Nit: would be nice to keep related states closer together.","commit_id":"0252d0981af9daaf9370a50c28d8baf4a9d29619"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5727314fa24a0d0d523a9db1007edb4bbe165b0f","unresolved":false,"context_lines":[{"line_number":692,"context_line":"                # we don\u0027t want that an exception blocks the init_host"},{"line_number":693,"context_line":"                msg \u003d _(\u0027Failed to complete a deletion\u0027)"},{"line_number":694,"context_line":"                LOG.exception(msg, instance\u003dinstance)"},{"line_number":695,"context_line":"                self._set_instance_error_state(context, instance[\u0027uuid\u0027])"},{"line_number":696,"context_line":"            finally:"},{"line_number":697,"context_line":"                return"},{"line_number":698,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2B9wY%3D","line":695,"updated":"2014-01-20 10:40:03.000000000","message":"Nit: I wonder about adding this into the top level call to _init_instance, it doesn\u0027t feel very dry, when compared with the DELETED code.","commit_id":"0252d0981af9daaf9370a50c28d8baf4a9d29619"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"5727314fa24a0d0d523a9db1007edb4bbe165b0f","unresolved":false,"context_lines":[{"line_number":818,"context_line":"        try:"},{"line_number":819,"context_line":"            # checking that instance was not already evacuated to other host"},{"line_number":820,"context_line":"            self._destroy_evacuated_instances(context)"},{"line_number":821,"context_line":"            for instance in instances:"},{"line_number":822,"context_line":"                self._init_instance(context, instance)"},{"line_number":823,"context_line":"        finally:"},{"line_number":824,"context_line":"            if CONF.defer_iptables_apply:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2B9w0%3D","line":821,"updated":"2014-01-20 10:40:03.000000000","message":"Nit: yeah, might be good to move the exception handling here, but probably best in a follow on change set.","commit_id":"0252d0981af9daaf9370a50c28d8baf4a9d29619"}],"nova/tests/compute/test_compute_mgr.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0302569e0a0e5075b21702e9a447b6fcda4e2575","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            self.compute.driver.init_host(host\u003dour_host)"},{"line_number":158,"context_line":"            context.get_admin_context().AndReturn(fake_context)"},{"line_number":159,"context_line":"            db.instance_get_all_by_host("},{"line_number":160,"context_line":"                    fake_context, our_host, columns_to_join\u003dmox.IgnoreArg(),"},{"line_number":161,"context_line":"                    use_slave\u003dFalse"},{"line_number":162,"context_line":"                    ).AndReturn(startup_instances)"},{"line_number":163,"context_line":"            if defer_iptables_apply:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9WL0%3D","line":160,"updated":"2013-12-12 12:43:56.000000000","message":"is this related to this patch set?","commit_id":"657b2446c3ae10e62c5f14e525bcb305b784eb8d"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"9fdc57e7ae7f7070f4a7e175add4885e1fb708e5","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            self.compute.driver.init_host(host\u003dour_host)"},{"line_number":158,"context_line":"            context.get_admin_context().AndReturn(fake_context)"},{"line_number":159,"context_line":"            db.instance_get_all_by_host("},{"line_number":160,"context_line":"                    fake_context, our_host, columns_to_join\u003dmox.IgnoreArg(),"},{"line_number":161,"context_line":"                    use_slave\u003dFalse"},{"line_number":162,"context_line":"                    ).AndReturn(startup_instances)"},{"line_number":163,"context_line":"            if defer_iptables_apply:"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9WF8%3D","line":160,"in_reply_to":"AAAATn%2F9WL0%3D","updated":"2013-12-12 13:06:56.000000000","message":"It was in the previous patchset. I\u0027ll remove it.","commit_id":"657b2446c3ae10e62c5f14e525bcb305b784eb8d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0302569e0a0e5075b21702e9a447b6fcda4e2575","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        self.compute.driver.init_host(host\u003dour_host)"},{"line_number":225,"context_line":"        context.get_admin_context().AndReturn(fake_context)"},{"line_number":226,"context_line":"        db.instance_get_all_by_host(fake_context, our_host,"},{"line_number":227,"context_line":"                                    columns_to_join\u003dmox.IgnoreArg(),"},{"line_number":228,"context_line":"                                    use_slave\u003dFalse"},{"line_number":229,"context_line":"                                    ).AndReturn([])"},{"line_number":230,"context_line":"        self.compute.init_virt_events()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9WLw%3D","line":227,"updated":"2013-12-12 12:43:56.000000000","message":"ditto","commit_id":"657b2446c3ae10e62c5f14e525bcb305b784eb8d"}]}