)]}'
{"nova/api/openstack/wsgi_app.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c09b742fbd23d2d751f3a9029f881743f20725aa","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    binary \u003d name if name.startswith(\u0027nova-\u0027) else \"nova-%s\" % name"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    ctxt \u003d context.get_admin_context()"},{"line_number":48,"context_line":"    service_ref \u003d objects.Service.get_by_host_and_binary("},{"line_number":49,"context_line":"        ctxt, host, binary)"},{"line_number":50,"context_line":"    if service_ref:"},{"line_number":51,"context_line":"        service._update_service_ref(service_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_7cbcf804","side":"PARENT","line":48,"updated":"2018-03-26 22:27:02.000000000","message":"Is there any upgrade impact here? Let\u0027s say someone was doing a single cell, non-tiered conductor setup, and for whatever reason they had [database]/connection pointed at cell1 instead of cell0 (it might have been a mistake that just worked and they didn\u0027t realize). Would this cause any issues beyond creating a new API service record in cell0? Note that the os-services REST API filters out API services so they wouldn\u0027t see or be able to remove them from that API if they were in a non-cell0 DB:\n\nhttps://github.com/openstack/nova/blob/88f6c3b7b892f2a05066ac6f0e3353f4ce80f6b0/nova/api/openstack/compute/services.py#L48","commit_id":"88f6c3b7b892f2a05066ac6f0e3353f4ce80f6b0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9ba039c1af1fdd8e2f9c6b04930092f24be768a6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    binary \u003d name if name.startswith(\u0027nova-\u0027) else \"nova-%s\" % name"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    ctxt \u003d context.get_admin_context()"},{"line_number":48,"context_line":"    service_ref \u003d objects.Service.get_by_host_and_binary("},{"line_number":49,"context_line":"        ctxt, host, binary)"},{"line_number":50,"context_line":"    if service_ref:"},{"line_number":51,"context_line":"        service._update_service_ref(service_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_9c730c81","side":"PARENT","line":48,"in_reply_to":"bf659307_7cbcf804","updated":"2018-03-26 22:31:55.000000000","message":"Also, nova-metadata uses this code:\n\nhttps://github.com/openstack/nova/blob/88f6c3b7b892f2a05066ac6f0e3353f4ce80f6b0/nova/api/metadata/wsgi.py#L20\n\nBut is that global or per-cell? Sounds like global.","commit_id":"88f6c3b7b892f2a05066ac6f0e3353f4ce80f6b0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cadae4bc03ca0d03abcdec05131bd5a0b9b5ad2d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    # those service records in the cell0 database, so we need to look that"},{"line_number":50,"context_line":"    # up from the API database and use it to target the context."},{"line_number":51,"context_line":"    # TODO(mriedem): How/where do we gracefully handle CellMappingNotFound?"},{"line_number":52,"context_line":"    cell0 \u003d objects.CellMappin.get_by_uuid("},{"line_number":53,"context_line":"        ctxt, objects.CellMapping.CELL0_UUID)"},{"line_number":54,"context_line":"    with context.target_cell(ctxt, cell0) as cctxt:"},{"line_number":55,"context_line":"        service_ref \u003d objects.Service.get_by_host_and_binary("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_92cbf351","line":52,"range":{"start_line":52,"start_character":20,"end_line":52,"end_character":30},"updated":"2018-03-27 00:40:25.000000000","message":"heh, CellMappin\u0027, yee-haw!","commit_id":"467b6f582a024be1b6ef2eb3ac33312eae6730ec"}]}