)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"12a16e5c074194b9521d6756865709e0e3d9a057","unresolved":false,"context_lines":[{"line_number":18,"context_line":"requested microversion matches 1.22 or beyond that flag"},{"line_number":19,"context_line":"is True, otherwise False."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Reno, api-ref update and api history update are include."},{"line_number":22,"context_line":"Because this microversion changes the value of an existing"},{"line_number":23,"context_line":"parameter it was unclear how to best express that in the"},{"line_number":24,"context_line":"api-ref. In this case existing parameter references were"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf659307_a66bfdb4","line":21,"range":{"start_line":21,"start_character":48,"end_line":21,"end_character":55},"updated":"2018-03-29 19:24:25.000000000","message":"included","commit_id":"42c0d4f0fe3215a5179b61ae5c336c15e02a27b7"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"de7aa19d86ced55bda1d2f47b49ff9b0a98d640e","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    required\u003dCUSTOM_FAST,!CUSTOM_SLOW"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This changes uses db and query processing code adjustments"},{"line_number":17,"context_line":"already present in the code but guarded by a flag. If the"},{"line_number":18,"context_line":"currently requested microversion matches 1.22 or beyond"},{"line_number":19,"context_line":"that flag is True, otherwise False."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bf659307_ce9feaff","line":16,"range":{"start_line":16,"start_character":5,"end_line":16,"end_character":12},"updated":"2018-04-13 18:20:17.000000000","message":"change","commit_id":"ff06b6bdf38a9833593ba54f54a9bb918775617a"}],"nova/api/openstack/placement/handlers/resource_provider.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d6763f53511f8a30026144b14a094be39374e0ef","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            filters[attr] \u003d value"},{"line_number":226,"context_line":"    try:"},{"line_number":227,"context_line":"        resource_providers \u003d rp_obj.ResourceProviderList.get_all_by_filters("},{"line_number":228,"context_line":"            context, filters, allow_forbidden\u003dallow_forbidden)"},{"line_number":229,"context_line":"    except exception.ResourceClassNotFound as exc:"},{"line_number":230,"context_line":"        raise webob.exc.HTTPBadRequest("},{"line_number":231,"context_line":"            _(\u0027Invalid resource class in resources parameter: %(error)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf659307_c2a8218d","line":228,"range":{"start_line":228,"start_character":28,"end_line":228,"end_character":61},"updated":"2018-04-13 15:20:38.000000000","message":"this should not be necessary. Whether or not forbidden traits are allowed is an API layer validation and should remain only here (and in the associated util functions)","commit_id":"90474ebbff7341477a07d52f38bd7fee4b56d7e4"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"de7aa19d86ced55bda1d2f47b49ff9b0a98d640e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    elif want_version.matches((1, 3)):"},{"line_number":192,"context_line":"        schema \u003d rp_schema.GET_RPS_SCHEMA_1_3"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    # By default don\u0027t support forbidden query params."},{"line_number":195,"context_line":"    allow_forbidden \u003d want_version.matches((1, 22))"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    util.validate_query_params(req, schema)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_2e90e6ec","line":194,"range":{"start_line":194,"start_character":4,"end_line":194,"end_character":54},"updated":"2018-04-13 18:20:17.000000000","message":"not sure this comment is useful?","commit_id":"ff06b6bdf38a9833593ba54f54a9bb918775617a"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3e1b0204eec605229155017939c6d07f74cff253","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    elif want_version.matches((1, 3)):"},{"line_number":192,"context_line":"        schema \u003d rp_schema.GET_RPS_SCHEMA_1_3"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    # By default don\u0027t support forbidden query params."},{"line_number":195,"context_line":"    allow_forbidden \u003d want_version.matches((1, 22))"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    util.validate_query_params(req, schema)"}],"source_content_type":"text/x-python","patch_set":11,"id":"bf659307_8e21f2b6","line":194,"range":{"start_line":194,"start_character":4,"end_line":194,"end_character":54},"in_reply_to":"bf659307_2e90e6ec","updated":"2018-04-13 18:24:38.000000000","message":"I reckon that\u0027s a leftover from the different ordering. Will remove.","commit_id":"ff06b6bdf38a9833593ba54f54a9bb918775617a"}],"placement-api-ref/source/parameters.yaml":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"12a16e5c074194b9521d6756865709e0e3d9a057","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    Accepts a list of comma-separated traits. Allocation requests in the"},{"line_number":60,"context_line":"    response will be for resource providers that have capacity for all"},{"line_number":61,"context_line":"    requested resources and the set of those resource providers will"},{"line_number":62,"context_line":"    *collectively* contain all of the required traits. **In microversion 1.22**"},{"line_number":63,"context_line":"    traits which are forbidden from any resource provider may be expressed"},{"line_number":64,"context_line":"    by prefixing a trait with a ``!``."},{"line_number":65,"context_line":"member_of:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_26eb6d13","line":62,"updated":"2018-03-29 19:24:25.000000000","message":"perhaps \"Starting in...\"","commit_id":"42c0d4f0fe3215a5179b61ae5c336c15e02a27b7"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"db4ed5f7d53d55fb8d65834bd7e41dc56c97dff8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    Accepts a list of comma-separated traits. Allocation requests in the"},{"line_number":60,"context_line":"    response will be for resource providers that have capacity for all"},{"line_number":61,"context_line":"    requested resources and the set of those resource providers will"},{"line_number":62,"context_line":"    *collectively* contain all of the required traits. **In microversion 1.22**"},{"line_number":63,"context_line":"    traits which are forbidden from any resource provider may be expressed"},{"line_number":64,"context_line":"    by prefixing a trait with a ``!``."},{"line_number":65,"context_line":"member_of:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bf659307_cbd152fd","line":62,"in_reply_to":"bf659307_26eb6d13","updated":"2018-03-30 06:01:19.000000000","message":"IMO, \"Starting from ...\" is better.","commit_id":"42c0d4f0fe3215a5179b61ae5c336c15e02a27b7"}]}
