)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9c6f156c9d902be35f77a69678c10fae7374db23","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch removes cell0 from the list of loaded cells in the"},{"line_number":10,"context_line":"cache before scheduling. Doing this improves performance slightly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related to blueprint cell-disable"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I660e431305de491ff19d4a99ca801d19f4ed754b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_8692c44a","line":12,"updated":"2018-03-27 15:17:39.000000000","message":"This change doesn\u0027t need to be tied to this blueprint, and is arguably a bug that don\u0027t already filter out cell0 during scheduling since cell0 isn\u0027t supposed to have any compute hosts in it. So can we just open a low priority bug for this and track it that way?","commit_id":"08c6bfa73166bc2aa9d55f64aeb61012b3956dfb"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"b6c7b2c761b29d1bc8d6a9f5df4678f2da50d48d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch removes cell0 from the list of loaded cells in the"},{"line_number":10,"context_line":"cache before scheduling. Doing this improves performance slightly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Related to blueprint cell-disable"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I660e431305de491ff19d4a99ca801d19f4ed754b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf659307_2614184e","line":12,"in_reply_to":"bf659307_8692c44a","updated":"2018-03-27 16:05:36.000000000","message":"Done","commit_id":"08c6bfa73166bc2aa9d55f64aeb61012b3956dfb"}],"nova/scheduler/host_manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9c6f156c9d902be35f77a69678c10fae7374db23","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            self.cells \u003d objects.CellMappingList.get_all(context)"},{"line_number":640,"context_line":"            # NOTE(tssurya): filtering cell0 from the list since it need"},{"line_number":641,"context_line":"            # not be considered for scheduling."},{"line_number":642,"context_line":"            for c in self.cells:"},{"line_number":643,"context_line":"                if c.is_cell0():"},{"line_number":644,"context_line":"                    self.cells.objects.remove(c)"},{"line_number":645,"context_line":"                    # once its done break for optimization"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_26b2d8e7","line":642,"updated":"2018-03-27 15:17:39.000000000","message":"Seems we should do this before assigning the self.cells variable so we don\u0027t have some weird timing issue between the time that self.cells is set and another thread starts using it.","commit_id":"08c6bfa73166bc2aa9d55f64aeb61012b3956dfb"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"b6c7b2c761b29d1bc8d6a9f5df4678f2da50d48d","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            self.cells \u003d objects.CellMappingList.get_all(context)"},{"line_number":640,"context_line":"            # NOTE(tssurya): filtering cell0 from the list since it need"},{"line_number":641,"context_line":"            # not be considered for scheduling."},{"line_number":642,"context_line":"            for c in self.cells:"},{"line_number":643,"context_line":"                if c.is_cell0():"},{"line_number":644,"context_line":"                    self.cells.objects.remove(c)"},{"line_number":645,"context_line":"                    # once its done break for optimization"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_0620f4af","line":642,"in_reply_to":"bf659307_26b2d8e7","updated":"2018-03-27 16:05:36.000000000","message":"Done, sorry for not spotting this.","commit_id":"08c6bfa73166bc2aa9d55f64aeb61012b3956dfb"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"d031a7c0bfcd69e0f7a0e8b4fdbfa50839d8272c","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            temp_cells \u003d objects.CellMappingList.get_all(context)"},{"line_number":639,"context_line":"            # NOTE(tssurya): filtering cell0 from the list since it need"},{"line_number":640,"context_line":"            # not be considered for scheduling."},{"line_number":641,"context_line":"            for c in temp_cells:"},{"line_number":642,"context_line":"                if c.is_cell0():"},{"line_number":643,"context_line":"                    temp_cells.objects.remove(c)"},{"line_number":644,"context_line":"                    # once its done break for optimization"},{"line_number":645,"context_line":"                    break"},{"line_number":646,"context_line":"            # NOTE(danms): global list of cells cached forever right now"},{"line_number":647,"context_line":"            self.cells \u003d temp_cells"},{"line_number":648,"context_line":"            LOG.debug(\u0027Found %(count)i cells: %(cells)s\u0027,"},{"line_number":649,"context_line":"                      {\u0027count\u0027: len(self.cells),"},{"line_number":650,"context_line":"                       \u0027cells\u0027: \u0027, \u0027.join([c.uuid for c in self.cells])})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_96ac2035","line":647,"range":{"start_line":641,"start_character":2,"end_line":647,"end_character":35},"updated":"2018-03-28 02:56:10.000000000","message":"will cell0 always be the first one in temp_cells?","commit_id":"378bef70db4ca7437d716ac3e1b11a2a789f919f"},{"author":{"_account_id":26936,"name":"Surya Seetharaman","email":"suryaseetharaman.9@gmail.com","username":"tssurya"},"change_message_id":"9814fdf0801a0049e10c430d6bf12a4d7925c4d5","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            temp_cells \u003d objects.CellMappingList.get_all(context)"},{"line_number":639,"context_line":"            # NOTE(tssurya): filtering cell0 from the list since it need"},{"line_number":640,"context_line":"            # not be considered for scheduling."},{"line_number":641,"context_line":"            for c in temp_cells:"},{"line_number":642,"context_line":"                if c.is_cell0():"},{"line_number":643,"context_line":"                    temp_cells.objects.remove(c)"},{"line_number":644,"context_line":"                    # once its done break for optimization"},{"line_number":645,"context_line":"                    break"},{"line_number":646,"context_line":"            # NOTE(danms): global list of cells cached forever right now"},{"line_number":647,"context_line":"            self.cells \u003d temp_cells"},{"line_number":648,"context_line":"            LOG.debug(\u0027Found %(count)i cells: %(cells)s\u0027,"},{"line_number":649,"context_line":"                      {\u0027count\u0027: len(self.cells),"},{"line_number":650,"context_line":"                       \u0027cells\u0027: \u0027, \u0027.join([c.uuid for c in self.cells])})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_1c634e44","line":647,"range":{"start_line":641,"start_character":2,"end_line":647,"end_character":35},"in_reply_to":"bf659307_96ac2035","updated":"2018-03-28 08:07:08.000000000","message":"I think theoretically it will be since its usually the first in the cell_mapping table, but we cannot be sure that it would always be first entry practically (probably depends on the way of setting up and if someone accidentally deletes cell0 and sets it back, the id will not be 1 anymore) which is why I do this in a loop.","commit_id":"378bef70db4ca7437d716ac3e1b11a2a789f919f"}]}