)]}'
{"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"ad398ed2157ab0eed4b7b03de27ce64181d492af","unresolved":false,"context_lines":[{"line_number":20472,"context_line":"        self.mock_update_task_state.assert_has_calls(["},{"line_number":20473,"context_line":"            mock.call(task_state\u003dtask_states.IMAGE_PENDING_UPLOAD),"},{"line_number":20474,"context_line":"            mock.call(task_state\u003dtask_states.IMAGE_UPLOADING,"},{"line_number":20475,"context_line":"                      expected_state\u003dtask_states.IMAGE_PENDING_UPLOAD)])"},{"line_number":20476,"context_line":""},{"line_number":20477,"context_line":"        props \u003d snapshot[\u0027properties\u0027]"},{"line_number":20478,"context_line":"        self.assertEqual(props[\u0027image_state\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_943ab1c9","side":"PARENT","line":20475,"range":{"start_line":20475,"start_character":1,"end_line":20475,"end_character":72},"updated":"2018-03-29 07:22:09.000000000","message":"why doing this?","commit_id":"88f6c3b7b892f2a05066ac6f0e3353f4ce80f6b0"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d259a3ccc26b2551a9d5c93da2ad04a45f73fbe8","unresolved":false,"context_lines":[{"line_number":20472,"context_line":"        self.mock_update_task_state.assert_has_calls(["},{"line_number":20473,"context_line":"            mock.call(task_state\u003dtask_states.IMAGE_PENDING_UPLOAD),"},{"line_number":20474,"context_line":"            mock.call(task_state\u003dtask_states.IMAGE_UPLOADING,"},{"line_number":20475,"context_line":"                      expected_state\u003dtask_states.IMAGE_PENDING_UPLOAD)])"},{"line_number":20476,"context_line":""},{"line_number":20477,"context_line":"        props \u003d snapshot[\u0027properties\u0027]"},{"line_number":20478,"context_line":"        self.assertEqual(props[\u0027image_state\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_fa2af729","side":"PARENT","line":20475,"range":{"start_line":20475,"start_character":1,"end_line":20475,"end_character":72},"in_reply_to":"bf659307_943ab1c9","updated":"2018-03-29 08:25:48.000000000","message":"typo :(\nfixed in next patch","commit_id":"88f6c3b7b892f2a05066ac6f0e3353f4ce80f6b0"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"eca787b2bb9c66284b7219290b6cb423ba42e331","unresolved":false,"context_lines":[{"line_number":1919,"context_line":""},{"line_number":1920,"context_line":"        update_task_state(task_state\u003dtask_states.IMAGE_PENDING_UPLOAD)"},{"line_number":1921,"context_line":""},{"line_number":1922,"context_line":"        update_task_state(task_state\u003dtask_states.IMAGE_UPLOADING,"},{"line_number":1923,"context_line":"                          expected_state\u003dtask_states.IMAGE_PENDING_UPLOAD)"},{"line_number":1924,"context_line":""},{"line_number":1925,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_95a701a8","line":1922,"range":{"start_line":1922,"start_character":8,"end_line":1922,"end_character":25},"updated":"2018-03-29 17:21:48.000000000","message":"For other reviewers:\n\nBecause the raised exception is not caught here, it will be raised up to the caller side: ComputeManager._snapshot_instance() where there is an except clause for handling InstanceNotFound exception.\n\nhttps://github.com/openstack/nova/blob/81544829d14aebaaa717ffbe6ec33c67a2f11b7f/nova/compute/manager.py#L3292","commit_id":"d5de5c72b48d6f25a1ec79e15f6ca3a3b1e84011"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19e2e88f61b36ae07739a3f40fb1fc82f433220c","unresolved":false,"context_lines":[{"line_number":1997,"context_line":"                                           image_file)"},{"line_number":1998,"context_line":"        except Exception:"},{"line_number":1999,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2000,"context_line":"                LOG.exception(_(\"Failed to snapshot image\"))"},{"line_number":2001,"context_line":"                failed_snap \u003d metadata.pop(\u0027location\u0027, None)"},{"line_number":2002,"context_line":"                if failed_snap:"},{"line_number":2003,"context_line":"                    failed_snap \u003d {\u0027url\u0027: str(failed_snap)}"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_cac4e1f7","line":2000,"range":{"start_line":2000,"start_character":16,"end_line":2000,"end_character":60},"updated":"2018-03-30 20:25:23.000000000","message":"This is the traceback you\u0027re trying to avoid, correct?","commit_id":"d5de5c72b48d6f25a1ec79e15f6ca3a3b1e84011"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"b8271b76eae94bb4c19cd3e9d34ccf2073a39237","unresolved":false,"context_lines":[{"line_number":1997,"context_line":"                                           image_file)"},{"line_number":1998,"context_line":"        except Exception:"},{"line_number":1999,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2000,"context_line":"                LOG.exception(_(\"Failed to snapshot image\"))"},{"line_number":2001,"context_line":"                failed_snap \u003d metadata.pop(\u0027location\u0027, None)"},{"line_number":2002,"context_line":"                if failed_snap:"},{"line_number":2003,"context_line":"                    failed_snap \u003d {\u0027url\u0027: str(failed_snap)}"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf659307_31b2904a","line":2000,"range":{"start_line":2000,"start_character":16,"end_line":2000,"end_character":60},"in_reply_to":"bf659307_cac4e1f7","updated":"2018-04-03 05:15:47.000000000","message":"yes, save function will be called outside of this try/except, then it won\u0027t have the traceback here","commit_id":"d5de5c72b48d6f25a1ec79e15f6ca3a3b1e84011"}]}