)]}'
{"etc/nova/nova.conf.sample":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"c37a2152bcef9ec50e7fba23daf926ab0da646de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"2013-11-22 15:37:55.782 56242 CRITICAL nova [-] Unable to import module nova.cmd.baremetal_manage"},{"line_number":2,"context_line":"[keystone_authtoken]"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"AAAATn%2F%2BgP0%3D","line":1,"updated":"2013-11-25 12:07:10.000000000","message":"Conf file re-generation catastrophe here.\n\nI\u0027ve seen this happen with a number of commits recently.\n\nThere\u0027s probably a case for opening a bug against the code which re-generates this, so that when it fails it prints the problem to stderr \u0026 returns non-zero, instead of writing junk like this to the config file.","commit_id":"b1ab0a59344520bc4885969ff9a61cfa18d51c2c"}],"nova/virt/cpu.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f13cfc0189c5db1ee3a463e946364c94b4e872ec","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        return None"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    cpuset_ids \u003d set()"},{"line_number":46,"context_line":"    cpuset_reject_ids \u003d set()"},{"line_number":47,"context_line":"    for rule in CONF.vcpu_pin_set.split(\u0027,\u0027):"},{"line_number":48,"context_line":"        rule \u003d rule.strip()"},{"line_number":49,"context_line":"        # Handle multi \u0027,\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F%2Bso8%3D","line":46,"updated":"2013-11-21 12:06:27.000000000","message":"Lets just mention the CPU syntax we\u0027re parsing here explicitly. Copying from libvirt docs\n\n  \"Each element in that list is either a single CPU number, a range \n   of CPU numbers, or a caret followed by a CPU number to be\n   excluded from a previous range.\"","commit_id":"b5a69f4b4f60548bf2ca7d9d2a9f7b7de640ad13"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b544fe2eb838888981ccc3d30de15ee4d71ea176","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.StrOpt(\u0027vcpu_pin_set\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027Which pcpus can be used by vcpus of instance \u0027"},{"line_number":29,"context_line":"                     \u0027e.g: \"4-12,^8,15\"\u0027,"},{"line_number":30,"context_line":"                deprecated_group\u003d\u0027libvirt\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2BIlw%3D","line":30,"updated":"2013-12-02 07:05:40.000000000","message":"This is a bit problematic. Please see https://github.com/openstack/nova/blob/stable/havana/nova/virt/libvirt/driver.py#L217\nA few weeks ago these were moved from DEFAULT to libvirt, we are now moving them back. Is this required?","commit_id":"337736f4e2c36fc6eba8f2c15a3b221502f12df6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7ade67a97d676a4c2e793a4659cb7c380c43ae01","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.StrOpt(\u0027vcpu_pin_set\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027Which pcpus can be used by vcpus of instance \u0027"},{"line_number":29,"context_line":"                     \u0027e.g: \"4-12,^8,15\"\u0027,"},{"line_number":30,"context_line":"                deprecated_group\u003d\u0027libvirt\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2BHrQ%3D","line":30,"in_reply_to":"AAAATn%2F%2BIMQ%3D","updated":"2013-12-02 11:43:14.000000000","message":"Yes, correct. Too much moving of these parts","commit_id":"337736f4e2c36fc6eba8f2c15a3b221502f12df6"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0c2999ae7acf66d3db120502c44a346491e0d062","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.StrOpt(\u0027vcpu_pin_set\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027Which pcpus can be used by vcpus of instance \u0027"},{"line_number":29,"context_line":"                     \u0027e.g: \"4-12,^8,15\"\u0027,"},{"line_number":30,"context_line":"                deprecated_group\u003d\u0027libvirt\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2BIMQ%3D","line":30,"in_reply_to":"AAAATn%2F%2BIlw%3D","updated":"2013-12-02 09:26:58.000000000","message":"Previously this setting was libvirt-specific. This change makes it shared across virt drivers, so it makes sense that it is moved back to the shared namespace in the config file.","commit_id":"337736f4e2c36fc6eba8f2c15a3b221502f12df6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcc2d3476a221c71e5b8de3134c400bce86f8b07","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.StrOpt(\u0027vcpu_pin_set\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027Which pcpus can be used by vcpus of instance \u0027"},{"line_number":29,"context_line":"                     \u0027e.g: \"4-12,^8,15\"\u0027,"},{"line_number":30,"context_line":"                deprecated_group\u003d\u0027libvirt\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2BBEg%3D","line":30,"updated":"2013-12-03 13:05:09.000000000","message":"This is not correct. We do not need the libvirt.\nIn Havana it was defined as: https://github.com/openstack/nova/blob/stable/havana/nova/virt/libvirt/driver.py#L217\nwhich were registered as DEFAULT (https://github.com/openstack/nova/blob/stable/havana/nova/virt/libvirt/driver.py#L223).\nThe refactoring of the variables into a libvirt section was done in I.\nDo we want to support the window of development in I. I am not sure.\nIn any case it will work as the original was DEAFULT but the deprecated is unnecesary","commit_id":"3ed9f567b2dac19de4108b6d961f9c00edf66ad2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a69fb02d9145310c3d8ae6da40ea1a2ef621e20c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    cfg.StrOpt(\u0027vcpu_pin_set\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027Which pcpus can be used by vcpus of instance \u0027"},{"line_number":29,"context_line":"                     \u0027e.g: \"4-12,^8,15\"\u0027,"},{"line_number":30,"context_line":"                deprecated_group\u003d\u0027libvirt\u0027),"},{"line_number":31,"context_line":"]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9%2Fi0%3D","line":30,"in_reply_to":"AAAATn%2F%2BBEg%3D","updated":"2013-12-03 17:26:47.000000000","message":"But we support continuous deployment, so people may hit the window where it was moved to libvirt, and moved it to libvirt, then hit the issue here.\n\nBut I can\u0027t really decide what is best myself. See the discussion on the previous patch set, this code has not changed.","commit_id":"3ed9f567b2dac19de4108b6d961f9c00edf66ad2"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fcc2d3476a221c71e5b8de3134c400bce86f8b07","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    cpu_mask_list \u003d cpu.get_cpuset_ids()"},{"line_number":270,"context_line":"    if cpu_mask_list:"},{"line_number":271,"context_line":"        cpu_mask \u003d \",\".join(str(cpu_id) for cpu_id in cpu_mask_list)"},{"line_number":272,"context_line":"        vcpu_params[\"mask\"] \u003d cpu_mask"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    rec \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2BBDU%3D","line":271,"updated":"2013-12-03 13:05:09.000000000","message":"do you want to run this each time a VM is launched. When the compute node is launched and the driver is started why not read this value into a global varaiable (for example on the session parameter), then it is just a matter of reading it.\nIt will certainly save a few cycles","commit_id":"3ed9f567b2dac19de4108b6d961f9c00edf66ad2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a69fb02d9145310c3d8ae6da40ea1a2ef621e20c","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    cpu_mask_list \u003d cpu.get_cpuset_ids()"},{"line_number":270,"context_line":"    if cpu_mask_list:"},{"line_number":271,"context_line":"        cpu_mask \u003d \",\".join(str(cpu_id) for cpu_id in cpu_mask_list)"},{"line_number":272,"context_line":"        vcpu_params[\"mask\"] \u003d cpu_mask"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    rec \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9%2Fic%3D","line":271,"in_reply_to":"AAAATn%2F%2BBDU%3D","updated":"2013-12-03 17:26:47.000000000","message":"Yep, we should do that, was going to leave that as a separate change though.\n\nIf the list is empty, its almost free, so this doesn\u0027t matter too much I guess?","commit_id":"3ed9f567b2dac19de4108b6d961f9c00edf66ad2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"09acbeac6213c8f45897c82fd4671068f395ea54","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    cpu_mask_list \u003d cpu.get_cpuset_ids()"},{"line_number":270,"context_line":"    if cpu_mask_list:"},{"line_number":271,"context_line":"        cpu_mask \u003d \",\".join(str(cpu_id) for cpu_id in cpu_mask_list)"},{"line_number":272,"context_line":"        vcpu_params[\"mask\"] \u003d cpu_mask"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    rec \u003d {"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F971U%3D","line":271,"in_reply_to":"AAAATn%2F9%2Fic%3D","updated":"2013-12-04 09:37:22.000000000","message":"yeah, if the list is empty then i guess that is ok.","commit_id":"3ed9f567b2dac19de4108b6d961f9c00edf66ad2"}]}