)]}'
{"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ff1f09ef5a74de622e5d2e94a60b89119da5e19f","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            for disk in block_device_mapping:"},{"line_number":436,"context_line":"                connection_info \u003d disk[\u0027connection_info\u0027]"},{"line_number":437,"context_line":"                try:"},{"line_number":438,"context_line":"                    self._volumeops.detach_volume(connection_info, instance)"},{"line_number":439,"context_line":"                except exception.DiskNotFound:"},{"line_number":440,"context_line":"                    LOG.warning(\u0027The volume %s does not exist!\u0027,"},{"line_number":441,"context_line":"                                disk.get(\u0027device_name\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_6ea3a29f","line":438,"updated":"2018-03-28 15:51:04.000000000","message":"Or just call self.detach_volume(None, connection_info, instance, None).","commit_id":"de08939bc0120f909b98ad6721b052650beb87af"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"782d575e8e8f05d08e74388ed1f8249110c91ba5","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            for disk in block_device_mapping:"},{"line_number":436,"context_line":"                connection_info \u003d disk[\u0027connection_info\u0027]"},{"line_number":437,"context_line":"                try:"},{"line_number":438,"context_line":"                    self._volumeops.detach_volume(connection_info, instance)"},{"line_number":439,"context_line":"                except exception.DiskNotFound:"},{"line_number":440,"context_line":"                    LOG.warning(\u0027The volume %s does not exist!\u0027,"},{"line_number":441,"context_line":"                                disk.get(\u0027device_name\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_0ecb061e","line":438,"in_reply_to":"bf659307_6ea3a29f","updated":"2018-03-28 15:57:00.000000000","message":"we can still use disk.get(\u0027device_name\u0027) IMO.\n\nI\u0027m fine either way, but I thought this looks cleaner.","commit_id":"de08939bc0120f909b98ad6721b052650beb87af"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b7aeaf51b38cad5af7353f27ccf61ed828f32332","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            for disk in block_device_mapping:"},{"line_number":436,"context_line":"                connection_info \u003d disk[\u0027connection_info\u0027]"},{"line_number":437,"context_line":"                try:"},{"line_number":438,"context_line":"                    self.detach_volume(None, connection_info, instance,"},{"line_number":439,"context_line":"                                       disk.get(\u0027device_name\u0027))"},{"line_number":440,"context_line":"                except exception.DiskNotFound:"},{"line_number":441,"context_line":"                    LOG.warning(\u0027The volume %s does not exist!\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_ef431312","line":438,"updated":"2018-03-29 14:21:10.000000000","message":"nit: a note here about passing None for the context might be nice, in that it\u0027s safe since it\u0027s not used (at least not currently). Should probably also make a note in detach_volume itself that if the context parameter ever is used, that _detach_instance_volumes needs to be updated.","commit_id":"9e80d1be6ad50ad7dbb1080df84ff4ab19bdfba2"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"416ce3f97b3c6f0a413ae50b5d9d9fe1f88a602b","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            for disk in block_device_mapping:"},{"line_number":436,"context_line":"                connection_info \u003d disk[\u0027connection_info\u0027]"},{"line_number":437,"context_line":"                try:"},{"line_number":438,"context_line":"                    self.detach_volume(None, connection_info, instance,"},{"line_number":439,"context_line":"                                       disk.get(\u0027device_name\u0027))"},{"line_number":440,"context_line":"                except exception.DiskNotFound:"},{"line_number":441,"context_line":"                    LOG.warning(\u0027The volume %s does not exist!\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf659307_0fd5271c","line":438,"in_reply_to":"bf659307_ef431312","updated":"2018-03-29 14:26:02.000000000","message":"Done","commit_id":"9e80d1be6ad50ad7dbb1080df84ff4ab19bdfba2"}]}