)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"69c3e50e8d507dfc43acaf7575f7dc5c7c3b460e","unresolved":false,"context_lines":[{"line_number":3621,"context_line":"        LOG.debug(_(\"Getting spice console\"), instance\u003dinstance)"},{"line_number":3622,"context_line":"        token \u003d str(uuid.uuid4())"},{"line_number":3623,"context_line":""},{"line_number":3624,"context_line":"        instance \u003d instance_obj.Instance._from_db_object("},{"line_number":3625,"context_line":"            context, instance_obj.Instance(), instance)"},{"line_number":3626,"context_line":""},{"line_number":3627,"context_line":"        if not CONF.spice.enabled:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B84w%3D","line":3624,"updated":"2013-11-18 07:40:13.000000000","message":"please do not use the insternal instance method - it would be better to use get_by_uuid. https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L260 or get_by_id https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L271","commit_id":"90dac5dc157a4fd2fe9d4d5ef124bf62f1451cdb"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"69c3e50e8d507dfc43acaf7575f7dc5c7c3b460e","unresolved":false,"context_lines":[{"line_number":3654,"context_line":"    @wrap_instance_fault"},{"line_number":3655,"context_line":"    def validate_console_port(self, ctxt, instance, port, console_type):"},{"line_number":3656,"context_line":"        if console_type \u003d\u003d \"spice-html5\":"},{"line_number":3657,"context_line":"            instance \u003d instance_obj.Instance._from_db_object("},{"line_number":3658,"context_line":"                ctxt, instance_obj.Instance(), instance)"},{"line_number":3659,"context_line":"            console_info \u003d self.driver.get_spice_console(ctxt, instance)"},{"line_number":3660,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B84s%3D","line":3657,"updated":"2013-11-18 07:40:13.000000000","message":"ditto","commit_id":"90dac5dc157a4fd2fe9d4d5ef124bf62f1451cdb"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d629bdfed2b90b65a97944bdbcb17ba774527e9e","unresolved":false,"context_lines":[{"line_number":3621,"context_line":"        LOG.debug(_(\"Getting spice console\"), instance\u003dinstance)"},{"line_number":3622,"context_line":"        token \u003d str(uuid.uuid4())"},{"line_number":3623,"context_line":""},{"line_number":3624,"context_line":"        instance \u003d instance_obj.Instance._from_db_object("},{"line_number":3625,"context_line":"            context, instance_obj.Instance(), instance)"},{"line_number":3626,"context_line":""},{"line_number":3627,"context_line":"        if not CONF.spice.enabled:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B3ag%3D","line":3624,"updated":"2013-11-19 07:23:47.000000000","message":"please see the comments on patch set 2","commit_id":"c540fb8607c2abbc89b0c4663fb7d12054911dd3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0c7bda42c4f33dd44c1f52948e4a0dd2978ff782","unresolved":false,"context_lines":[{"line_number":3621,"context_line":"        LOG.debug(_(\"Getting spice console\"), instance\u003dinstance)"},{"line_number":3622,"context_line":"        token \u003d str(uuid.uuid4())"},{"line_number":3623,"context_line":""},{"line_number":3624,"context_line":"        instance \u003d instance_obj.Instance._from_db_object("},{"line_number":3625,"context_line":"            context, instance_obj.Instance(), instance)"},{"line_number":3626,"context_line":""},{"line_number":3627,"context_line":"        if not CONF.spice.enabled:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BqD4%3D","line":3624,"in_reply_to":"AAAATn%2F%2B020%3D","updated":"2013-11-21 22:47:28.000000000","message":"Right.","commit_id":"c540fb8607c2abbc89b0c4663fb7d12054911dd3"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"79362738981516826b5399987bd66c5cb5cf5a71","unresolved":false,"context_lines":[{"line_number":3621,"context_line":"        LOG.debug(_(\"Getting spice console\"), instance\u003dinstance)"},{"line_number":3622,"context_line":"        token \u003d str(uuid.uuid4())"},{"line_number":3623,"context_line":""},{"line_number":3624,"context_line":"        instance \u003d instance_obj.Instance._from_db_object("},{"line_number":3625,"context_line":"            context, instance_obj.Instance(), instance)"},{"line_number":3626,"context_line":""},{"line_number":3627,"context_line":"        if not CONF.spice.enabled:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B020%3D","line":3624,"in_reply_to":"AAAATn%2F%2B3ag%3D","updated":"2013-11-19 16:59:01.000000000","message":"I thought I responded to this already.\n\nAnyway, this method is already used elsewhere in the compute manager.  AFAICT, it\u0027s a transitional method and not something intended to exist long term.  It\u0027s needed while not all code has been converted to objects.\n\nChanging to get_by_uuid() as you suggest is worse, because it requires a db query, while this does not.","commit_id":"c540fb8607c2abbc89b0c4663fb7d12054911dd3"}],"nova/virt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0c7bda42c4f33dd44c1f52948e4a0dd2978ff782","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        # TODO(Vek): Need to pass context in for access to auth_token"},{"line_number":292,"context_line":"        raise NotImplementedError()"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def get_spice_console(self, context, instance):"},{"line_number":295,"context_line":"        \"\"\"Get connection info for a spice console."},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        :param context: security context"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BqDo%3D","line":294,"updated":"2013-11-21 22:47:28.000000000","message":"I\u0027m not sure this change is really necessary, FWIW. The instance has the right context embedded in it now. But, it doesn\u0027t hurt anything.","commit_id":"c540fb8607c2abbc89b0c4663fb7d12054911dd3"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"105f9cfc47d622ca3935af1748108e6a6015403c","unresolved":false,"context_lines":[{"line_number":2218,"context_line":""},{"line_number":2219,"context_line":"        return {\u0027host\u0027: host, \u0027port\u0027: port, \u0027internal_access_path\u0027: None}"},{"line_number":2220,"context_line":""},{"line_number":2221,"context_line":"    def get_spice_console(self, context, instance):"},{"line_number":2222,"context_line":"        def get_spice_ports_for_instance(instance_name):"},{"line_number":2223,"context_line":"            virt_dom \u003d self._lookup_by_name(instance_name)"},{"line_number":2224,"context_line":"            xml \u003d virt_dom.XMLDesc(0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FGnM%3D","line":2221,"updated":"2013-11-14 11:46:59.000000000","message":"I\u0027d expect the API signature for this to match  get_vnc_console which doesn\u0027t have any \u0027context\u0027 parameter. Seems like this patch should be updating both in the same way.","commit_id":"863ecd4d9ad4d24489e0f2c56b9df91eff2c97ab"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"608a67aafdf51d3d58778c94a323444e363d96ad","unresolved":false,"context_lines":[{"line_number":2218,"context_line":""},{"line_number":2219,"context_line":"        return {\u0027host\u0027: host, \u0027port\u0027: port, \u0027internal_access_path\u0027: None}"},{"line_number":2220,"context_line":""},{"line_number":2221,"context_line":"    def get_spice_console(self, context, instance):"},{"line_number":2222,"context_line":"        def get_spice_ports_for_instance(instance_name):"},{"line_number":2223,"context_line":"            virt_dom \u003d self._lookup_by_name(instance_name)"},{"line_number":2224,"context_line":"            xml \u003d virt_dom.XMLDesc(0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2FFT4%3D","line":2221,"in_reply_to":"AAAATn%2F%2FGnM%3D","updated":"2013-11-14 16:22:58.000000000","message":"get_spice_console gets updated in another patch in this series\n\nhttps://review.openstack.org/#/c/55748/","commit_id":"863ecd4d9ad4d24489e0f2c56b9df91eff2c97ab"}]}