)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"fe30af3ad63e7bade1319a794a310eb643e392c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Russell Bryant \u003crbryant@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-26 19:24:40 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update vnc virt api to take Instance object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update the get_vnc_console() virt api method to take an Instance object"},{"line_number":10,"context_line":"instead of a dict.  No real changes were needed in the drivers to make"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAATn%2F%2BF9A%3D","line":7,"updated":"2013-12-02 16:39:21.000000000","message":"This threw me off a bit as I was used to virt api being the indirection class we use in order to avoid passing the conductor to the drivers.\n\nI vote for changing the title to mention get_vnc_console, but if the rebase will be too much of a pain - I can look the other way :)","commit_id":"1b94bfed9ca74780732de963dfa4899e54ef77a6"}],"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"91ac88260e34cb4766aa9e3b70a277eba875100b","unresolved":false,"context_lines":[{"line_number":3582,"context_line":"    @wrap_instance_fault"},{"line_number":3583,"context_line":"    def get_vnc_console(self, context, console_type, instance):"},{"line_number":3584,"context_line":"        \"\"\"Return connection information for a vnc console.\"\"\""},{"line_number":3585,"context_line":"        instance \u003d instance_obj.Instance._from_db_object("},{"line_number":3586,"context_line":"            context, instance_obj.Instance(), instance)"},{"line_number":3587,"context_line":"        context \u003d context.elevated()"},{"line_number":3588,"context_line":"        LOG.debug(_(\"Getting vnc console\"), instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B%2FTM%3D","line":3585,"updated":"2013-11-16 07:39:43.000000000","message":"why not use - instance_obj.Instance.get_by_uuid or instance_obj.Instance.get_by_id?\nThe _from_db_object is an internal method. I do not think that it should be used here.","commit_id":"1e915b5ad9b864f9cee0c04235d842e951351dce"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"91ac88260e34cb4766aa9e3b70a277eba875100b","unresolved":false,"context_lines":[{"line_number":3653,"context_line":"    @wrap_exception()"},{"line_number":3654,"context_line":"    @wrap_instance_fault"},{"line_number":3655,"context_line":"    def validate_console_port(self, ctxt, instance, port, console_type):"},{"line_number":3656,"context_line":"        instance \u003d instance_obj.Instance._from_db_object("},{"line_number":3657,"context_line":"            ctxt, instance_obj.Instance(), instance)"},{"line_number":3658,"context_line":""},{"line_number":3659,"context_line":"        if console_type \u003d\u003d \"spice-html5\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B%2FTI%3D","line":3656,"updated":"2013-11-16 07:39:43.000000000","message":"ditto","commit_id":"1e915b5ad9b864f9cee0c04235d842e951351dce"}],"nova/tests/virt/docker/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc123788a66ebb96c13854b2931a21d8a5158918","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    #NOTE(bcwaldon): This exists only because _get_running_instance on the"},{"line_number":62,"context_line":"    # base class will not let us set a custom disk/container_format."},{"line_number":63,"context_line":"    def _get_running_instance(self, obj\u003dFalse):"},{"line_number":64,"context_line":"        instance_ref \u003d utils.get_test_instance(obj\u003dobj)"},{"line_number":65,"context_line":"        network_info \u003d utils.get_test_network_info()"},{"line_number":66,"context_line":"        network_info[0][\u0027network\u0027][\u0027subnets\u0027][0][\u0027meta\u0027][\u0027dhcp_server\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9Vc0%3D","line":63,"updated":"2013-12-12 15:01:18.000000000","message":"Why is this changing for this get_vnc_console to use objects patch?  Docker doesn\u0027t support VNC console according to the hypervisor support matrix.","commit_id":"46212a8bcdb34c7e6a1aa53386e0d5bc13860414"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"74c44b3b21df638dc53d31b070bd9c58444aadfc","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    #NOTE(bcwaldon): This exists only because _get_running_instance on the"},{"line_number":62,"context_line":"    # base class will not let us set a custom disk/container_format."},{"line_number":63,"context_line":"    def _get_running_instance(self, obj\u003dFalse):"},{"line_number":64,"context_line":"        instance_ref \u003d utils.get_test_instance(obj\u003dobj)"},{"line_number":65,"context_line":"        network_info \u003d utils.get_test_network_info()"},{"line_number":66,"context_line":"        network_info[0][\u0027network\u0027][\u0027subnets\u0027][0][\u0027meta\u0027][\u0027dhcp_server\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9S7g%3D","line":63,"in_reply_to":"AAAATn%2F9Vc0%3D","updated":"2013-12-12 22:57:45.000000000","message":"File \"nova/tests/virt/test_virt_drivers.py\", line 505, in test_get_vnc_console\n    instance, network_info \u003d self._get_running_instance(obj\u003dTrue)\n\nThis is used by the base class _VirtDriverTestCase","commit_id":"46212a8bcdb34c7e6a1aa53386e0d5bc13860414"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc123788a66ebb96c13854b2931a21d8a5158918","unresolved":false,"context_lines":[{"line_number":2270,"context_line":"            # NOTE(rmk): We had VNC consoles enabled but the instance in"},{"line_number":2271,"context_line":"            # question is not actually listening for connections."},{"line_number":2272,"context_line":"            raise exception.ConsoleTypeUnavailable(console_type\u003d\u0027vnc\u0027)"},{"line_number":2273,"context_line":""},{"line_number":2274,"context_line":"        port \u003d get_vnc_port_for_instance(instance[\u0027name\u0027])"},{"line_number":2275,"context_line":"        host \u003d CONF.vncserver_proxyclient_address"},{"line_number":2276,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9Vdw%3D","line":2273,"updated":"2013-12-12 15:01:18.000000000","message":"If instance is an object now, you should do it like instance.name.","commit_id":"46212a8bcdb34c7e6a1aa53386e0d5bc13860414"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"74c44b3b21df638dc53d31b070bd9c58444aadfc","unresolved":false,"context_lines":[{"line_number":2270,"context_line":"            # NOTE(rmk): We had VNC consoles enabled but the instance in"},{"line_number":2271,"context_line":"            # question is not actually listening for connections."},{"line_number":2272,"context_line":"            raise exception.ConsoleTypeUnavailable(console_type\u003d\u0027vnc\u0027)"},{"line_number":2273,"context_line":""},{"line_number":2274,"context_line":"        port \u003d get_vnc_port_for_instance(instance[\u0027name\u0027])"},{"line_number":2275,"context_line":"        host \u003d CONF.vncserver_proxyclient_address"},{"line_number":2276,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9S7A%3D","line":2273,"in_reply_to":"AAAATn%2F9Vdw%3D","updated":"2013-12-12 22:57:45.000000000","message":"Done","commit_id":"46212a8bcdb34c7e6a1aa53386e0d5bc13860414"}],"nova/virt/xenapi/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dc123788a66ebb96c13854b2931a21d8a5158918","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def get_vnc_console(self, context, instance):"},{"line_number":395,"context_line":"        \"\"\"Return link to instance\u0027s VNC console.\"\"\""},{"line_number":396,"context_line":"        return self._vmops.get_vnc_console(instance)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def get_volume_connector(self, instance):"},{"line_number":399,"context_line":"        \"\"\"Return volume connector information.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9Vdg%3D","line":396,"updated":"2013-12-12 15:01:18.000000000","message":"xenapi vmops get_vnc_console is getting an instance object now, so it should treat it like an object rather than a dict:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/xenapi/vmops.py#L1569","commit_id":"46212a8bcdb34c7e6a1aa53386e0d5bc13860414"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"74c44b3b21df638dc53d31b070bd9c58444aadfc","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def get_vnc_console(self, context, instance):"},{"line_number":395,"context_line":"        \"\"\"Return link to instance\u0027s VNC console.\"\"\""},{"line_number":396,"context_line":"        return self._vmops.get_vnc_console(instance)"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def get_volume_connector(self, instance):"},{"line_number":399,"context_line":"        \"\"\"Return volume connector information.\"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9S5U%3D","line":396,"in_reply_to":"AAAATn%2F9Vdg%3D","updated":"2013-12-12 22:57:45.000000000","message":"Done","commit_id":"46212a8bcdb34c7e6a1aa53386e0d5bc13860414"}]}