)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"265b181f013f8f9d4f2320a1a5fa2af14013e09e","unresolved":false,"context_lines":[{"line_number":3555,"context_line":"    @wrap_instance_fault"},{"line_number":3556,"context_line":"    def get_console_output(self, context, instance, tail_length):"},{"line_number":3557,"context_line":"        \"\"\"Send the console output for the given instance.\"\"\""},{"line_number":3558,"context_line":"        instance \u003d instance_obj.Instance._from_db_object("},{"line_number":3559,"context_line":"            context, instance_obj.Instance(), instance)"},{"line_number":3560,"context_line":"        context \u003d context.elevated()"},{"line_number":3561,"context_line":"        LOG.audit(_(\"Get console output\"), context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B3aM%3D","line":3558,"updated":"2013-11-19 07:26:50.000000000","message":"please do not use the internal db method. can you please use get_by_uuid or get_by_id.","commit_id":"cb64f03bac3ab64fe63c59ae2bbba08777ee1e31"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f7e1c42f3e8efae44b6fbf9cb47903e5f9c81fde","unresolved":false,"context_lines":[{"line_number":3555,"context_line":"    @wrap_instance_fault"},{"line_number":3556,"context_line":"    def get_console_output(self, context, instance, tail_length):"},{"line_number":3557,"context_line":"        \"\"\"Send the console output for the given instance.\"\"\""},{"line_number":3558,"context_line":"        instance \u003d instance_obj.Instance._from_db_object("},{"line_number":3559,"context_line":"            context, instance_obj.Instance(), instance)"},{"line_number":3560,"context_line":"        context \u003d context.elevated()"},{"line_number":3561,"context_line":"        LOG.audit(_(\"Get console output\"), context\u003dcontext,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2B3U0%3D","line":3558,"in_reply_to":"AAAATn%2F%2B3aM%3D","updated":"2013-11-19 07:48:42.000000000","message":"It\u0027s used elsewhere already.  It\u0027s a transitional thing while everything isn\u0027t converted to objects, yet.","commit_id":"cb64f03bac3ab64fe63c59ae2bbba08777ee1e31"}],"nova/tests/virt/vmwareapi/test_vmwareapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d1e14ebe00a113fa3f6e25c6d4d146b5406b0f97","unresolved":false,"context_lines":[{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    def test_get_console_output(self):"},{"line_number":714,"context_line":"        self._create_instance_in_the_db()"},{"line_number":715,"context_line":"        res \u003d self.conn.get_console_output(self.context, self.instance)"},{"line_number":716,"context_line":"        self.assertNotEqual(0, len(res))"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"    def _test_finish_migration(self, power_on, resize_instance\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9Prk%3D","line":715,"updated":"2013-12-13 15:20:23.000000000","message":"self.instance here is a dict, right?  Shouldn\u0027t that be converted to an object for this test?  I think you can use nova.tests.fake_instance.fake_instance_obj(self.context, self.instance) to do that.","commit_id":"41cfe33471fa881cca2776464df03a1dddea3a1e"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d1e14ebe00a113fa3f6e25c6d4d146b5406b0f97","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        # a PNG format. The vCenter and ESX do not provide a way"},{"line_number":267,"context_line":"        # to get the text based console format."},{"line_number":268,"context_line":"        return _(\"Currently there is no log available for \""},{"line_number":269,"context_line":"                 \"instance %s\") % instance[\u0027uuid\u0027]"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def get_vnc_console(self, context, instance):"},{"line_number":272,"context_line":"        \"\"\"Return link to instance\u0027s VNC console.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9PqM%3D","line":269,"updated":"2013-12-13 15:20:23.000000000","message":"Should be instance.uuid.  Note that unless test_vmwareapi converts the fake instance to an object, instance.uuid will fail - but that\u0027s the point of changing the test.","commit_id":"41cfe33471fa881cca2776464df03a1dddea3a1e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bb45ea637e28b6e50236f97ba9ea839c75eeb7ee","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        # a PNG format. The vCenter and ESX do not provide a way"},{"line_number":267,"context_line":"        # to get the text based console format."},{"line_number":268,"context_line":"        return _(\"Currently there is no log available for \""},{"line_number":269,"context_line":"                 \"instance %s\") % instance[\u0027uuid\u0027]"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def get_vnc_console(self, context, instance):"},{"line_number":272,"context_line":"        \"\"\"Return link to instance\u0027s VNC console.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9Pbo%3D","line":269,"in_reply_to":"AAAATn%2F9PnQ%3D","updated":"2013-12-13 16:05:58.000000000","message":"Nevermind, you\u0027re removing it later in the patch series with change Ice72b0aba8af49b07528b30f46c012d69b712735.","commit_id":"41cfe33471fa881cca2776464df03a1dddea3a1e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"32578a104c60c7898dd005affc10ddc02fefdc7e","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        # a PNG format. The vCenter and ESX do not provide a way"},{"line_number":267,"context_line":"        # to get the text based console format."},{"line_number":268,"context_line":"        return _(\"Currently there is no log available for \""},{"line_number":269,"context_line":"                 \"instance %s\") % instance[\u0027uuid\u0027]"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def get_vnc_console(self, context, instance):"},{"line_number":272,"context_line":"        \"\"\"Return link to instance\u0027s VNC console.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9PnQ%3D","line":269,"in_reply_to":"AAAATn%2F9PqM%3D","updated":"2013-12-13 15:26:09.000000000","message":"I\u0027m also a bit confused with the vmware driver code because their vmops does implement get_console_output:\n\nhttps://github.com/openstack/nova/blob/master/nova/virt/vmwareapi/vmops.py#L1340\n\nMaybe that\u0027s only if you\u0027re using the VMwareVCDriver, but they don\u0027t override get_console_output in that class.","commit_id":"41cfe33471fa881cca2776464df03a1dddea3a1e"}],"nova/virt/xenapi/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d1e14ebe00a113fa3f6e25c6d4d146b5406b0f97","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def get_console_output(self, context, instance):"},{"line_number":392,"context_line":"        \"\"\"Return snapshot of console.\"\"\""},{"line_number":393,"context_line":"        return self._vmops.get_console_output(instance)"},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"    def get_vnc_console(self, context, instance):"},{"line_number":396,"context_line":"        \"\"\"Return link to instance\u0027s VNC console.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9Pps%3D","line":393,"updated":"2013-12-13 15:20:23.000000000","message":"Note to self, I checked the xenapi.vmops.get_console_output method and it\u0027s not using instance as a dict specifically so nothing to change there.","commit_id":"41cfe33471fa881cca2776464df03a1dddea3a1e"}]}