)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"42cb95dc182b717917258e0a6769da9a183921c7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Anchor providers (those not providing any resource themselves, but"},{"line_number":10,"context_line":"serving as anchor points for sharing providers which do) now show up in"},{"line_number":11,"context_line":"the response payload of GET /allocation_candidates. In the"},{"line_number":12,"context_line":"allocation_request, they show up with an empty \"resources\" dict.  In the"},{"line_number":13,"context_line":"provider_summaries (where they were previously absent unless they"},{"line_number":14,"context_line":"provided resource for some other allocation_request) they now appear"},{"line_number":15,"context_line":"with their usage information as expected."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bf659307_a46c32ce","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":63},"updated":"2018-04-02 07:34:29.000000000","message":"Is empty \"resources\" dict available for the request body of `PUT /allocations/{consumer_uuid}` API? or should we need that work in the following patches?","commit_id":"22d339b26fd56ce23ff78e9425e90ee1dc81a948"}],"nova/api/openstack/placement/handlers/allocation_candidate.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"42cb95dc182b717917258e0a6769da9a183921c7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            res_dict \u003d rp_resources[rr.resource_provider.uuid][\u0027resources\u0027]"},{"line_number":66,"context_line":"            try:"},{"line_number":67,"context_line":"                res_dict[rr.resource_class] \u003d rr.amount"},{"line_number":68,"context_line":"            except NotImplementedError:"},{"line_number":69,"context_line":"                # Special case: An \"empty\" resource_request indicating an"},{"line_number":70,"context_line":"                # \"anchor\" provider.  Leave the resources dict empty."},{"line_number":71,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_e47c6a73","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":39},"updated":"2018-04-02 07:34:29.000000000","message":"Treating this as an NotImplementedError sounds a bit strange to me... Can\u0027t we just allow to set AllocationRequestResource.resouce_class to \"None\" ?","commit_id":"22d339b26fd56ce23ff78e9425e90ee1dc81a948"}],"nova/api/openstack/placement/objects/resource_provider.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"42cb95dc182b717917258e0a6769da9a183921c7","unresolved":false,"context_lines":[{"line_number":3323,"context_line":"                # resources itself), add an \"empty\" AllocationRequestResource"},{"line_number":3324,"context_line":"                # so the anchor shows up in the results."},{"line_number":3325,"context_line":"                res_req_dict[None].append("},{"line_number":3326,"context_line":"                    AllocationRequestResource(ctx, resource_provider\u003dns_rp))"},{"line_number":3327,"context_line":""},{"line_number":3328,"context_line":"        # Build a dict, keyed by resource class ID, of lists of"},{"line_number":3329,"context_line":"        # AllocationRequestResource objects that represent each"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf659307_848b2e66","line":3326,"range":{"start_line":3326,"start_character":46,"end_line":3326,"end_character":74},"updated":"2018-04-02 07:34:29.000000000","message":"Here can\u0027t we set AllocationRequestResource.resouce_class to \"None\" explicitly by allowing that?","commit_id":"22d339b26fd56ce23ff78e9425e90ee1dc81a948"}]}
